aboutsummaryrefslogtreecommitdiffstats
path: root/apps/app_voicemail.c
AgeCommit message (Collapse)AuthorFilesLines
2009-10-21Suffix is not needed for a matchtilghman1-16/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225103 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-22When IMAP variables were changed during a reload, Voicemail did not use the ↵tilghman1-2/+22
new values. This change introduces a configuration version variable, which ensures that connections with the old values are not reused but are allowed to expire normally. (closes issue #15934) Reported by: viniciusfontes Patches: 20090922__issue15934.diff.txt uploaded by tilghman (license 14) Tested by: viniciusfontes git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@219816 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-15If the user enters the same password as before, don't signal an error when ↵tilghman1-8/+7
the change does nothing. (closes issue #15492) Reported by: cbbs70a Patches: 20090713__issue15492.diff.txt uploaded by tilghman (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@218730 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-14Don't say "Please try again" if we don't give the user another chance to try ↵tilghman1-0/+6
again. (issue #15055, SWP-129) Reported by: jthurman git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@218331 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-10AST-2009-005tilghman1-16/+16
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@211528 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-26Fixing voicemail's error in checking max silence vs min message lengthdbrooks1-1/+1
Max silence was represented in milliseconds, yet vmminsecs (minmessage) was represented as seconds. Also, the inequality was reversed. The warning, if triggered, was "Max silence should be less than minmessage or you may get empty messages", which should have been logged if max silence was greater than minmessage, but the check was for less than. Also, conforming if statement to coding guidelines. closes issue #15331) Reported by: markd Review: https://reviewboard.asterisk.org/r/293/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@203719 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-19Ensure thread keys are initialized before attempting to access them.tilghman1-0/+3
(closes issue #14889) Reported by: jaroth Patches: app_voicemail.c.patch uploaded by msirota (license 758) Tested by: msirota, BlargMaN git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@195520 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-18Add a similar dependency on SMDI for voicemail as already exists for ADSI.tilghman1-0/+13
(closes issue #14846) Reported by: pj Patches: 20090413__bug14846__1.4.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.0.diff.txt uploaded by tilghman (license 14) 20090507__issue14846__1.6.1.diff.txt uploaded by tilghman (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@195366 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-12Avoid initializing routines if the authentication fails. Fixes a crash (RR) ↵tilghman1-4/+7
issue. (closes issue #14508) Reported by: tiziano Patches: 20090221_2_wrongmailbox.diff.txt uploaded by tiziano (license 377) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@193955 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-11Move 300 bytes around on the stack, to make more room for an extension buffer.tilghman1-3/+6
This allows more concurrent extensions to be copied for a single voicemail, without creating a possibility of upsetting existing users, where a dialplan could run out of stack space where it had run fine before. Alternatively, we could have allocated off the heap, but that is a larger change and would have increased the chance for instability introduced by this change. This is really solved starting in 1.6.0.11, as the use of an ast_str buffer allows an unlimited number of extensions (up to available memory). We additionally create a new warning message when the buffer length is exceeded, permitting administrators to see an issue after the fact, whereas previously the list was silently truncated. (closes issue #14739) Reported by: p_lindheimer Patches: 20090417__bug14739.diff.txt uploaded by tilghman (license 14) Tested by: p_lindheimer git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@193755 f38db490-d61c-443f-a65b-d21fe96a405b
2009-05-02Fix a bug which resulted from the Hebrew voicemail commit.mmichelson1-37/+47
This fixes a case where a certain message could get played twice. (closes issue #13155) Reported by: greenfieldtech Patches: app_voicemail.c.multi-lang-patch uploaded by greenfieldtech (license 369) Tested by: greenfieldtech git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@191778 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-16Umask should not be exported into global namespace.tilghman1-1/+1
(closes issue #14912) Reported by: jcapp git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@188773 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-06Revert commit 186445 because it causes the build to fail when IMAP_STORAGE ↵mmichelson1-1/+1
is used. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@186565 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-03Found a conflict in the last commit, due to multiple targetstilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@186445 f38db490-d61c-443f-a65b-d21fe96a405b
2009-04-03Distinguish in a sent email between simple sends and forwards.tilghman1-20/+94
(closes issue #11678) Reported by: jamessan Patches: 20090330__bug11678.diff.txt uploaded by tilghman (license 14) Tested by: tilghman, lmadsen git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@186415 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-31Fix Russian voicemail intro to say the word "messages" properly.mmichelson1-6/+2
(closes issue #14736) Reported by: chappell Patches: voicemail_no_messages.diff uploaded by chappell (license 8) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@185468 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-06Make compilation succeed in dev-mode when IMAP storage is enabled.mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@180567 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-05[IMAP] Fix message retrieval issues when identical mailbox names were ↵mmichelson1-0/+2
defined in separate contexts. There was a fix put in a while back so that an X-Asterisk-VM-Context message header was added to stored IMAP voicemails. This would allow for us to differentiate if the same mailbox name was used in multiple contexts. The problem still left was that not all places where messages were retrieved actually attempted to use this header for information when retrieving messages. This commit fixes that so that MWI and message retrieval from VoiceMailMain work as expected. (closes issue #13853) Reported by: vicks1 Patches: 13853_v2.patch uploaded by mmichelson (license 60) Tested by: lmadsen git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@180464 f38db490-d61c-443f-a65b-d21fe96a405b
2009-03-05Fix broken mailbox parsing when searchcontexts option is enabled.mmichelson1-10/+18
When using the searchcontexts option in voicemail.conf, the code made the assumption that all mailbox names defined were unique across all contexts. However, the code did nothing to actually enforce this assumption, nor did it do anything to alert a user that he may have created an ambiguity in his voicemail.conf file by defining the same mailbox name in multiple contexts. With this change, we now will issue a nice long warning if searchcontexts is on and we encounter the same mailbox name in multiple contexts and ignore any duplicates after the first box. Whether searchcontexts is enabled or not, if we come across a duplicate mailbox in the same context, then we will issue a warning and ignore the duplicated mailbox. I have also added a small note to voicemail.conf.sample in the explanation for searchcontexts explaining that you cannot define the same mailbox in multiple contexts if you have enabled the option. (closes issue #14599) Reported by: lmadsen Patches: 14599.patch uploaded by mmichelson (license 60) (with slight modification) Tested by: lmadsen git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@180380 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-19Fix up potential crashes, by reducing the sharing between interactive and ↵tilghman1-3/+42
non-interactive threads. (closes issue #14253) Reported by: Skavin Patches: 20090219__bug14253.diff.txt uploaded by Corydon76 (license 14) Tested by: Skavin git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@177536 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-13Fix a potential crash situation when using IMAP voicemailmmichelson1-1/+2
If calling into VoiceMailMain when using IMAP storage, it was possible to crash Asterisk by hanging up the phone when prompted for a voicemail mailbox. This patch fixes the issue. While it may appear that this patch is superficial, it allows code execution to continue to the failure case just below the IMAP_STORAGE code block where this patch has been applied (closes issue #14473) Reported by: dwpaul Patches: voicemail_imap_crash_no_mailbox.patch uploaded by dwpaul (license 689) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@175590 f38db490-d61c-443f-a65b-d21fe96a405b
2009-02-05Add new configuration option to make shared IMAP mailboxes function as expected.jpeeler1-2/+11
The new option is "imapvmshareid" which is an ID to tag multiple mailboxes using the same IMAP storage location to function as one mailbox. This allows all messages to be retrieved for any user in the group. The patch alters the 'X-Asterisk-VM-Extension' header that is responsible for matching voicemails for a given user. (closes issue #13673) Reported by: howardwilkinson git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@173696 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Fix the conjugation of Russian and Ukrainian languages.tilghman1-148/+98
(related to issue #12475) Reported by: chappell Patches: vm_multilang.patch uploaded by chappell (license 8) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168828 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-18Add mutexes around accesses to the IMAP library interface. This preventstilghman1-8/+42
certain crashes, especially when shared mailboxes are used. (closes issue #13653) Reported by: howardwilkinson Patches: asterisk-1.4.21.2-appvoicemail-sharedimap-lock.patch uploaded by howardwilkinson (license 590) Tested by: jpeeler git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@165767 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-09Oops, should be "tz", not "zonetag".tilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162463 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-09We appear to have documented tz= in the [general] section of voicemail.conf,tilghman1-0/+5
without actually having implemented it. Oops. (Reported by Olivier on the -users list) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162348 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03Some compilers warn on null format strings; some don't (caught by buildbot)tilghman1-6/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@160770 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-02Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcctilghman1-1/+3
and glibc. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@160207 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14If the prompt to reenter a voicemail password timed out, itmmichelson1-1/+1
resulted in the password not being saved, even if the input matched what you gave when first prompted to enter a new password. This is because the return value of ast_readstring was checked, but not checked properly. This bug was discovered by Jared Smith during an Asterisk training course. Thanks for reporting it! git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156816 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-03Attempting to expunge a mailbox when the mailstream is NULL will crash Asterisk.tilghman1-1/+1
(Closes issue #13829) Reported by: jaroth Patch by: me (modified jaroth's patch) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@154066 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-01fix a bunch of potential problems found by gcc 4.3.x, primarily bare strings ↵kpfleming1-1/+3
being passed to printf()-like functions and ignored results from read()/write() and friends git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@153337 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-28Quoting in the wrong directiontilghman1-1/+1
(Fixes AST-107) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@152463 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-14Some compilers warn, some don't. Fixing.tilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@148987 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-14Ensure that mail headers are 7-bit clean, even when UTF-8 characters are usedtilghman1-24/+136
in headers like 'Subject' and 'To'. Closes AST-107. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@148916 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-10User not notified of temporary greeting, if ODBC storage is in use.tilghman1-0/+4
(closes issue #13659) Reported by: moliveras Patches: 20081009__bug13659.diff.txt uploaded by Corydon76 (license 14) Tested by: moliveras git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@148257 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-09When blank, callerid name and number should display "unknown caller" in ↵tilghman1-1/+2
voicemail emails. (Closes issue #13643) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@147997 f38db490-d61c-443f-a65b-d21fe96a405b
2008-10-07Make 'imapsecret' an alias to 'imappassword' in voicemail.conf.seanbright1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@147193 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-25Backport Hebrew language to voicemail.tilghman1-4/+133
(closes issue #13155) Reported by: greenfieldtech Patches: voicemail-hebrew-patch-1.4-SVN.c.patch uploaded by greenfieldtech (license 369) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@144356 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-17When callerid is blank, we want to use "unknown caller" in those cases, too.tilghman1-2/+2
(closes issue #13486) Reported by: tomo1657 Patches: 20080917__bug13486.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@143404 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-12Missing merge from 1.2 fixes errant exit on DTMF, only when language is Italiantilghman1-1/+1
(cf commit 34242) (Closes issue #7353) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@142744 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-05Since greetings are not stored in IMAP, we shouldmmichelson1-1/+9
not be DISPOSE'ing of them the same way we do with other messages. (closes issue #13414) Reported by: mthomasslo Patches: 13414v2.patch uploaded by putnopvut (license 60) Tested by: mthomasslo git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141267 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-03Fix voicemail forwarding when using ODBC storage.mmichelson1-2/+13
(closes issue #13387) Reported by: moliveras Patches: 13387.patch uploaded by putnopvut (license 60) Tested by: putnopvut, moliveras git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140850 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-02After adding the context checking to app_voicemailmmichelson1-0/+1
for IMAP storage, I left out a crucial place to copy the context to the vm_state structure. This is the correction. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140751 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-29Add context checking when retrieving a vm_state.mmichelson1-12/+15
This was causing a problem for people who had identically named mailboxes in separate voicemail contexts. This commit affects IMAP storage only. (closes issue #13194) Reported by: moliveras Patches: 13194.patch uploaded by putnopvut (license 60) Tested by: putnopvut, moliveras git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140421 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-07work around a bug in gcc-4.2.3 that incorrectly ignores the casting away of ↵kpfleming1-2/+2
'const' for pointers when the developer knows it is safe to do so git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136458 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-04Memory leak on unloadtilghman1-10/+21
(closes issue #13231) Reported by: eliel Patches: app_voicemail.leak.patch uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135479 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-29Merging the imap_consistency branch.mmichelson1-1553/+1223
The main aim of this branch was to make the IMAP code function in the same manner as the ODBC code does, eliminating the need for so many IMAP-specific code chunks. The focal point of all of this work was to make the various macros (e.g. RETRIEVE, DISPOSE) functionally equivalent. While doing the above work, I also fixed a few bugs that I came across in my testing. Among these were 1. Fixed message forwarding. This was completely broken when using IMAP. 2. Fixed the inability to save new messages as old and vice versa. 3. Fixed the "delete" options in voicemail.conf when using IMAP storage. Even though a few bugs were fixed and the code is a lot more consistent, the one thing that was *not* improved in this branch was performance. The merge of this to trunk may not come immediately due to the amount of work it will probably involve. (closes issue #12764) Reported by: balsamcn git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134223 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-28Detect when sox fails to raise the volume, because sox can't read the file.tilghman1-4/+11
(closes issue #12939) Reported by: rickbradley Patches: 20080728__bug12939.diff.txt uploaded by Corydon76 (license 14) Tested by: rickbradley git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134161 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-25Remove unnecessary mmap flagtilghman1-1/+1
(Closes issue #13161) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133709 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-08Backport TCP-related timeouts to IMAP voicemail in 1.4mmichelson1-1/+32
since it should solve bugs people are experiencing. Specifically, there are times where communication with the IMAP server causes system calls to block forever. If this should happen when querying the mailbox so that chan_sip's do_monitor thread can send MWI to a phone, it means that SIP calls cannot be processed any more. The timeout options are outlined in doc/imapstorage.txt. Defaults for the timeouts are sixty seconds. (closes issue #12987) Reported by: mthomasslo git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@129158 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-05 02:04:33 +0000