aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2010-03-13Resolve unit test failure that occurred on Mac OSX.russell1-3/+7
On Linux (glibc), regcomp() does not return an error for an empty string. However, the version on OSX will return an error. The test for channel group matching by regex now passes on the mac, as well. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@252241 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-13Resolve compiler warning by paying attention to system() return value.russell1-1/+4
This resolves the last compile failure on bamboo. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@252229 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-12Test script to verify that timezone cache is properly removed on zonefile ↵tilghman1-0/+114
alteration. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@252133 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-12Only change the RTP ssrc when we see that it has changedtwilson12-59/+122
This change basically reverts the change reviewed in https://reviewboard.asterisk.org/r/374/ and instead limits the updating of the RTP synchronization source to only those times when we detect that the other side of the conversation has changed the ssrc. The problem is that SRCUPDATE control frames are sent many times where we don't want a new ssrc, including whenever Asterisk has to send DTMF in a normal bridge. This is also not the first time that this mistake has been made. The initial implementation of the ast_rtp_new_source function also changed the ssrc--and then it was removed because of this same issue. Then, we put it back in again to fix a different issue. This patch attempts to only change the ssrc when we see that the other side of the conversation has changed the ssrc. It also renames some functions to make their purpose more clear. Review: https://reviewboard.asterisk.org/r/540/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@252089 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-12add missing mfcr2_skip_category settingmoy1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@252088 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-12Don't override a user option with the global option.tilghman1-2/+0
(closes issue #16849) Reported by: ip-rob Patches: 20100311__issue16849.diff.txt uploaded by tilghman (license 14) Tested by: ip-rob git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251989 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-12Merged revisions 251986 via svnmerge from rmudgett0-0/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r251986 | rmudgett | 2010-03-12 13:33:22 -0600 (Fri, 12 Mar 2010) | 1 line Make chan_dahdi wakeup_sub() prototype not conditional. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251987 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-12Doxegen this chan_dahdi lock.rmudgett1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251946 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-11Because ExecIf needs to reprocess arguments, it's best if we don't remove ↵tilghman1-2/+2
quotes during parsing. (closes issue #16905) Reported by: ip-rob Patches: 20100303__issue16905.diff.txt uploaded by tilghman (license 14) Tested by: ip-rob git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251884 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-11Fix tests on 32-bit systems.tilghman1-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251881 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-11If the argument to the system application is quoted, ensure we remove the ↵tilghman1-2/+11
quotes before trying to execute. (closes issue #16842) Reported by: ip-rob Patches: 20100310__issue16842.diff.txt uploaded by tilghman (license 14) Tested by: ip-rob git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251877 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-11Minor tweaks and comment updates to chan_dahdi.rmudgett2-3/+10
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251821 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-11Add supporting code for app-directory pause option.alecdavis1-8/+30
Since 1.6.1 CLI help reports that option p(n) 'initial pause' is available. Supporting code was never implemented. (closes issue #16751) Reported by: alecdavis Patches: directory_pause.trunk.diff.txt uploaded by alecdavis (license 585) Tested by: alecdavis Review: https://reviewboard.asterisk.org/r/481/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251779 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10Add new unit test for stringfields.jpeeler2-0/+309
(Copied from reviewboard) Tests the following: 1. Basic allocation and setting of string fields. 2. Shrinking a string field and re-expanding it. 3. Growing the last allocation in a string field pool. 4. Setting a string to a large value such that a new string field pool must be allocated. In each part, we make sure that the string field is accurate (has the correct value in it), make sure that the 2 bytes before the string field has the correct capacity for the field, and for tests 2-4, we make sure that the string field is where we expect it to be in memory. Also tested: 5. Shrinking a string field and partially re-expanding it. 6. Setting strings in such a way as to create three separate string field pools and then removing the middle pool. There is a bug fix in the init function, which ensures the embedded_pool is set to NULL which is important for stack allocated structures. Review: https://reviewboard.asterisk.org/r/185/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251736 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10Hmmm, apparently needed to be fixed in trunk, too.tilghman1-1/+1
(closes issue #16900) Reported by: bluecrow76 Patches: asterisk-1.6.2.4-func_strings.diff uploaded by bluecrow76 (license 270) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251682 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10Be less ambiguous in Record() app docs.lmadsen1-1/+1
For some reason the documentation for the 'k' application in trunk and 1.6.2 is different than 1.6.0 and 1.6.1, so I'm setting them all to match. The wording in 1.6.2 and trunk was ambiguous, so you could interpret the wording the mean that recording would continue upon hangup indefinitely, or you could interpret it to mean that the recorded data would not be discarded upon hangup. This change makes it clear we mean the latter, and not the former. Came from a discussion in #asterisk on IRC. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251680 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10Fix ParkAndAnnounce not respecting parking options.jpeeler1-7/+181
The patch ensures that if a peer does not exist, parking settings are read from the channel. A unit test has been written to ensure proper operation for both standard parking and parking using masquerades. (closes issue #16592) Reported by: mwyres Patches: bug_16592.diff uploaded by snuffy (license 35) Review: https://reviewboard.asterisk.org/r/539/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251679 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10It's amazing what writing a test will find.tilghman2-1/+3
(issue #16900) Reported by: bluecrow76 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251677 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10Fix jitterbuffer logging not creating logfiles.jpeeler1-2/+4
Three changes made here: 1) Do not fail if a previous log does not exist (in fact, this is probably expected). 2) Ensure that the file descriptor to write to gets assigned properly. I am at a loss as to why assigning safe_fd outside the if fixes this, but it makes the if statement slightly less complicated anyway. 3) Move up the failure message so that the errno of the failure is not overwritten by fclose. (closes issue #16917) Reported by: Artem git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251631 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10Simplified dahdi_request() channel selection failed reason/cause code.rmudgett5-31/+21
Also avoid potential crash because cause could be NULL. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251585 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-10Reduce the amount of database access for HAVE_PRI_SERVICE_MESSAGES.rmudgett3-125/+113
Rework HAVE_PRI_SERVICE_MESSAGES to not use the active values directly from the database. Database access is likely expensive. Database access now only happens on initialization, destruction, and when the B channel is taken in or out of service. This change is not related to call waiting but it would cause the search for a call waiting interface to be very expensive and slow down D channel message servicing. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251538 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-09Build system modifications to ensure that Asterisk properly builds on Mac OS ↵tilghman2-0/+11
X 10.6. (closes issue #16997) Reported by: jquinn Patches: 20100309__issue16997__2.diff.txt uploaded by tilghman (license 14) Tested by: tilghman, russell git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251475 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-09Blocked revisions 251410 via svnmergeseanbright0-0/+0
........ r251410 | seanbright | 2010-03-09 14:29:39 -0500 (Tue, 09 Mar 2010) | 8 lines Use ast_strlen_zero to avoid a crash when a Dial() string isn't passed to ParkAndAnnounce (closes issue #16731) Reported by: sebele67 Patches: issue16731_20100129.diff uploaded by seanbright (license 71) Tested by: sebele67 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251411 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-08Merged revisions 251309 via svnmerge from lmadsen1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r251309 | lmadsen | 2010-03-08 12:07:44 -0600 (Mon, 08 Mar 2010) | 13 lines Fix Debian init script to not use -c. When using the init script as-is currently, it could cause issues on Debian such as high CPU usage. This fix has worked for several people so I'm implementing the change. (closes issue #16784) Reported by: pabelanger Tested by: pabelanger, mnick, davidw, mutineer612 (closes issue #16887) Reported by: jlpedrosa Tested by: jlpedrosa, mutineer612 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251310 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-08Remove portions that weren't meant to be committed for the OS X compat fixtilghman4-28003/+7007
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251263 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-08Change needed to make Mac OS X 10.6 happytilghman6-7007/+28008
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251262 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-07Clean transmit_* for start/stop media transmission mvanbaak1-42/+33
Small patch changing skinny_set_rtp_peer to use transmit_stopmediatransmission and to use new transmit_startmediatransmission. Basic testing on 30VIP's by wedhorn Basic testing on 7960 by me (closes issue #16956) Reported by: wedhorn Patches: skinny-clean05b.diff uploaded by wedhorn (license 30) Tested by: wedhorn,mvanbaak git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251222 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-07Cleanup transmit_callstate handling mvanbaak1-117/+132
Broke the various functions included in transmit_callstate to their own functions. Transmit_callstate now just transmits callstate. Generally left the functionality as it was, which highlight some minor code issues (eg multiple transmit_callstate's). I did however revise the hint code usage of the old transmit_callstate as it it not appropriate to put a device on hook based on the change of a hinted device. (closes issue #16939) Reported by: wedhorn Patches: skinny-clean04.diff uploaded by wedhorn (license 30) Tested by: mvanbaak,wedhorn git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251221 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-07small log issue from bug 0016664may1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251181 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-06Fix a crash in SIP blind transfer handling found by an automated external test.russell1-0/+9
The first real test added to the external test suite found a pretty nasty crash that occurred in Asterisk trunk. The crash was due to a race condition between the REFER handling and channel destruction in the channel thread. After the transfer has been completed, we go back to the transferrer channel and try to lock it so we can fire off a CEL event. However, there was no guarantee that the channel was still around at that point since it's racing against the channel thread. Since ast_channel is a reference counted object, the fix is simple. The code unlocks the transferrer channel before finally completing the transfer with an async goto. At this point the channel thread is going to start call tear down and the channel will eventually be destroyed. To ensure that the channel is valid when we want to fire off the CEL event, increase the channel's reference count. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251137 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05fixes xml error in func_pitchshiftdvossel1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251087 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05PITCH_SHIFT dialplan functiondvossel2-0/+505
The PITCH_SHIFT function can be used on a channel to independently modify the pitch of both rx and tx audio streams. Now you can improve your conference calls by assigning a random pitch effect to everyone entering a meetme room, or just make your day more interesting by making your co-workers sound funny. These are just some of the numerious practical uses for this function. Enjoy! https://reviewboard.asterisk.org/r/526/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251038 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Remove pbx_gtkconsole and related gtk1 checks.russell6-28341/+7028
Review: https://reviewboard.asterisk.org/r/541/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251022 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Fix app_followme playing wrong sound files.jpeeler1-7/+7
Fixes regression introduced in 140167 that uses the wrong variable names. (closes issue #16930) Reported by: ianc Patches: fix_reload_followme.diff uploaded by ianc (license 998) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250979 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Fix up some of chan_sip's usage of the RTP engine API.russell1-3/+43
The get_local_address() function for an RTP instance was used when building an SDP, but the results were not honored. The RTP engine activate() function was not being used once we have determined that media will now flow. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250917 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Missing quote in ODBC query.tilghman1-1/+1
(closes issue #16953) Reported by: elguero Patches: app_voicemail-odbc-syntax-fix.diff uploaded by elguero (license 37) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250913 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Fix up the ast_rtp_property enum.russell1-2/+7
The mis-placement of the latest entry meant that when it was set, it was writing one index past the end of the properties array in the ast_rtp_instance (which happened to be the local_address field). git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250871 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Merged revisions 250786 via svnmerge from jpeeler1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250786 | jpeeler | 2010-03-04 19:02:58 -0600 (Thu, 04 Mar 2010) | 9 lines Fix not being able to specify a URL in MOH class directory. Don't attempt to chdir on a URL! (closes issue #16875) Reported by: raarts Patches: moh-http.patch uploaded by raarts (license 937) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250787 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-04Adjust XML for func_channel to indicate that rtpdest can take a "text" argument.mmichelson1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250730 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Recorded merge of revisions 250613 via svnmerge from lmadsen0-0/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250613 | lmadsen | 2010-03-03 16:28:02 -0500 (Wed, 03 Mar 2010) | 11 lines Update existing Local channel documentation. A complete re-write of the Local channel documentation has been performed, with the existing information from localchannel.txt and localchannel.tex merged in. (issue #16637) Reported by: kobaz Patches: localchannel.tex uploaded by lmadsen (license 10) localchannel.txt uploaded by lmadsen (license 10) Tested by: lmadsen, jsmith, mmichelson ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250614 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Update existing Local channel documentation.lmadsen1-57/+461
A complete re-write of the Local channel documentation has been performed, with the existing information from localchannel.txt and localchannel.tex merged in. (closes issue #16637) Reported by: kobaz Patches: localchannel.tex uploaded by lmadsen (license 10) localchannel.txt uploaded by lmadsen (license 10) Tested by: lmadsen, jsmith, mmichelson git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250609 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Removed cdrflags from ast_channel structure.rmudgett6-17/+0
Only chan_dahdi set a value in cdrflags. Everyone else just copied it around the system. Noone cared about any value it may have contained. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250565 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Merged revisions 250480 via svnmerge from jpeeler2-1/+22
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250480 | jpeeler | 2010-03-03 13:04:11 -0600 (Wed, 03 Mar 2010) | 15 lines Make sure to clear red alarm after polarity reversal. From the issue: The automatic overnight line tests (or manual ones) used on UK (BT) lines causes a red alarm on a dahdi / TDM400P connected channel. This is because the line uses voltage tests (battery loss) and polarity reversal. The polarity reversal causes chan_dahdi to initiate v23 CallerID processing but during this the event DAHDI_EVENT_NOALARM is ignored so that the alarm is never cleared. (closes issue #14163) Reported by: jedi98 Patches: chan_dahdi-1.4-inalarm.diff uploaded by jedi98 (license 653) Tested by: mattbrown, Chainsaw, mikeeccleston ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250481 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Changes 0ms to <1ms in cli END results during 'test execute'dvossel1-2/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250478 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Merged revisions 250394 via svnmerge from dvossel1-3/+8
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r250394 | dvossel | 2010-03-03 12:02:27 -0600 (Wed, 03 Mar 2010) | 16 lines fixes problem with duplicate TXREQ packets When Asterisk receives an IAX2 TXREQ packet, try_transfer() will call store_by_transfercallno() to link the chan_iax2_pvt struct into iax_transfercallno_pvts. If a duplicate TXREQ packet is received for the same call, the pvt struct will be linked into iax_transfercallno_pvts multiple times. This patch fixes this. Thanks rain for debugging this and providing a patch! (closes issue #16904) Reported by: rain Patches: iax2-double-txreq-fix.diff uploaded by rain (license 327) Tested by: rain, dvossel ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250395 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Add new config option to control AMI alarm event reporting in chan_dahdi.jpeeler3-17/+90
New config parameter "reportalarms" added in chan_dahdi.conf which supports the following possible values: "channels": report each channel alarms (current behavior, default for backward compatibility) "spans": report an "SpanAlarm" event when the span of any configured channel is alarmed "all": report channel and span alarms (aggregated behavior) "none": do not report any alarms (closes issue #16709) Reported by: nahuelgreco Patches: chan_dahdi.c.reportalarms.patch uploaded by nahuelgreco (license 162) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250392 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03One more fix to editlinetilghman1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250346 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Eliminate remaining libedit warnings (shown in bamboo)tilghman4-0/+134
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250303 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03Updated CHANGES file to mention res_fax and res_fax_spandsp.mnicholson4-2/+16
Also fixed MODULEINFO depends and conflicts for app_fax, res_fax, and res_fax_spandsp. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250302 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-03fixes signed to unsigned int comparision issue for FaxMaxDatagram value.dvossel1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@250246 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-19 04:54:15 +0000