aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-01-21Merged revisions 169611 via svnmerge from mmichelson1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ........ r169611 | mmichelson | 2009-01-20 18:33:32 -0600 (Tue, 20 Jan 2009) | 22 lines Fix device state parsing issues for channel names with multiple slashes The fix being applied is a bit different for trunk and the 1.6.X branches. For trunk, we only wish to strip off the characters beyond the second slash if the channel is a Local channel (i.e. we are removing the /n from the device name). Other channel technologies with multiple slashes (e.g. DAHDI) need the information after the second slash in order to get the proper device state information. In addition to this fix, the 1.6.X branches are receiving a much more important fix as well. The problem in 1.6.X is that the member's device name was being directly changed instead of having a copy changed. This meant that we would strip off the second slash and trailing characters and then leave the member's device name like that permanently thereafter. (closes issue #14014) Reported by: kebl0155 Patches: 14014_number2.patch uploaded by putnopvut (license 60) Tested by: kebl0155 ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169613 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Merged revisions 169574 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r169574 | mmichelson | 2009-01-20 15:57:24 -0600 (Tue, 20 Jan 2009) | 6 lines Use the default timeout for a queue instead of -1 (closes issue #14272) Reported by: timking ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169575 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Merged revisions 169557 via svnmerge from mmichelson1-72/+85
https://origsvn.digium.com/svn/asterisk/trunk ........ r169557 | mmichelson | 2009-01-20 14:10:31 -0600 (Tue, 20 Jan 2009) | 19 lines Convert the character pointers in a sip_request to be pointer offsets When an ast_str expands to hold more data, any pointers that were pointing to the data prior to the expansion will be pointing at invalid memory. This change makes such pointers used in chan_sip.c instead be offsets from the beginning of the string so that the same math may be applied no matter where in memory the string resides. To help ease this transition, a macro called REQ_OFFSET_TO_STR has been added to chan_sip.c so that given a sip_request and an offset, the string at that offset is returned. (closes issue #14220) Reported by: riksta Tested by: putnopvut Review http://reviewboard.digium.com/r/126/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169559 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Merged revisions 169510 via svnmerge from twilson1-2/+24
https://origsvn.digium.com/svn/asterisk/trunk ........ r169510 | twilson | 2009-01-20 13:22:24 -0600 (Tue, 20 Jan 2009) | 7 lines Make a proper builtin attended transfer to parking work This is an ugly hack from 1.4 that allows the timeout callback from a parked call to use the right channel name for the callback when the park is done with a builtin attended transfer (that isn't completed early). This hasn't ever worked in trunk and no one has complained yet, so eh. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169554 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Merged revisions 169486 via svnmerge from twilson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r169486 | twilson | 2009-01-20 12:48:14 -0600 (Tue, 20 Jan 2009) | 13 lines Merged revisions 169485 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r169485 | twilson | 2009-01-20 12:40:56 -0600 (Tue, 20 Jan 2009) | 6 lines Don't play audio to the channel if we've masqueraded (closes issue #14066) Reported by: bluefox Tested by: otherwiseguy, bluefox ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169488 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-19Blocked revisions 169438 via svnmergekpfleming0-0/+0
........ r169438 | kpfleming | 2009-01-19 15:42:46 -0600 (Mon, 19 Jan 2009) | 5 lines ast_str_SQLGetData is *not* part of the ast_str API, it's part of the ast_odbc API and just happens to use an ast_str as the buffer; move all of it to res_odbc.c and res_odbc.h, renaming appropriately along the way fix some minor coding style issues in strings.h and add some attribute_pure annotations to functions in the ast_str API ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169439 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-19Merged revisions 169365 via svnmerge from tilghman2-14/+18
https://origsvn.digium.com/svn/asterisk/trunk ................ r169365 | tilghman | 2009-01-19 14:05:52 -0600 (Mon, 19 Jan 2009) | 11 lines Merged revisions 169364 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r169364 | tilghman | 2009-01-19 13:49:25 -0600 (Mon, 19 Jan 2009) | 4 lines Truncate userevents at the end of a line, when the command exceeds the buffer. (closes issue #14278) Reported by: fnordian ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169368 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-19Merged revisions 169211 via svnmerge from mmichelson1-4/+4
https://origsvn.digium.com/svn/asterisk/trunk ................ r169211 | mmichelson | 2009-01-19 09:54:06 -0600 (Mon, 19 Jan 2009) | 21 lines Merged revisions 169210 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r169210 | mmichelson | 2009-01-19 09:52:15 -0600 (Mon, 19 Jan 2009) | 13 lines Prevent a crash in chan_local due to a potential NULL pointer dereference Move the check for if both channels on a local_pvt have generators to below where p->chan is checked for NULLity (NULLness?). This prevents a crash from occurring if p->chan is NULL. (closes issue #14189) Reported by: sascha Patches: 14189.patch uploaded by putnopvut (license 60) Tested by: sascha ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169213 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-17Add discriminator for when ring pulse alert signal is used to preface MWI spillsdbailey2-16/+38
This prevents the situation when MWI messages are added to caller ID spills causing the channel to be hung up git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169154 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-17Merged revisions 169080 via svnmerge from twilson3-13/+13
https://origsvn.digium.com/svn/asterisk/trunk ........ r169080 | twilson | 2009-01-16 19:56:36 -0600 (Fri, 16 Jan 2009) | 8 lines Fix qualify for TCP peer (closes issue #14192) Reported by: pabelanger Patches: asterisk-bug14192.diff.txt uploaded by jamesgolovich (license 176) Tested by: jamesgolovich ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169082 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-17Merged revisions 169044 via svnmerge from twilson1-6/+5
https://origsvn.digium.com/svn/asterisk/trunk ........ r169044 | twilson | 2009-01-16 18:03:39 -0600 (Fri, 16 Jan 2009) | 8 lines Fix port :0 added to SIP INVITE URI when outboundproxy used (closes issue #14233) Reported by: chris-mac Patches: asterisk-bug14233.diff.txt uploaded by jamesgolovich (license 176) Tested by: jamesgolovich, chris-mac, otherwiseguy ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@169079 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Merged revisions 168941 via svnmerge from twilson1-22/+29
https://origsvn.digium.com/svn/asterisk/trunk ................ r168941 | twilson | 2009-01-16 16:16:23 -0600 (Fri, 16 Jan 2009) | 19 lines Merged revisions 168716 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168716 | twilson | 2009-01-15 12:22:49 -0600 (Thu, 15 Jan 2009) | 12 lines Convert call to park_call_full to masq_park_call_announce Since we removed the AST_PBX_KEEPALIVE return value, we need to use masqueraded parking, otherwise we will try to call ast_hangup() in __pbx_run() and in do_parking_thread() and then promptly crash. (closes issue #14215) Reported by: waverly360 Tested by: otherwiseguy (closes issue #14228) Reported by: kobaz Tested by: otherwiseguy ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168981 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Merged revisions 168976 via svnmerge from mmichelson1-1/+5
https://origsvn.digium.com/svn/asterisk/trunk ................ r168976 | mmichelson | 2009-01-16 16:43:09 -0600 (Fri, 16 Jan 2009) | 26 lines Merged revisions 168975 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168975 | mmichelson | 2009-01-16 16:42:13 -0600 (Fri, 16 Jan 2009) | 18 lines Account for possible NULL pointer when we receive a 408 in response to a REGISTER It may be that by the time we receive a reply to a REGISTER request, the attempt has timed out and thus the registry structure pointed to by the corresponding sip_pvt has gone away. This situation was handled properly for a 200 OK response, but the 408 case assumed that the sip_registry struct was non-NULL, thus potentially causing a crash This commit fixes this assumption and prints out a message to the console if we should receive a late 408 response to a REGISTER (closes issue #14211) Reported by: aborghi Patches: 14211.diff uploaded by putnopvut (license 60) Tested by: aborghi ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168979 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Blocked revisions 168898 via svnmergemmichelson0-0/+0
........ r168898 | mmichelson | 2009-01-16 13:54:39 -0600 (Fri, 16 Jan 2009) | 26 lines Fix a logic error that occur when using the timerfd interface This sequence of events posed a problem timerfd_timer_open timerfd_timer_enable_continuous timerfd_timer_set_rate timerfd_timer_disable_continuous The reason was that the timing module was written under the assumption that timerfd_timer_set_rate would not be called between enabling and disabling continuous mode. What happened in this situation was that timerfd_timer_enable_continuous saved off our previously set timer (in this situation a 0 timer, meaning it never runs out). Then timerfd_timer_disable_continuous would restore this 0 timer, even though it logically should set the timer to be whatever was set in timerfd_timer_set_rate. Now the behavior in timerfd_timer_set_rate is to overwrite the saved timer that may or may not have been set in timerfd_timer_enable_continuous. Even if timerfd_timer_enable_continuous has not been previously called, this will not harm the operation. Thanks to Terry Wilson for discovering the problem and giving me a really great debug capture that pointed out the problem clearly ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168899 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Merged revisions 168832 via svnmerge from tilghman3-146/+211
https://origsvn.digium.com/svn/asterisk/trunk ................ r168832 | tilghman | 2009-01-16 12:49:09 -0600 (Fri, 16 Jan 2009) | 13 lines Merged revisions 168828 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168828 | tilghman | 2009-01-16 12:41:35 -0600 (Fri, 16 Jan 2009) | 6 lines Fix the conjugation of Russian and Ukrainian languages. (related to issue #12475) Reported by: chappell Patches: vm_multilang.patch uploaded by chappell (license 8) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168836 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Merged revisions 168746 via svnmerge from murf1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r168746 | murf | 2009-01-15 17:34:31 -0700 (Thu, 15 Jan 2009) | 20 lines Merged revisions 168745 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168745 | murf | 2009-01-15 17:19:12 -0700 (Thu, 15 Jan 2009) | 14 lines This patch fixes a problem where a goto (or jump, in this case) fails a consistency check because it can't find a matching extension. The problem was a missing instruction to end the range notation in the code where it converts the pattern into a regex and uses the regex code to determine the match. I tested using the AEL code the user supplied, and now, the consistency check passes. (closes issue #14141) Reported by: dimas ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168748 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168737 via svnmerge from murf3-130/+147
https://origsvn.digium.com/svn/asterisk/trunk ........ r168737 | murf | 2009-01-15 13:54:59 -0700 (Thu, 15 Jan 2009) | 16 lines This patch allows null args in ast_expr2 func calls, and fixes commas being converted to pipes, which was 1.4 type stuff. If the user says count=ENUMLOOKUP(${EXTEN},ALL,c,,enum.mydomain.tld); then it won't complain about the empty arg (c,,...) and fabled's patch won't let it swap the commas for pipes. Ran it thru my dialplan and no complaints. (closes issue #14169) Reported by: fabled Patches: function-argument-separator-fix.diff uploaded by fabled (license 448) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168739 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Blocked revisions 168734 via svnmergekpfleming0-0/+0
........ r168734 | kpfleming | 2009-01-15 14:18:53 -0600 (Thu, 15 Jan 2009) | 5 lines remove the PBX_ODBC logic from the configure script, and add GENERIC_ODCB logic that includes copying the relevant LIB and INCLUDE data from either UnixODBC or iODBC, based on which was found; if both were found, prefer UnixODBC this stops modules from being linked against both sets of libraries on systems that have both installed ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168735 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Blocked revisions 168732 via svnmergemmichelson0-0/+0
........ r168732 | mmichelson | 2009-01-15 14:00:46 -0600 (Thu, 15 Jan 2009) | 3 lines Add missing brace ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168733 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168728 via svnmerge from mmichelson1-2/+3
https://origsvn.digium.com/svn/asterisk/trunk ........ r168728 | mmichelson | 2009-01-15 13:16:29 -0600 (Thu, 15 Jan 2009) | 3 lines Fix the compactheaders option in sip.conf ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168729 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168722 via svnmerge from oej1-0/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r168722 | oej | 2009-01-15 19:47:14 +0100 (Tor, 15 Jan 2009) | 10 lines Merged revisions 168721 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168721 | oej | 2009-01-15 19:43:43 +0100 (Tor, 15 Jan 2009) | 2 lines Meetme actually has realtime but wasn't documented ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168727 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168725 via svnmerge from mmichelson1-4/+0
https://origsvn.digium.com/svn/asterisk/trunk ........ r168725 | mmichelson | 2009-01-15 13:00:06 -0600 (Thu, 15 Jan 2009) | 17 lines Remove an unneeded condition for line addition to a SIP request/response In Asterisk 1.4 and 1.6.0, the sip_request structure had a statically allocated buffer to hold the text of the request. There was a check in the add_line function to not attempt to write the line into the buffer if we did not have room for it. In trunk and Asterisk versions starting with 1.6.1, an expandable ast_str structure is used to hold the text. Since it may grow to fit an arbitrarily sized string, this check in add_line is no longer valid. I found this oddity while attempting to fix issue #14220; however, I do not believe that this is the fix for that issue since the output supplied by the reporter did not contain the warning message that would be printed had this condition been satisfied. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168726 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Blocked revisions 168719 via svnmergetilghman0-0/+0
........ r168719 | tilghman | 2009-01-15 12:39:56 -0600 (Thu, 15 Jan 2009) | 4 lines Resolve issue with negative vs non-negative length parameters. (closes issue #14245) Reported by: dveiga ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168720 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168711 via svnmerge from oej1-4/+8
https://origsvn.digium.com/svn/asterisk/trunk ........ r168711 | oej | 2009-01-15 18:55:53 +0100 (Tor, 15 Jan 2009) | 4 lines Clarify some misunderstandings and make it even more clear that you can refer to a peer in the register= line. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168715 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168712 via svnmerge from oej1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r168712 | oej | 2009-01-15 19:08:59 +0100 (Tor, 15 Jan 2009) | 3 lines Make sure that we have the same terminology in sip.conf.sample and the source code warning. Thanks Nick Lewis for pointing this out in the bug tracker. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168714 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168705 via svnmerge from seanbright1-1/+3
https://origsvn.digium.com/svn/asterisk/trunk ........ r168705 | seanbright | 2009-01-15 10:33:18 -0500 (Thu, 15 Jan 2009) | 11 lines Add a missing unlock and properly handle the 'maxusers' setting on MeetMe conferences. We were using the 'user number' field to compare against the maximum allowed users, which works assuming users with lower user numbers didn't leave the conference. (closes issue #14117) Reported by: sergedevorop Patches: 20090114__bug14117-2.diff.txt uploaded by seanbright (license 71) Tested by: sergedevorop ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168707 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Merged revisions 168629 via svnmerge from mmichelson1-5/+10
https://origsvn.digium.com/svn/asterisk/trunk ................ r168629 | mmichelson | 2009-01-14 18:14:17 -0600 (Wed, 14 Jan 2009) | 24 lines Merged revisions 168628 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168628 | mmichelson | 2009-01-14 18:11:01 -0600 (Wed, 14 Jan 2009) | 16 lines Fix some crashes from bad datastore handling in app_queue.c * The queue_transfer_fixup function was searching for and removing the datastore from the incorrect channel, so this was fixed. * Most datastore operations regarding the queue_transfer datastore were being done without the channel locked, so proper channel locking was added, too. (closes issue #14086) Reported by: ZX81 Patches: 14086v2.patch uploaded by putnopvut (license 60) Tested by: ZX81, festr ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168631 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Blocked revisions 168626 via svnmergeseanbright0-0/+0
........ r168626 | seanbright | 2009-01-14 18:10:48 -0500 (Wed, 14 Jan 2009) | 7 lines Don't crash when typing 'core set verbose' or 'core set debug' by themselves. (closes issue #14219) Reported by: jamesgolovich Patches: asterisk-setverbosecrash.diff.txt uploaded by jamesgolovich (license 176) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168627 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Merged revisions 168623 via svnmerge from rmudgett1-44/+40
https://origsvn.digium.com/svn/asterisk/trunk ................ r168623 | rmudgett | 2009-01-14 15:51:06 -0600 (Wed, 14 Jan 2009) | 11 lines Merged revisions 168622 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168622 | rmudgett | 2009-01-14 15:48:22 -0600 (Wed, 14 Jan 2009) | 4 lines * Fixed create_process() allocation of process ID values. The allocated process IDs could overflow their respective NT and TE fields. Affects outgoing calls. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168625 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Merged revisions 168613 via svnmerge from murf1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r168613 | murf | 2009-01-14 13:51:26 -0700 (Wed, 14 Jan 2009) | 9 lines Merged revisions 168608 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168608 | murf | 2009-01-14 12:34:35 -0700 (Wed, 14 Jan 2009) | 1 line app_page was failing to compile in dev-mode on my gcc-4.2.4 system. This change gets rid of the warning. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168621 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Merged revisions 168615 via svnmerge from seanbright1-8/+5
https://origsvn.digium.com/svn/asterisk/trunk ................ r168615 | seanbright | 2009-01-14 15:58:26 -0500 (Wed, 14 Jan 2009) | 16 lines Merged revisions 168614 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168614 | seanbright | 2009-01-14 15:52:00 -0500 (Wed, 14 Jan 2009) | 9 lines Update autosupport script to supply info for both Zaptel and DAHDI in 1.4 and be sure to run dahdi_test in 1.6.x and trunk instead of zttest. (closes issue #14132) Reported by: dsedivec Patches: asterisk-1.4-autosupport.patch uploaded by dsedivec (license 638) asterisk-trunk-autosupport.patch uploaded by dsedivec (license 638) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168618 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Merged revisions 168610 via svnmerge from mmichelson1-0/+190
https://origsvn.digium.com/svn/asterisk/trunk ........ r168610 | mmichelson | 2009-01-14 14:13:48 -0600 (Wed, 14 Jan 2009) | 9 lines Restore the "sip show users" and "sip show user" CLI commands (closes issue #14180) Reported by: amorsen Patches: sip_show_users_161v3.diff uploaded by putnopvut (license 60) Tested by: blitzrage, amorsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168611 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Merged revisions 168604 via svnmerge from tilghman1-5/+3
https://origsvn.digium.com/svn/asterisk/trunk ................ r168604 | tilghman | 2009-01-14 13:11:14 -0600 (Wed, 14 Jan 2009) | 14 lines Merged revisions 168603 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168603 | tilghman | 2009-01-14 13:02:55 -0600 (Wed, 14 Jan 2009) | 7 lines Don't read into a buffer without first checking if a value is beyond the end. (closes issue #13600) Reported by: atis Patches: 20090106__bug13600.diff.txt uploaded by Corydon76 (license 14) Tested by: atis ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168606 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Blocked revisions 168601 via svnmergetilghman0-0/+0
........ r168601 | tilghman | 2009-01-14 12:27:57 -0600 (Wed, 14 Jan 2009) | 2 lines Mostly spacing changes; no functionality change at all. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168602 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Blocked revisions 168599 via svnmergemmichelson0-0/+0
................ r168599 | mmichelson | 2009-01-14 10:20:37 -0600 (Wed, 14 Jan 2009) | 15 lines Blocked revisions 168598 via svnmerge ........ r168598 | mmichelson | 2009-01-14 10:19:26 -0600 (Wed, 14 Jan 2009) | 8 lines Fix a logic error I found while searching through chan_agent.c I found that the allow_multiple_logins function would never return 0 due to an incorrect comparison being used when traversing the list of agents. While I was modifying this function, I also did a little bit of coding guidelines cleanup, too. ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168600 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Merged revisions 168594 via svnmerge from twilson1-5/+17
https://origsvn.digium.com/svn/asterisk/trunk ................ r168594 | twilson | 2009-01-13 20:00:40 -0600 (Tue, 13 Jan 2009) | 27 lines Merged revisions 168593 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168593 | twilson | 2009-01-13 19:27:18 -0600 (Tue, 13 Jan 2009) | 20 lines Don't overflow when paging more than 128 extensions The number of available slots for calls in app_page was hardcoded to 128. Proper bounds checking was not in place to enforce this limit, so if more than 128 extensions were passed to the Page() app, Asterisk would crash. This patch instead dynamically allocates memory for the ast_dial structures and removes the (non-functional) arbitrary limit. This issue would have special importance to anyone who is dynamically creating the argument passed to the Page application and allowing more than 128 extensions to be added by an outside user via some external interface. The patch posted by a_villacis was slightly modified for some coding guidelines and other cleanups. Thanks, a_villacis! (closes issue #14217) Reported by: a_villacis Patches: 20080912-asterisk-app_page-fix-buffer-overflow.patch uploaded by a (license 660) Tested by: otherwiseguy ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168596 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Blocked revisions 168591 via svnmergetilghman0-0/+0
........ r168591 | tilghman | 2009-01-13 17:57:46 -0600 (Tue, 13 Jan 2009) | 6 lines Janitor patch for chan_misdn (make channel variable access safe) (closes issue #12887) Reported by: pputman Patches: chan_misdn_threadsafe.patch uploaded by pputman (license 81) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168592 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Merged revisions 168588 via svnmerge from twilson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r168588 | twilson | 2009-01-13 17:05:43 -0600 (Tue, 13 Jan 2009) | 5 lines Fully overwrite a same-named file when uploading (closes issue #14190) Reported by: timking ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168590 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Blocked revisions 168585 via svnmergetwilson0-0/+0
........ r168585 | twilson | 2009-01-13 17:00:27 -0600 (Tue, 13 Jan 2009) | 8 lines Add option to hide console connect messages (closes issue #14222) Reported by: jamesgolovich Patches: asterisk-hideconnect.diff.txt uploaded by jamesgolovich (license 176) Tested by: otherwiseguy ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168587 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Merged revisions 168578 via svnmerge from twilson1-1/+3
https://origsvn.digium.com/svn/asterisk/trunk ................ r168578 | twilson | 2009-01-13 16:22:34 -0600 (Tue, 13 Jan 2009) | 14 lines Merged revisions 168551 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168551 | twilson | 2009-01-13 12:34:14 -0600 (Tue, 13 Jan 2009) | 7 lines Don't pass a value with a side effect to a macro (closes issue #14176) Reported by: paraeco Patches: chan_sip.c.diff uploaded by paraeco (license 658) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168582 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Blocked revisions 168579 via svnmergemmichelson0-0/+0
........ r168579 | mmichelson | 2009-01-13 16:30:59 -0600 (Tue, 13 Jan 2009) | 13 lines Clarify a message that app_queue prints and change to a debug-level message The "No one is answering..." verbose message contained 3 numbers that were not explained in any way to whoever was viewing the message. It is more helpful now since the message explains what the numbers mean. Also, the message has been downgraded to "DEBUG" level. (closes issue #14172) Reported by: caio1982 Patches: queue_answering_debug.diff uploaded by caio1982 (license 22) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168581 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Blocked revisions 168575 via svnmergemmichelson0-0/+0
........ r168575 | mmichelson | 2009-01-13 15:18:13 -0600 (Tue, 13 Jan 2009) | 13 lines Allow specifying a port number in the user portion of a register => line in sip.conf With this commit, a register => line in sip.conf may contain a port number in the "user" section of the line. Please see CHANGES and sip.conf.sample for more details regarding this. (closes issue #14198) Reported by: Nick_Lewis Patches: chan_sip.c-domainport2.patch uploaded by Nick (license 657) Tested by: Nick_Lewis ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168576 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Merged revisions 168562 via svnmerge from russell15-56/+56
https://origsvn.digium.com/svn/asterisk/trunk ................ r168562 | russell | 2009-01-13 13:22:13 -0600 (Tue, 13 Jan 2009) | 10 lines Merged revisions 168561 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168561 | russell | 2009-01-13 13:13:05 -0600 (Tue, 13 Jan 2009) | 2 lines Revert unnecessary indications API change from rev 122314 ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168565 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Merged revisions 168547 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ................ r168547 | tilghman | 2009-01-13 11:51:12 -0600 (Tue, 13 Jan 2009) | 13 lines Merged revisions 168546 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168546 | tilghman | 2009-01-13 11:48:00 -0600 (Tue, 13 Jan 2009) | 6 lines If either conditional is NULL, don't try copying it. (closes issue #14226) Reported by: caspy Patches: 20090113__bug14226.diff.txt uploaded by Corydon76 (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168549 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12Merged revisions 168526 via svnmerge from tilghman1-2/+6
https://origsvn.digium.com/svn/asterisk/trunk ................ r168526 | tilghman | 2009-01-12 17:45:51 -0600 (Mon, 12 Jan 2009) | 12 lines Merged revisions 167095 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r167095 | tilghman | 2008-12-31 18:01:22 -0600 (Wed, 31 Dec 2008) | 5 lines Repeat attempts to write when we receive -EAGAIN from the driver, as detailed in the ALSA sample code (see http://www.alsa-project.org/alsa-doc/alsa-lib/_2test_2pcm_8c-example.html#a32) Reported by: Jerry Geis (via the -users list) Fixed by: me (license 14) ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168528 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12Merged revisions 168523 via svnmerge from mmichelson1-1/+1
https://origsvn.digium.com/svn/asterisk/trunk ........ r168523 | mmichelson | 2009-01-12 17:12:30 -0600 (Mon, 12 Jan 2009) | 11 lines bump the verbosity of a message in srv.c up by one. It used to be at this level prior to a large patch merge which converted ast_verbose calls to ast_verb (closes issue #14221) Reported by: jcovert Patches: srv.c.patch uploaded by jcovert (license 551) ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168524 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12Merged revisions 168517 via svnmerge from jpeeler1-0/+5
https://origsvn.digium.com/svn/asterisk/trunk ................ r168517 | jpeeler | 2009-01-12 15:51:46 -0600 (Mon, 12 Jan 2009) | 12 lines Merged revisions 168516 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168516 | jpeeler | 2009-01-12 15:42:34 -0600 (Mon, 12 Jan 2009) | 5 lines (closes issue #13881) Reported by: hoowa Update the app CDR field for AGI commands that are not executing an application via "exec". ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168519 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12Merged revisions 168508 via svnmerge from jpeeler1-19/+28
https://origsvn.digium.com/svn/asterisk/trunk ................ r168508 | jpeeler | 2009-01-12 14:53:04 -0600 (Mon, 12 Jan 2009) | 15 lines Merged revisions 168507 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168507 | jpeeler | 2009-01-12 14:26:22 -0600 (Mon, 12 Jan 2009) | 9 lines (closes issue #12269) Reported by: IgorG Tested by: denisgalvao This gits rid of the notion of an owning_app allowing the request and hangup to be initiated by different threads. Originating from an active agent channel requires this. The implementation primarily changes __login_exec to wait on a condition variable rather than a lock. Review: http://reviewboard.digium.com/r/35/ ........ ................ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168510 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12Merged revisions 168497 via svnmerge from oej1-2/+2
https://origsvn.digium.com/svn/asterisk/trunk ........ r168497 | oej | 2009-01-12 17:31:27 +0100 (MÃ¥n, 12 Jan 2009) | 2 lines Better to use the proper app name ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168500 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12Merged revisions 168486 via svnmerge from mmichelson1-5/+0
https://origsvn.digium.com/svn/asterisk/trunk ........ ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.1@168488 f38db490-d61c-443f-a65b-d21fe96a405b