aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-12-17This patch is here committed to satisfy themurf1-1/+1
buildbot, who has a problem with the const. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165254 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17Polycom phones close the connection after reading a little bit of the ↵twilson1-1/+6
firmware files, we should stop sending in that case. Also, make that case print out a debug statement instead of a scary WARNING. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165219 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17Call proxy_update so that the IP address gets populated. Sending stuff to ↵file1-0/+2
0.0.0.0 is silly! (closes issue #14055) Reported by: chris-mac git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165216 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17This patch adds a new 'ignoresdpversion' option to sip.conf. When this ismnicholson3-6/+34
enabled (either globally or for a specific peer), chan_sip will treat any SDP data it receives as new data and update the media stream accordingly. By default, Asterisk will only modify the media stream if the SDP session version received is different from the current SDP session version. This option is required to interoperate with devices that have non-standard SDP session version implementations (observed by toc on the bug tracker with Microsoft OCS which always uses 0 as the session version). http://reviewboard.digium.com/r/94/ (closes issue #13958) Reported by: toc Tested by: toc git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165180 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17argsep is used as an attribute for an argument, as wellrussell1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165145 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17And actually assign the function to a pointer...mmichelson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165143 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17Use the create_vm_state_from_user function in a place wheremmichelson1-18/+7
it was not being used before. Also, I've moved the urgent folder check in messagecount() up a bit so that the flow is a bit better. This was something I noticed while taking a look at issue #13973, although I don't think this is the underlying cause of the issue. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165142 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17ignore this copied filekpfleming0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165108 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17A possibly "horrible fix" for a "horribly broken"murf6-49/+234
situation. As stuff shifts around in the asterisk code, the miscellaneous inclusions from the standalone stuff gets broken. There's no easy fix for this situation. I made sure that everything in utils builds without problem ***AND*** that aelparse runs the regressions correctly with the following make menuselect options both on and off: DONT_OPTIMIZE DEBUG_THREADS DEBUG_CHANNEL_LOCKS MALLOC_DEBUG MTX_PROFILE DEBUG_SCHEDULER DEBUG_THREADLOCALS DETECT_DEADLOCKS CHANNEL_TRACE I think from now on, I'm going to #undef all these features in the various utils native files; I guess I could do the same for the copied-in files, surrounded by STANDALONE ifdef. A standalone isn't going to care about threads, mutexes, etc. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165071 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-17fixed the regressionsmurf2-77/+77
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@165039 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164977 via svnmerge from mmichelson1-1/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164977 | mmichelson | 2008-12-16 17:04:27 -0600 (Tue, 16 Dec 2008) | 7 lines After looking through SIP registration code most of the day, this is one of the few things I could find that was just plain wrong. Even though it probably isn't possible for it to happen, it seems weird to have code that checks if a pointer is NULL and then immediately dereferences that pointer if it was NULL. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164978 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Add timezone to the possible fields in a timespec.tilghman7-128/+189
(closes issue #14028) Reported by: mostyn Patches: timezone-v2.patch uploaded by mostyn (license 398) (with additional code guideline fixes and a memory leak fix by me - license 14) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164976 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16(closes issue #13669)jpeeler1-0/+1
Reported by: pj Delete file recording if recording terminated from a hangup. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164942 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Make a note of the feature request in bug #11157 as per the reporter and ↵twilson1-0/+2
oej, and suspend the bug since no one seems to be keen on implementing it any time soon. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164941 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164881 via svnmerge from russell1-0/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164881 | russell | 2008-12-16 15:38:29 -0600 (Tue, 16 Dec 2008) | 9 lines Fix an issue where DEBUG_THREADS may erroneously report that a thread is exiting while holding a lock. If the last lock attempt was a trylock, and it failed, it will still be in the list of locks so that it can be reported. (closes issue #13219) Reported by: pj ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164882 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164876 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164876 | russell | 2008-12-16 15:10:44 -0600 (Tue, 16 Dec 2008) | 6 lines Do not dereference the channel if AST_PBX_KEEPALIVE has been returned. This is a bug I noticed while looking at the code for app_macro. This return code means that another thread has assumed ownership of the channel and it can no longer be touched. (I hate this return code with a passion, by the way.) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164877 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Fix build issues on Linux after sysinfo related changesrussell1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164821 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Qualify trumps poke per lmadsen.file3-20/+20
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164814 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Add configuration options for finer control over how Asterisk handles having ↵file3-6/+33
to poke all peers at seemingly the same time. (closes issue #13217) Reported by: cervajs git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164809 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164806 via svnmerge from russell1-0/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164806 | russell | 2008-12-16 14:35:25 -0600 (Tue, 16 Dec 2008) | 9 lines Add "restart gracefully" to the AMI blacklist of CLI commands. "module unload" was already identified as a command that can not be used from the AMI. "restart gracefully" effectively unloads all modules, and will run in to the same problems. (closes issue #13894) Reported by: kernelsensei ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164807 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16introduce 'core show sysinfo' for systems that dont have the Linux-ish ↵mvanbaak4-15/+126
sysinfo stuff but do have sysctl. (closes issue #13433) Reported by: mvanbaak Patches: 2008121300_sysinfosysctl.diff.txt uploaded by mvanbaak (license 7) with two free calls replaced with ast_free based on feedback on reviewboard Review: http://reviewboard.digium.com/r/91/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164802 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16(closes issue #14076)murf1-6/+2
Reported by: toc Tested by: murf OK, Well this issue has had its share of flip-flopping. I found the following: 1. the code in question, in ext_cmp1 in pbx.c, would not allow two extensions that vary only by any dashes contained within them, to be defined in the same context. 2. for input dialstrings, dashes are NOT ignored. So, skipping them when sorting patterns seemed a bit silly. Thus, you might declare ext 891 in a context, but if you try dialing 8-9-1, it will NOT match 891. So, I proposed to remove the code from ext_cmp1 to skip the spaces and dashes. Just kept us from declaring 891 and 8-9-1 in the same context, forcing users to generate otherwise uselessly obfuscated dialplan code to get the same effect. Then, I tried out 1.4, and found that: 1. you can declare 891 and 8-9-1 in the same context! 2. You can't define 891, and have 8-9-1 match it! Nor can you define 8-9-1, and have 891 match it! So, it appears that my proposal simply restores the pbx to behaving as it did in 1.4. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164801 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Set up umask as a possible configuration option.tilghman1-0/+8
(closes issue #13753) Reported by: irroot git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164798 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164736 via svnmerge from russell2-12/+28
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164736 | russell | 2008-12-16 11:06:29 -0600 (Tue, 16 Dec 2008) | 14 lines Fix memory leak and invalid reporting issues with DEBUG_THREADLOCALS. One issue was that the ast_mutex_* API was being used within the context of the thread local data destructors. We would go off and allocate more thread local data while the pthread lib was in the middle of destroying it all. This led to a memory leak. Another issue was an invalid argument being provided to the the object_add API call. (closes issue #13678) Reported by: ys Tested by: Russell ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164737 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Be more detailed about why the include did not get included.file1-1/+25
(closes issue #14071) Reported by: kshumard Patches: pbx_config.patch.improvederroroutput.txt uploaded by kshumard (license 92) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164733 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164672 via svnmerge from russell1-2/+5
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164672 | russell | 2008-12-16 09:56:37 -0600 (Tue, 16 Dec 2008) | 11 lines Fix a memory leak related to the use of the "setvar" configuration option. The problem was that these variables were being appended to the list of vars on the sip_pvt every time a re-registration or re-subscription came in. Since it's just a waste of memory to put them there unless the request was an INVITE, then the fix is to check the request type before copying the vars. (closes issue #14037) Reported by: marvinek Tested by: russell ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164675 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16When using externhost make sure the port gets set to the bindaddr port if ↵file1-0/+3
one was not specified in the externhost value itself. (closes issue #13634) Reported by: performer git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164659 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164634 via svnmerge from murf1-1/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164634 | murf | 2008-12-16 08:15:58 -0700 (Tue, 16 Dec 2008) | 5 lines I added a sentence to clarify why - and ' ' are ignored in patterns as per bug 14076. Leif says he'll put some stuff about it in the extensions.conf sample, etc. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164648 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Set MINIVM_ACCMESS_STATUS in all cases. Also, remove a variable that was ↵russell1-4/+6
not needed. (closes issue #14081) Reported by: pkempgen git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164623 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Merged revisions 164605 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164605 | russell | 2008-12-16 08:28:10 -0600 (Tue, 16 Dec 2008) | 5 lines Don't try to change working directory if a directory was not configured. (closes issue #14089) Reported by: caspy ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164606 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Fix usage of the DAHDI_VMWI ioctl.russell1-1/+1
(closes issue #14090) Reported by: alecdavis Patches: chan_dahdi.VMWI_ioctl.diff.txt uploaded by alecdavis (license 585) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164602 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16Use tables instead of ASCII art. Also change a bit of minor formatting.seanbright1-23/+25
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164565 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Open a timer before loading configuration so that the trunking configuration ↵russell1-3/+4
option will take effect. (closes issue #14082) Reported by: seandarcy git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164525 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Fix log message to refer to the generic timing interface, not DAHDI specificallyrussell1-1/+1
(inspired by issue #14082) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164522 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Make sure we handle a uint32_t payload in ast_frdup()russell1-0/+2
(closes issue #14080) Reported by: fnordian Patches: frame.patch uploaded by fnordian (license 110) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164519 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Allow disabling pattern match searches within the Realtime dialplan switch.tilghman3-3/+33
(closes issue #13698) Reported by: fhackenberger Patches: 20081211__bug13698.diff.txt uploaded by Corydon76 (license 14) Tested by: fhackenberger git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164485 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Add an 'i' option to app_page. This option works the same asmmichelson1-0/+9
the 'i' options for app_dial and app_queue, in that they will ignore any attempts by phones to forward the call. (closes issue #13977) Reported by: putnopvut Patches: page_ignore_forwards.patch uploaded by putnopvut (license 60) Tested by: putnopvut, acunningham git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164428 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Merged revisions 164422 via svnmerge from mmichelson1-0/+4
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164422 | mmichelson | 2008-12-15 13:53:08 -0600 (Mon, 15 Dec 2008) | 3 lines Add the deadlock note to ast_spawn_extension as well ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164423 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Merged revisions 164416 via svnmerge from mmichelson2-0/+25
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164416 | mmichelson | 2008-12-15 13:45:07 -0600 (Mon, 15 Dec 2008) | 4 lines Add notes to autoservice and pbx doxygen regarding a potential deadlock scenario so that it is avoided in the future ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164419 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Revert ast_str opacity in chan_sip for now, since something wasn't quite righttilghman2-189/+160
in the merge. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164417 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15I was getting this warning during a compilemurf1-2/+2
on a 64-bit machine running ubuntu server 8.10, and gcc-4.3.2: [CXXi] chan_vpb.ii -> chan_vpb.oo cc1plus: warnings being treated as errors In file included from /home/murf/asterisk/trunk/include/asterisk/utils.h:671, from chan_vpb.cc:46: /home/murf/asterisk/trunk/include/asterisk/strings.h: In function ‘char* ast_str_truncate(ast_str*, ssize_t)’: /home/murf/asterisk/trunk/include/asterisk/strings.h:479: error: comparison between signed and unsigned integer expressions make[1]: *** [chan_vpb.oo] Error 1 make: *** [channels] Error 2 which this fix silences git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164415 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Merged revisions 164350 via svnmerge from file1-1/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164350 | file | 2008-12-15 14:11:21 -0400 (Mon, 15 Dec 2008) | 6 lines Do not try to unlock a non-existant channel if the transfer fails. (closes issue #13800) Reported by: dwagner Patches: asterisk-1.4.22-chan-sip-nullp.patch uploaded by tweety (license 608) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164351 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15When querying for the structure of the CDR table, remove the schema, if ittilghman1-1/+9
exists. (Closes issue #14058) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164349 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Blocked revisions 164343 via svnmergefile0-0/+0
........ r164343 | file | 2008-12-15 13:43:59 -0400 (Mon, 15 Dec 2008) | 4 lines Use autoconf logic to determine whether the system has timersub or not. Do not blindly assume Solaris does not. (closes issue #13838) Reported by: ano ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164344 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Use ast_seekstream to return the file stream back to the beginning instead ↵file1-1/+1
of directly seeking to zero. This is because some audio formats have headers at the front that need to be skipped, which will be done by the format module. (closes issue #14079) Reported by: elguero git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164312 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Fix a couple more build issues related to ast_str_opaquerussell2-2/+5
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164309 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15When a reload is issued, always process the configuration for dundi.conf.russell1-3/+2
The reason is that a reload can be used to refresh DNS lookups for defined peers. Even if the config file hasn't changed, we want to process it for that purpose. (closes issue #13776) Reported by: kombjuder git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164272 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Fix a compile warning and a logic error that could have been badmmichelson1-2/+2
for non-realtime queues git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164270 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Fix up a few issues with regards to queuesmmichelson1-12/+23
* Fix reference counting used in the __queues_show function * Add code to be sure that the "queue show" command does not print information for a realtime queue which has been deleted from the backend * Add a missing unref to the realtime queue loading function for the case where a queue is in the module's container but has been deleted from the realtime backend (closes issue #14033) Reported by: cristiandimache Patches: 14033.patch uploaded by putnopvut (license 60) Tested by: cristiandimache git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164268 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Make app_fax compatible with newer versions of spandsp. This remains ↵file4-0/+66
backwards compatible with earlier versions though so do not fret. (closes issue #14073) Reported by: seandarcy git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164257 f38db490-d61c-443f-a65b-d21fe96a405b