aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-12-15Update to work with new ast_str changes.file1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164208 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Blocked revisions 164204 via svnmergefile0-0/+0
........ r164204 | file | 2008-12-15 11:05:08 -0400 (Mon, 15 Dec 2008) | 4 lines Can we try not to assign an unsigned int to -1? (closes issue #14074) Reported by: wetwired ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164205 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Merged revisions 164201 via svnmerge from russell2-51/+129
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164201 | russell | 2008-12-15 08:31:37 -0600 (Mon, 15 Dec 2008) | 31 lines Handle a case where a call can be bridged to a channel that is still ringing. The issue that was reported was about a case where a RINGING channel got redirected to an extension to pick up a call from parking. Once the parked call got taken out of parking, it heard silence until the other side answered. Ideally, the caller that was parked would get a ringing indication. This patch fixes this case so that the caller receives ringback once it comes out of parking until the other side answers. The fixes are: - Make sure we remember that a channel was an outgoing channel when doing a masquerade. This prevents an erroneous ast_answer() call on the channel, which causes a bogus 200 OK to be sent in the case of SIP. - Add some additional comments to explain related parts of code. - Update the handling of the ast_channel visible_indication field. Storing values that are not stateful is pointless. Control frames that are events or commands should be ignored. - When a bridge first starts, check to see if the peer channel needs to be given ringing indication because the calling side is still ringing. - Rework ast_indicate_data() a bit for the sake of readability. (closes issue #13747) Reported by: davidw Tested by: russell Review: http://reviewboard.digium.com/r/90/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164203 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15Fix build WRT ast_str_opaquerussell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164202 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-14Don't pass a negative to an unsigned type and expect things to work correctly.tilghman1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164168 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-14Use a \picture instead of ASCII art.seanbright1-12/+28
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164137 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13Blocked revisions 164082 via svnmergetilghman0-0/+0
........ r164082 | tilghman | 2008-12-13 17:22:02 -0600 (Sat, 13 Dec 2008) | 9 lines Change the default calldurationlimit from the special value 0 to -1, so we can better detect an exceptional case. This follows on to the changes made in revision 156386. Related to issue #13851. (closes issue #13974) Reported by: paradise Patches: 20081208__bug13974.diff.txt uploaded by Corydon76 (license 14) Tested by: file, blitzrage, ZX81 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164083 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13Use ast_str_strlen() instead of recalculating the string length.seanbright1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164054 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13nuke another use of the ast_str internals.mvanbaak1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164028 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13Merge ast_str_opaque branch (discontinue usage of ast_str internals)tilghman53-907/+1254
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163991 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13This shouldn't have gotten commited. We might want to generate this into a ↵seanbright1-1/+1
separate file instead of the version controlled one. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163952 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13Use actual tables instead of ASCII art ones.seanbright2-37/+46
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163951 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13Only detach and destroy the whisper audiohooks if they are actually in use.file1-8/+13
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163912 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12When using realtime queues, app_queue wasn't updating the strategy if it was ↵twilson1-2/+20
changed in the realtime backend. This patch resolves the issue for almost all situations. It is currently not supported to switch to the linear strategy via realtime since the ao2_container for members will have been set to have multiple buckets and therefore the members would be unordered. (closes issue #14034) Reported by: cristiandimache Tested by: otherwiseguy, cristiandimache git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163873 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Add a note to indicate why this only supports one channel for now.russell1-0/+5
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163828 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Blocked revisions 163785 via svnmergerussell0-0/+0
........ r163785 | russell | 2008-12-12 16:20:26 -0600 (Fri, 12 Dec 2008) | 2 lines Set the reviewboard:url property on 1.4, as well ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163797 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Merged revisions 163761 via svnmerge from tilghman2-0/+5
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163761 | tilghman | 2008-12-12 16:03:10 -0600 (Fri, 12 Dec 2008) | 7 lines Simple fix for Ctrl-C not immediately exiting Asterisk, but also add a pointer inside editline to look back to asterisk.c, so others don't spend as much time as I did looking (in the wrong place) for the appropriate function. Reported by: ZX81, via the #asterisk-users channel Fixed by: me (license 14) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163762 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Add a new CLI command, "channel redirect", which is similar in operationrussell2-3/+47
to AMI Redirect. Review: http://reviewboard.digium.com/r/89/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163716 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12demote always-appearing debug message (for certain boards) to ast_debug lev ↵murf1-1/+2
3 msg instead git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163675 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Rename a number of tcptls_session variables. There are no functional ↵russell2-134/+134
changes here. The name "ser" was used in a lot of places. However, it is a relic from when the struct was a server_instance, not a session_instance. It was renamed since it represents both a server or client connection. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163670 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Fix a small race condition in sip_tcp_locate().russell1-5/+10
We must increase the reference count on the tcptls_session _before_ unlocking the thread list. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163667 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Resolve crashes when using SIP TCP/TLS with qualify.russell1-1/+1
The problem was a reference count error on the tcptls_session structure. (closes issue #13989) Reported by: Nugget git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163642 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12When a device registers we need to unlink them (if linked) from the ↵file1-0/+8
peers_by_ip container and link them back in since their IP address has changed. This would have manifested itself if you configured a new device (as type=peer), registered, and then tried to place a call from the device. Since the peer was not linked into the peers_by_ip container it would have never been found. (closes issue #13811) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163629 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Document default Monitor file location.mvanbaak1-0/+1
(closes issue #14065) Reported by: kshumard Patches: res_monitor.documentation.patch.txt uploaded by kshumard (license 92) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163612 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Fix codec capability setup in chan_skinnymvanbaak1-13/+42
Behaviour now is that general codec config flows to default_line and default_device. [devices] stuff amends default_device and similar for [lines]. These are copied to individual device and line as they are created. Added confcapability and confprefs for the configured stuff which doesn't change as device and so on are connected. prefs are based on line prefs if they exist, else the device prefs are used (prefs identifies codec order). (closes issue #13806) Reported by: pj Patches: codecs.diff uploaded by wedhorn (license 30) Tested by: pj and me git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163582 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Since chan_sip is callback devicestate driven do not pass in actual states, ↵file2-5/+10
pass in unknown so we get asked. Additionally do not pass in an actual device state value in ast_setstate since the channel may be callback driven. (closes issue #13525) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163579 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Add internationalization to sample configuration filedbailey1-0/+17
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163516 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Merged revisions 163511 via svnmerge from russell1-15/+15
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163511 | russell | 2008-12-12 08:40:31 -0600 (Fri, 12 Dec 2008) | 5 lines Specify uint32_t for variables storing a CRC32 so that it is actually 32 bits on 64-bit machines, as well. (inspired by issue #13879) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163512 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12Merged revisions 163448 via svnmerge from russell3-44/+114
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163448 | russell | 2008-12-12 07:44:08 -0600 (Fri, 12 Dec 2008) | 26 lines Resolve issues that could cause DTMF to be processed out of order. These changes come from team/russell/issue_12658 1) Change autoservice to put digits on the head of the channel's frame readq instead of the tail. If there were frames on the readq that autoservice had not yet read, the previous code would have resulted in out of order processing. This required a new API call to queue a frame to the head of the queue instead of the tail. 2) Change up the processing of DTMF in ast_read(). Some of the problems were the result of having two sources of pending DTMF frames. There was the dtmfq and the more generic readq. Both were used for pending DTMF in various scenarios. Simplifying things to only use the frame readq avoids some of the problems. 3) Fix a bug where a DTMF END frame could get passed through when it shouldn't have. If code set END_DTMF_ONLY in the middle of digit emulation, and a digit arrived before emulation was complete, digits would get processed out of order. (closes issue #12658) Reported by: dimas Tested by: russell, file Review: http://reviewboard.digium.com/r/85/ ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163449 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163383 via svnmerge from tilghman1-0/+21
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163383 | tilghman | 2008-12-11 17:35:55 -0600 (Thu, 11 Dec 2008) | 9 lines When a Ctrl-C or Ctrl-D ends a remote console, on certain shells, the terminal is messed up. By intercepting those events with a signal handler in the remote console, we can avoid those issues. (closes issue #13464) Reported by: tzafrir Patches: 20081110__bug13464.diff.txt uploaded by Corydon76 (license 14) Tested by: blitzrage ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163384 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163316 via svnmerge from mnicholson1-1/+41
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163316 | mnicholson | 2008-12-11 16:44:31 -0600 (Thu, 11 Dec 2008) | 9 lines Clean up the dundi cache every 5 minutes. (closes issue #13819) Reported by: adomjan Patches: pbx_dundi.c-clearcache.patch uploaded by adomjan (license 487) dundi_clearecache3.diff uploaded by mnicholson (license 96) Tested by: adomjan ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163317 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163253 via svnmerge from russell2-22/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163253 | russell | 2008-12-11 15:46:29 -0600 (Thu, 11 Dec 2008) | 8 lines Fix some observed slowdowns in dialplan processing. The change is to remove autoservice usage from dialplan functions that do not need it because they do not perform operations that potentially block. (closes issue #13940) Reported by: tbelder ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163254 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Fix a problem where continuous mode will get inadvertently get turned off if ↵russell1-5/+22
set_rate() is used while continuous mode was already turned on. (closes issue #13738) Reported by: smurfix Patches: res.patch.fixed uploaded by smurfix (license 547) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163241 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Add an option to voicemail.conf to allow urgent messages to bemmichelson2-1/+14
forwarded as not urgent. (closes issue #14063) Reported by: jaroth Patches: urgfwd_v2.patch uploaded by jaroth (license 50) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163213 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Add an appropriate goto if ast_call failsmmichelson1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163198 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Fix the "failed" extension for outgoing calls. russell1-2/+0
The conversion to use ast_check_hangup() everywhere instead of checking the softhangup flag directly introduced this problem. The issue is that ast_check_hangup() checked for tech_pvt to be NULL. Unfortunately, this will be NULL is some valid circumstances, such as with a dummy channel. The fix is simple. Don't check tech_pvt. It's pointless, because the code path that sets this to NULL is when the channel hangup callback gets called. This happens inside of ast_hangup(), which is the same function responsible for freeing the channel. Any code calling ast_check_hangup() better not be calling it after that point, and if so, we have a bigger problem at hand. (closes issue #14035) Reported by: erogoza git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163171 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Sometimes even Linux needs -lm to link libtonezone, such as when libtonezonetilghman2-3/+73
is compiled statically. (closes issue #13887) Reported by: tzafrir git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163168 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Reduce indentation level of ast_feature_request_and_dialmmichelson1-123/+124
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163166 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163092 via svnmerge from russell1-33/+39
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163092 | russell | 2008-12-11 10:54:51 -0600 (Thu, 11 Dec 2008) | 11 lines Fix an issue that made it so you could only have a single caller executing a custom feature at a time. This was especially problematic when custom features ran for any appreciable amount of time. The fix turned out to be quite simple. The dynamic features are now stored in a read/write list instead of a list using a mutex. (closes issue #13478) Reported by: neutrino88 Fix suggested by file ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163094 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163088 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163088 | tilghman | 2008-12-11 10:51:27 -0600 (Thu, 11 Dec 2008) | 6 lines Don't wait forever, if there's a specified recording timeout. (closes issue #13885) Reported by: bamby Patches: res_agi.c.patch uploaded by bamby (license 430) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163089 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163084 via svnmerge from mmichelson1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163084 | mmichelson | 2008-12-11 10:46:22 -0600 (Thu, 11 Dec 2008) | 4 lines Revert this cast to long. Using time_t here causes build failures on a FreeBSD 32-bit build. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163085 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Merged revisions 163080 via svnmerge from mmichelson1-21/+21
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163080 | mmichelson | 2008-12-11 10:24:43 -0600 (Thu, 11 Dec 2008) | 14 lines Fix a potential crash due to unsafe datastore handling. This patch also contains a conversion from using long to time_t for representing times for a queue, as well as some whitespace fixes. (closes issue #14060) Reported by: nivek Patches: datastore_fixup.patch.corrected uploaded by nivek (license 636) with slight modification from me Tested by: nivek ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163081 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11Fix some of the grammar issues in doc/tex/qos.tex.seanbright1-26/+26
(closes issue #14049) Reported by: kshumard Patches: doc.tex.qos.tex.patch uploaded by kshumard (license 92) (Slight modifications by seanbright) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163037 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11When a device registers to use it is entirely possible that they may be in ↵file1-1/+1
use, so tell the core that we don't know the devstate and have it ask us for it. (closes issue #13525) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162997 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10Previously missing line, now the substitution works correctlytilghman1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162930 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10Merged revisions 162926 via svnmerge from jpeeler1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162926 | jpeeler | 2008-12-10 16:52:51 -0600 (Wed, 10 Dec 2008) | 3 lines Oops, inverted logic for a strcasecmp check. Pointed out by mmichelson, thanks! ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162927 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10Fix reloads of aliased CLI commands. Due to changes done to turn it into a ↵file1-19/+4
single memory allocation we can't just use the existing CLI alias structure. We have to destroy all existing ones and then create new ones. (closes issue #14054) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162923 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10Checking global variables here actually overwrote the previous substitution bytilghman1-9/+0
channel variables, and in any case, was redundant; pbx_substitute_variables_helper ALREADY does substitution for global variables. (closes issue #13327) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162922 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10Merged revisions 162874 via svnmerge from jpeeler1-5/+5
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162874 | jpeeler | 2008-12-10 16:04:18 -0600 (Wed, 10 Dec 2008) | 5 lines (closes issue #13229) Reported by: clegall_proformatique Ensure that moh_generate does not return prematurely before local_ast_moh_stop is called. Also, the sleep in mp3_spawn now only occurs for http locations since it seems to have been added originally only for failing media streams. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162891 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10Merged revisions 162804 via svnmerge from file1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162804 | file | 2008-12-10 15:01:17 -0400 (Wed, 10 Dec 2008) | 6 lines Fix subscription based MWI up a bit. We only want to put sip: at the beginning of the URI if it is not already there and revert code to ignore destination check if subscribing for MWI. (closes issue #12560) Reported by: vsauer Patches: patch001.diff uploaded by ramonpeek (license 266) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162805 f38db490-d61c-443f-a65b-d21fe96a405b