aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-08-01Merged revisions 209879 via svnmerge from russell1-1/+5
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r209879 | russell | 2009-08-01 06:27:25 -0500 (Sat, 01 Aug 2009) | 5 lines Resolve a valgrind warning about a read from uninitialized memory. (issue #15396) Reported by: aragon ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209887 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-01Merged revisions 209838 via svnmerge from russell1-7/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r209838 | russell | 2009-08-01 05:59:05 -0500 (Sat, 01 Aug 2009) | 13 lines Modify how Playtones() is used in Milliwatt() to resolve gain issue. When Milliwatt() was changed internally to use Playtones() so that the proper tone was used, it introduced a drop in gain in the output signal. So, use the playtones API directly and specify a volume argument such that the output matches the gain of the original Milliwatt() code. (closes issue #15386) Reported by: rue_mohr Patches: issue_15386.rev2.diff uploaded by russell (license 2) Tested by: rue_mohr ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209839 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-01Fix ast_event_queue_and_cache() to actually do the cache() part.russell1-2/+5
(closes issue #15624) Reported by: ffossard Tested by: russell git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209835 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-01Revert accidental Makefile change.kpfleming1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209761 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-01Merged revisions 209759 via svnmerge from kpfleming7-7/+8
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r209759 | kpfleming | 2009-07-31 19:52:00 -0500 (Fri, 31 Jul 2009) | 7 lines Minor changes inspired by testing with latest GCC. The latest GCC (what will become 4.5.x) has a few new warnings, that in these cases found some either downright buggy code, or at least seriously poorly designed code that could be improved. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209760 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-31Fix some places where ast_event_type was used instead of ast_event_ie_type.russell1-9/+9
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209711 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-31Add configuration sample code for previous commit.mmichelson1-0/+21
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209674 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-31Improve chan_sip's ability to determine what methods should and should not ↵mmichelson1-67/+46
be used in a dialog. The previous effort here was to store what a peer is capable of receiving by parsing REGISTER requests from the peer and keeping that information for as long as the registration was active. The problem with this is that there are a great number of SIP devices which give no indication of the methods allowed in their REGISTER requests, and it is unreasonable to try to guess what the device may or may not support. In addition, some SIP devices have been found to claim support for a specific method, but their handling the method is less than ideal, or they are actually lying. With this patch, we now determine what methods a device supports by parsing the Allow header we receive from them, and we do this with each new dialog. In addition, a configuration option has been added so that an administrator can essentially blacklist certain methods from being used with certain peers if the admin knows that support for a specific method is dodgy or nonexistent. ABE-1822 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209673 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-30Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on ↵seanbright3-5/+18
verbose builds. (closes issue #15607) Reported by: mvanbaak Patches: 20090730_issue15607.patch uploaded by seanbright (license 71) Tested by: seanbright git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209623 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-30Add missing ifdef-s for service maintenance message functionalityjpeeler2-0/+4
(closes issue #15614) Reported by: fabled git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209619 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-30Fixes numerous spelling errors. Patch submitted by alecdavis.dbrooks11-14/+14
(closes issue #15595) Reported by: alecdavis git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209554 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-30Fix a crash that can result if text codecs are allowed but textsupport is ↵mmichelson1-1/+1
disabled. (closes issue #15596) Reported by: fabled Patches: sip-red.patch uploaded by fabled (license 448) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209516 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-29This patch adds the ability to send a CUSD command to a bluetooth device.mnicholson1-0/+163
(closes issue #15278) Reported by: Artem Patches: cusd5.patch uploaded by Artem (license 800) Tested by: mnicholson, Artem Review: https://reviewboard.asterisk.org/r/274/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209484 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-29Fixed a comment for hfp_parse_clipmnicholson1-2/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209453 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-28Define side-effect-safe MIN and MAX macros and remove duplicate definitions ↵kpfleming7-36/+5
from various files. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209400 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-28Regex FTLtilghman1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209331 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-28Merged revisions 209315 via svnmerge from tilghman1-0/+18
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r209315 | tilghman | 2009-07-27 19:12:03 -0500 (Mon, 27 Jul 2009) | 2 lines Publish French extra sounds ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209317 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Cleanup T.38 negotiation changes.kpfleming1-5/+9
Convert LOG_NOTICE messages about T.38 negotiation in debug level 1 messages, clean up some looping logic, and correct an improper use of ast_free() for freeing an ast_frame. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209279 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Make T.38 switchover in ReceiveFAX synchronous.kpfleming1-56/+76
In receive mode, if the channel that ReceiveFAX is running on supports T.38, we should *always* attempt to switch T.38, rather than listening for an incoming CNG tone and only triggering on that. The channel may be using a low-bitrate codec that distorts the CNG tone, the sending FAX endpoint may not send CNG at all, or there could be a variety of other reasons that we don't detect it, but in all those cases if T.38 is available we certainly want to use it. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209256 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Gracefully handle malformed RTP text packets.mmichelson1-0/+3
AST-2009-004 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209235 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Honor channel's music class when using realtime music on hold.mmichelson1-20/+27
(closes issue #15051) Reported by: alexh Patches: 15051.patch uploaded by mmichelson (license 60) Tested by: alexh git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209197 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Merged revisions 209131 via svnmerge from mmichelson2-1/+27
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r209131 | mmichelson | 2009-07-27 12:44:06 -0500 (Mon, 27 Jul 2009) | 18 lines Allow for UDPTL to use only even-numbered ports if desired. There are some VoIP providers out there that will not accept SDP offers with odd numbered UDPTL ports. While it is my personal opinion that these VoIP providers are misinterpreting RFC 2327, it really is not a big deal to play along with their silly little games. Of course, since restricting UDPTL ports to only even numbers reduces the range of available ports by half, so the option to use only even port numbers is off by default. A user can enable the behavior by setting use_even_ports=yes in udptl.conf. (closes issue #15182) Reported by: CGMChris Patches: 15182.patch uploaded by mmichelson (license 60) Tested by: CGMChris ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209132 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Fixing typos. Replaces "recieved" with "received" and "initilize" with ↵dbrooks10-37/+37
"initialize" (closes issue #15571) Reported by: alecdavis git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209098 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Restore explicit export of ASTCFLAGS/ASTLDFLAGS and underscore-variants to ↵kpfleming1-4/+3
sub-makes. During the recent Makefile improvements I made, it seemed the 'make' was automatically carrying down the ASTCFLAGS/ASTLDFLAGS settings to sub-makes, so I removed the explict export of them. However, there are some circumstances where make does this, and some where it does not, so I've brought them back to ensure they are always exported. I also removed an extraneous double setting of _ASTLDFLAGS on *BSD platforms. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209056 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Blocked revisions 208990 via svnmergemvanbaak0-0/+0
........ r208990 | mvanbaak | 2009-07-27 11:56:13 +0200 (Mon, 27 Jul 2009) | 5 lines backport rev 205532 from trunk: pthread_self returns a pthread_t which is not an unsigned int on all pthread implementations. Casting it to an unsigned int fixes compiler warnings. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208991 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-27Merged revisions 208923 via svnmerge from jpeeler2-3/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208923 | jpeeler | 2009-07-26 20:18:31 -0500 (Sun, 26 Jul 2009) | 2 lines Fix logic errors from 208746 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208924 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-26add OpenBSD to the install_prereq scriptmvanbaak1-1/+20
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208886 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-25libxml2-dev is needed as well by default.mvanbaak1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208848 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-25add default alias reload to run module reload.mvanbaak2-5/+1
Requiring 'module reload' to reload everything, including core etc makes russell very unhappy. The default configuration already loads the 'friendly' aliases template. Added 'reload=module reload' to that template. Also removed the comment in main/cli.c that reload should come back. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208813 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-25Merged revisions 208746 via svnmerge from jpeeler3-6/+10
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208746 | jpeeler | 2009-07-25 01:19:50 -0500 (Sat, 25 Jul 2009) | 7 lines Fix compiling under dev-mode with gcc 4.4.0. Mostly trivial changes, but I did not know of any other way to fix the "dereferencing type-punned pointer will break strict-aliasing rules" error without creating a tmp variable in chan_skinny. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208749 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24Remove trailing whitespace.russell1-177/+177
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208709 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24Note that "reload" needs to be added back.russell1-0/+5
I keep getting annoyed at having to type "module reload" to reload everything, so I'm adding a note that we need to add "reload" back. "module reload" doesn't really make sense as the command to reload everything, including the core. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208706 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24Don't log a warning for something that does not affect operation.russell1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208693 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24Blocked revisions 208622 via svnmergemmichelson0-0/+0
........ r208622 | mmichelson | 2009-07-24 14:24:28 -0500 (Fri, 24 Jul 2009) | 16 lines Don't impose an arbitrary limit on member lines in queues.conf I know what some of you are thinking: "UGH! Mark, why are you using ast_strdup and ast_free for the string when you can just use ast_strdupa and let the memory free itself?! Have the bats been chewing on your brain again?" Based on past experiences, I don't like using ast_strdupa inside a loop. It's a good way to potentially exhaust stack space. Also, since this only happens when reloading queues, I don't think that heap allocations and frees are going to be a huge problem. (closes issue #15559) Reported by: amorsen ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208630 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24Merged revisions 208592 via svnmerge from russell1-1/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208592 | russell | 2009-07-24 13:38:24 -0500 (Fri, 24 Jul 2009) | 7 lines Do not log an ERROR if autoservice_stop() returns -1. This does not indicate an error. A return of -1 just means that the channel has been hung up. (reported in #asterisk-dev) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208593 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24Merged revisions 208587 via svnmerge from mmichelson1-1/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208587 | mmichelson | 2009-07-24 13:26:50 -0500 (Fri, 24 Jul 2009) | 10 lines Only send a BYE when hanging up a channel that is up. For cases where Asterisk sends an INVITE and receives a non 2XX final response, Asterisk would follow the INVITE transaction by immediately sending a BYE, which was unnecessary. (closes issue #14575) Reported by: chris-mac ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208588 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24Resolve a T.38 negotiation issue left over from the udptl-updates merge.kpfleming3-6/+6
The udptl-updates branch that was merged yesterday failed to properly send back T.38 SDP responses with the correct error correction mode, if the incoming SDP from the other end caused us to change error correction modes. This patch corrects that situation. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208548 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-24use aptitude for debian based systemsmvanbaak1-4/+3
The function to check wether we need to install packages was using dpkg-query which was gives wrong output on Debian 5 Also, the apt-get has been replaced with aptitude because aptitude is now the preferred way to handle packages on Debian (closes issue #15570) Reported by: mvanbaak Patches: 2009072400_installprereq-aptitude.diff uploaded by mvanbaak (license 7) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208542 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23T.38 change note is not necessary in this branchkpfleming1-11/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208504 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Rework of T.38 negotiation and UDPTL API to address interoperability problemskpfleming9-451/+353
Over the past couple of months, a number of issues with Asterisk negotiating (and successfully completing) T.38 sessions with various endpoints have been found. This patch attempts to address many of them, primarily focused around ensuring that the endpoints' MaxDatagram size is honored, and in addition by ensuring that T.38 session parameter negotiation is performed correctly according to the ITU T.38 Recommendation. The major changes here are: 1) T.38 applications in Asterisk (app_fax) only generate/receive IFP packets, they do not ever work with UDPTL packets. As a result of this, they cannot be allowed to generate packets that would overflow the other endpoints' MaxDatagram size after the UDPTL stack adds any error correction information. With this patch, the application is told the maximum *IFP* size it can generate, based on a calculation using the far end MaxDatagram size and the active error correction mode on the T.38 session. The same is true for sending *our* MaxDatagram size to the remote endpoint; it is computed from the value that the application says it can accept (for a single IFP packet) combined with the active error correction mode. 2) All treatment of T.38 session parameters as 'capabilities' in chan_sip has been removed; these parameters are not at all like audio/video stream capabilities. There are strict rules to follow for computing an answer to a T.38 offer, and chan_sip now follows those rules, using the desired parameters from the application (or channel) that wants to accept the T.38 negotiation. 3) chan_sip now stores and forwards ast_control_t38_parameters structures for tracking 'our' and 'their' T.38 session parameters; this greatly simplifies negotiation, especially for pass-through calls. 4) Since T.38 negotiation without specifying parameters or receiving the final negotiated parameters is not very worthwhile, the AST_CONTROL_T38 control frame has been removed. A note has been added to UPGRADE.txt about this removal, since any out-of-tree applications that use it will no longer function properly until they are upgraded to use AST_CONTROL_T38_PARAMETERS. Review: https://reviewboard.asterisk.org/r/310/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208464 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Merged revisions 208386 via svnmerge from mmichelson1-10/+11
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208386 | mmichelson | 2009-07-23 14:24:21 -0500 (Thu, 23 Jul 2009) | 17 lines Fix a problem where a 491 response could be sent out of dialog. This generalizes the fix for issue 13849. The initial fix corrected the problem that Asterisk would reply with a 491 if a reinvite were received from an endpoint and we had not yet received an ACK from that endpoint for the initial INVITE it had sent us. This expansion also allows Asterisk to appropriately handle an INVITE with authorization credentials if Asterisk had not received an ACK from the previous transaction in which Asterisk had responded to an unauthorized INVITE with a 407. (closes issue #14239) Reported by: klaus3000 Patches: 14239.patch uploaded by mmichelson (license 60) Tested by: klaus3000 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208388 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Merged revisions 208380 via svnmerge from jpeeler1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208380 | jpeeler | 2009-07-23 14:19:53 -0500 (Thu, 23 Jul 2009) | 6 lines Only set the priindication setting when not performing a reload (closes issue #14696) Reported by: fdecher ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208383 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Merged revisions 208312 via svnmerge from mmichelson1-4/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208312 | mmichelson | 2009-07-23 11:29:18 -0500 (Thu, 23 Jul 2009) | 3 lines Remove inaccurate XXX comment. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208314 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Fix sending of interface identifier unconditionally in sig_prijpeeler3-14/+13
The wrong logic was being used in chan_dahdi to convert a sig_pri_chan to the proper libpri channel number. The most significant bit must only be set only when trunk groups are being used. (closes issue #15452) Reported by: alecdavis Patches: bug15452.patch uploaded by jpeeler (license 325) Tested by: alecdavis git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208267 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Merged revisions 208262 via svnmerge from mmichelson1-1/+12
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208262 | mmichelson | 2009-07-23 10:43:07 -0500 (Thu, 23 Jul 2009) | 8 lines Properly handle 183 responses which do not contain an SDP. (closes issue #15442) Reported by: ffloimair Patches: 15442.patch uploaded by mmichelson (license 60) Tested by: tkarl, ffloimair ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208263 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Fix potential crash if p->owner is NULL.mmichelson1-2/+2
Problem was observed when a call-forwarding loop was accidentally configured. ABE-1906 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208229 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-23Resolve compiler warning on mac.russell1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208193 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-22Reset the fax buffers back to default settings regardless of signaling in use -jpeeler1-31/+28
Pointed out by Matt F. Also in the case of not using a signaling module, set the law back to the default as well. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208155 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-22Merged revisions 208083 via svnmerge from tilghman3-134/+12
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r208083 | tilghman | 2009-07-22 15:23:53 -0500 (Wed, 22 Jul 2009) | 4 lines Export symbols for functions included in our compatibility headers. (closes issue #15556) Reported by: smw1218 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208151 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-22Restore an int declaration on PPC platforms.qwell1-0/+1
This x is one crafty little bugger... It was used for 2 different things (one of which was only done on PPC) in 1.4. One of the uses were removed in trunk, and with it went the declaration. (closes issue #14038) Reported by: ffloimair git-svn-id: http://svn.digium.com/svn/asterisk/trunk@208113 f38db490-d61c-443f-a65b-d21fe96a405b