aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2007-11-14make the 'name' and 'value' fields in ast_variable const char *rizzo23-61/+76
This prevents modifying the strings in the stored variables, and catched a few instances where this was actually done. Given the differences between trunk and 1.4 (and the fact that this is effectively an API change) it is better to fix 1.4 independently. These are chan_sip.c::sip_register() chan_skinny.c:: near line 2847 config.c:: near line 1774 logger.c::make_components() res_adsi.c:: near line 1049 I may have missed some instances for modules that do not build here. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89268 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14Fix up various coding guidelines issues ...russell2-140/+189
- handle memory allocation failures - add an ast_ prefix to a publicly exported function - put curly braces in the right places - add a bunch of spaces where they should be be used git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89266 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14- Use the ARRAY_LEN macro in a couple placesrussell1-4/+4
- return errors from load_module / unload_module git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89265 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14Use BEGIN_OPTIONS / END_OPTIONS to make the syntax highlighting in my editor ↵russell1-2/+2
happy git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89264 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14Instead of reserving 800 bytes for periodic announcements, use an array ofrussell1-8/+24
ast_str pointers and only alloate space for the strings as needed. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89263 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14Merged revisions 89260 via svnmerge from file1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89260 | file | 2007-11-13 21:15:12 -0400 (Tue, 13 Nov 2007) | 4 lines Return the proper value when the srv_callback function executes properly. (closes issue #11240) Reported by: jtodd ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89262 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14Convert most of the strings in the call_queue struct to use stringfields.russell1-98/+117
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89261 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14use simpler technique for removing known entries from listskpfleming2-23/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89259 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-14- Simplify removing an item from a listrussell1-12/+5
- move a verbose message to after the item is added to the list - make use of the ARRAY_LEN macro in one spot git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89258 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13This hopefully will fix the re-opened 11233. Hadn't covered the case of a ↵murf1-1/+1
context with no patterns. (blush) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89257 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13closes issue #11233 -- where some fine points in the algorithm to build the ↵murf1-3/+6
tree needed to be corrected. Many thanks for the test case, jtodd git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89256 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Blocked revisions 89254 via svnmergeqwell0-0/+0
(closes issue #11238) ........ r89254 | qwell | 2007-11-13 15:07:08 -0600 (Tue, 13 Nov 2007) | 4 lines Fix building on newer systems which require a third arg to open() when using O_CREAT. Issue 11238, reported by puzzled. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89255 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13This fixes a build error on my mac. It also works on my linux box. Let merussell1-1/+1
know if it breaks any other platform ... git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89253 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Fix a typo pointed out by outtolunc, thanks :)russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89252 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13- Convert initialization of a struct to C99 style instead of GNU stylerussell1-7/+7
- Fix a minor spelling error in a comment git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89251 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Update the ParkedCall application to grab the first available parked call if norussell2-10/+9
parked extension is provided as an argument. (closes issue #10803) Reported by: outtolunc Patches: res_features-parkedcall-any.diff4 uploaded by outtolunc (license 237) - modified by me to work a bit differently ... git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89250 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Merged revisions 89248 via svnmerge from qwell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 (closes issue #11237) ........ r89248 | qwell | 2007-11-13 13:47:45 -0600 (Tue, 13 Nov 2007) | 7 lines Revert change from revision 67064. It is documented behavior that if a parking extension already exists while using PARKINGEXTEN, dialplan execution will continue. If blind transferring to a Park with PARKINGEXTEN, you must keep this in mind, and handle the failure yourself. Issue 11237, reported by jon. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89249 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Merged revisions 89246 via svnmerge from tilghman1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89246 | tilghman | 2007-11-13 11:34:11 -0600 (Tue, 13 Nov 2007) | 2 lines If we set a value for qualify, we should actually pay attention to it, instead of overriding the value ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89247 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Merged revisions 89241 via svnmerge from mmichelson1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89241 | mmichelson | 2007-11-13 10:02:02 -0600 (Tue, 13 Nov 2007) | 5 lines Reverting commit made in revision 89205 since it is unnecessary. Thanks to Kevin for pointing this out ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89242 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Merged revisions 89239 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89239 | tilghman | 2007-11-13 07:51:53 -0600 (Tue, 13 Nov 2007) | 4 lines Debugging is running into the 16-lock limit. Increase to avoid. (This define is only effective when debugging is turned on, so there's no effect for most installations.) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89240 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13There is the potential to copy uninitialized memory into the ↵mmichelson1-1/+1
mixmonitor->post_process string. This fix prevents that. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89207 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13Merged revisions 89205 via svnmerge from mmichelson1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89205 | mmichelson | 2007-11-12 18:56:46 -0600 (Mon, 12 Nov 2007) | 5 lines Some sanity checking for MixMonitor. If only 1 argument is given, then the args.options and args.post_process strings are uninitialized and could contain garbage. This change handles this situation properly by only using arguments that we have parsed. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89206 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-13oops, somebody left out the directory here...qwell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89203 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Doxygen fixes.qwell13-29/+35
Also fix a common typo I kept seeing (arguement) in various files. Closes issue #11222, patch by snuffy (with arguement > argument by me). git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89202 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Don't forget the ASTERISK_VERSION for the sake of the mtx_prof stuff.murf1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89201 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Thanks to snuffy for this doxygen update to hashtab.h; closes issue #11223murf1-96/+161
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89198 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Thanks to snuff-work, who brought up that these fixes might need to be made.murf2-6/+6
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89196 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Merged revisions 89194 via svnmerge from qwell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89194 | qwell | 2007-11-12 14:46:52 -0600 (Mon, 12 Nov 2007) | 1 line Fix a typo pointed out by De_Mon on #asterisk-dev ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89195 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Blocked revisions 89191 via svnmergetilghman0-0/+0
........ r89191 | tilghman | 2007-11-12 14:16:18 -0600 (Mon, 12 Nov 2007) | 5 lines If two config writes collide, file corruption could result. Use a mkstemp() file, instead. Reported by: paravoid Patch by: tilghman Closes issue #10781 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89193 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12(closes issue #11221)kpfleming2-14/+2
Reported by: eliel Patches: utils.Makefile.patch uploaded by eliel (modified by me) (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89190 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Based on a note in asterisk-dev by Brian Capouch, I determined I too ↵murf8-2/+11
agressive in not initializing arrays passed to pbx_substitute_variables_xxxx; I reviewed the code (again) and hopefully found every possible spot where substitute_variables is called conditionally, and made sure the char array involved was set to a null string. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89186 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Merged revisions 89184 via svnmerge from tilghman2-1/+11
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89184 | tilghman | 2007-11-12 11:29:17 -0600 (Mon, 12 Nov 2007) | 5 lines Fix two cases of memory corruption caused by background threads. Reported by: atis Patch by: tilghman Fixes issue #10923 ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89185 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Merged revisions 89173 via svnmerge from crichter2-0/+18
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89173 | crichter | 2007-11-12 12:26:48 +0100 (Mo, 12 Nov 2007) | 1 line if we're NT and no number was dialed and overlapdial is set, we wait for the ISDN timeout instead of starting our own timer. added a comment for the misdn.conf.sample for the overlapdial config option. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89179 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Merged revisions 89172 via svnmerge from crichter4-24/+41
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89172 | crichter | 2007-11-12 12:23:57 +0100 (Mo, 12 Nov 2007) | 1 line added restart all interfaces Restart_Indicator, to automatically send a RESTART after the L2 of a PTP Port comes up. Also fixed some places where we have send a RELEASE without need for it. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89178 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Fix building on FreeBSD by including/not including some headers.file2-0/+3
(closes issue #11218) Reported by: ys Patches: trunk89169.diff uploaded by ys (license 281) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89177 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Merged revisions 89171 via svnmerge from crichter2-31/+44
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89171 | crichter | 2007-11-12 12:13:13 +0100 (Mo, 12 Nov 2007) | 1 line fixed a state/event issue with overlapdial=yes when no extension matched. removed the general sending of a RELEASE_COMPLETE when we receive a RELEASE, this is done by mISDNuser/mISDN. This makes it possible to use asterisk-1.4 with mISDN trunk, but requires users of mISDN/mISDNuser-1.1.X to upgrade to at least mISDNuser-1.1.6 (when using the NT mode at all) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89176 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Merged revisions 89170 via svnmerge from crichter1-0/+5
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89170 | crichter | 2007-11-12 10:57:23 +0100 (Mo, 12 Nov 2007) | 1 line fixed the support for CW and therefore for the reject_cause option. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89175 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12Merged revisions 89169 via svnmerge from crichter6-2/+33
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89169 | crichter | 2007-11-12 10:45:36 +0100 (Mo, 12 Nov 2007) | 1 line aded ntkeepcalls option, to avoid droÃpping calls when the L2 goes down on a PTP link. There are some pbx which do turn off the L1 for a very short while and restart it immediately. normally T310 should be started and after 10 seconds or so the calls should be dropped, this is a simple fix wihtout this timer. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89174 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-09Add usbradio.conf.sample from branches/1.4/configs - r84162.qwell1-0/+54
It was mistakenly deleted in 1.4 without ever being merged to trunk. Reported by eliel on #asterisk-dev. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89132 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-09Fix a few potential deadlocks in cdr_sqlite3_custom.qwell2-0/+3
(also rename sample config to .sample) Closes issue #11208, patch by Laureano. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89130 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-09This is the perhaps the biggest, boldest, most daring change I've ever ↵murf9-55/+2299
committed to trunk. Forgive me in advance any disruption this may cause, and please, report any problems via the bugtracker. The upside is that this can speed up large dialplans by 20 times (or more). Context, extension, and priority matching are all fairly constant-time searches. I introduce here my hashtables (hashtabs), and a regression for them. I would have used the ast_obj2 tables, but mine are resizeable, and don't need the object destruction capability. The hashtab stuff is well tested and stable. I introduce a data structure, a trie, for extension pattern matching, in which knowledge of all patterns is accumulated, and all matches can be found via a single traversal of the tree. This is per-context. The trie is formed on the first lookup attempt, and stored in the context for future lookups. Destruction routines are in place for hashtabs and the pattern match trie. You can see the contents of the pattern match trie by using the 'dialplan show' cli command when 'core set debug' has been done to put it in debug mode. The pattern tree traversal only traverses those parts of the tree that are interesting. It uses a scoreboard sort of approach to find the best match. The speed of the traversal is more a function of the length of the pattern than the number of patterns in the tree. The tree also contains the CID matching patterns. See the source code comments for details on how everything works. I believe the approach general enough that any issues that might come up involving fine points in the pattern matching algorithm, can be solved by just tweaking things. We shall see. The current pattern matcher is fairly involved, and replicating every nuance of it is difficult. If you find and report problems, I will try to resolve than as quickly as I can. The trie and hashtabs are added to the existing context and exten structs, and none of the old machinery has been removed for the sake of the multitude of functions that use them. In the future, we can (maybe) weed out the linked lists and save some space. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89129 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08Merged revisions 89125 via svnmerge from qwell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 (closes issue #11203) ........ r89125 | qwell | 2007-11-08 17:52:35 -0600 (Thu, 08 Nov 2007) | 4 lines Properly say the seconds here.. Issue 11203, fix described by vma. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89126 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08Add check_hangup() method to pbx_lua, which can be used to check whether it ↵qwell1-0/+33
is time to hangup a channel. Closes issue #11202, patch by mnicholson git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89124 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08app_voicemail failed to build when compiling with IMAP_STORAGEmmichelson1-3/+2
Now it does not. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89123 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08AST_LIST_REMOVE_CURRENT takes only one argument.mmichelson1-1/+1
Thanks to snuffy for pointing this out on IRC git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89122 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08Make func_env build again.file1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89121 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08Merged revisions 89119 via svnmerge from mmichelson1-27/+14
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89119 | mmichelson | 2007-11-08 15:00:08 -0600 (Thu, 08 Nov 2007) | 7 lines Rework of the commit I made yesterday to use the already built-in ast_uri_decode function as opposed to my home-rolled one. Also added comments. Thanks to oej for pointing me in the right direction ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89120 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08convert this code to a more efficient idiomkpfleming1-3/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89118 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08Change a warning to a notice. Issue #11195, patch by elielqwell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89117 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-08Merged revisions 89115 via svnmerge from qwell2-14/+14
https://origsvn.digium.com/svn/asterisk/branches/1.4 (closes issue #11195) ........ r89115 | qwell | 2007-11-08 12:45:15 -0600 (Thu, 08 Nov 2007) | 4 lines Avoid warnings on load when using sample configuration files. Issue 11195, patch by eliel. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89116 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 19:31:40 +0000