aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-11-02Don't allow two separate instances of safe_asterisk when restarting from the ↵tilghman1-1/+7
init script. (closes issue #14562) Reported by: davidw Patches: Initially 20091022__issue14562.diff.txt uploaded by tilghman (license 14) Modified to 20091030__Issue14562_diff.txt uploaded by davidw (license 780) Tested by: davidw git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226811 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-02fixes crash on iterator_destroy on uninitialized iteratordvossel1-1/+0
(closes issue #16162) Reported by: krn git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226736 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-02changes calltoken debug messages from LOG_NOTICE to LOG_DEBUG like they are ↵dvossel1-6/+6
supposed to be (closes issue #16144) Reported by: aragon git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226688 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-29Add an option to enabling passing music on hold start and stop requests ↵file2-3/+8
through instead of acting on them in chan_local. (closes issue #14709) Reported by: dimas git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226531 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-28Update documentation in sip.conf.sample.lmadsen1-0/+7
Update the documentation in sip.conf.sample in order to make it more clear that directmedia/canreinvite do not cause Asterisk to ignore reINVITEs. It is only used to stop Asterisk from generating a reINVITE, but does not stop it from accepting them if necessary. (closes issue #15644) Reported by: lmadsen git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226382 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-28Update CALLINGSUBADDR channel variable documentation.lmadsen1-1/+1
(closes issue #15734) Reported by: alecdavis Patches: channelvariables.tex.diff.txt uploaded by alecdavis (license 585) Tested by: alecdavis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226377 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-28Fix documentation (pointed out by TheDavidFactor on #-dev)tilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226304 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-27Manager output is not always NULL-terminated, so force a NULL at the end of ↵tilghman1-2/+6
the filestream. (closes issue #15495) Reported by: pdf Patches: 20090916__issue15495.diff.txt uploaded by tilghman (license 14) Tested by: pdf git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@226138 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-26detect ARM Linux EABI OSARCH as linux-gnu instead of linux-gnueabitzafrir3-14/+14
* Set OSARCH to linux-gnu even if host_os is linux-gnueabi * When checking if we are Linux, check OSARCH rather than host_os The newer ARM ABI ("EABI") shows the OS name 'linux-gnueabi' rather than 'linux-gnu' . This patch sets OSARCH to be 'linux-gnu' even in such a case. OSARCH is tested for the value of 'linux-gnu' in one or two places in the tree. This patch also fixes the check libcap to check for $OSARCH rather than $host_os . See also: http://wiki.debian.org/ArmEabiPort git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225957 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-23Don't force menuselect.makeopts to be rebuilt on every build.kpfleming1-3/+26
For some reason the menuselect.makeopts file was listed as PHONY in the Makefile, resulting in 'make' needing to rebuild it for every build. This then resulted in the embedded module rules being rebuilt on every build, which can be slow and is unnecessary. This patch fixes the problem by properly allowing 'make' to know when the menuselect.makeopts file needs to be rebuilt (defining the proper dependencies). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225581 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-22Clean valgrind output by suppressing false errors.lmadsen2-10/+45
Update valgrind.txt documentation and add valgrind.supp file in order to allow those who are creating valgrind output to have less false errors in the logfile. (closes issue #16007) Reported by: atis Patches: valgrind.txt.diff uploaded by atis (license 242) asterisk2.supp uploaded by atis (license 242) Tested by: atis, amorsen git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225484 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21IAX2: VNAK loop caused by signaling frames with no destination call numberdvossel1-10/+77
It is possible for the PBX thread to queue up signaling frames before a destination call number is received. This can result in signaling frames being sent out with no destination call number. Since recent versions of Asterisk require accurate destination callnumbers for all Full Frames, this can cause a VNAK loop to occur. To resolve this no signaling frames are sent until a destination callnumber is received, and destination call numbers are now only required for iax_pvt matching when the frame is an ACK. Review: https://reviewboard.asterisk.org/r/413/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225243 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Revert 225169, as this doesn't account for the possibility of a list of frames.russell1-6/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225171 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Isolate the frame returned from ast_translate().russell1-2/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225169 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Fix documentation for ast_softhangup() and correct the misuse thereof.tilghman3-5/+6
(closes issue #16103) Reported by: majorbloodnok git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225105 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Suffix is not needed for a matchtilghman1-16/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225103 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21IAX/SIP shrinkcallerid optiondvossel4-10/+51
The shrinking of caller id removes '(', ' ', ')', non-trailing '.', and '-' from the string. This means values such as 555.5555 and test-test result in 555555 and testtest. There are instances, such as Skype integration, where a specific value is passed via caller id that must be preserved unmodified. This patch makes the shrinking of caller id optional in chan_sip and chan_iax in order to support such cases. By default this option is on to preserve previous expected behavior. (closes issue #15940) Reported by: dimas Patches: v2-15940.patch uploaded by dimas (license 88) 15940_shrinkcallerid_trunk.c uploaded by dvossel (license 671) Tested by: dvossel Review: https://reviewboard.asterisk.org/r/408/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@225032 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-21Isolate frames returned from a DSP instance or codec translator.russell7-123/+12
The reasoning for these changes are the same as what I wrote in the commit message for rev 222878. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@224931 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-20Pay attention to the return value of the manipulate function.tilghman1-4/+12
While this looks like an optimization, it prevents a crash from occurring when used with certain audiohook callbacks (diagnosed with SVN trunk, backported to 1.4 to keep the source consistent across versions). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@224855 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-20Add support for relaying early media in the features attended transfer option.file1-1/+5
(closes issue #14828) Reported by: licedey git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@224773 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-19Correct timestamp calculations when RTP sample rates over 8kHz are used.kpfleming1-9/+14
While testing some endpoints that support 16kHz and 32kHz sample rates, some log messages were generated due to calc_rxstamp() computing timestamps in a way that produced odd results, so this patch sanitizes the result of the computations. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@224670 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-19Do not attempt early media bridging (ie: direct RTP setup) if options are ↵file1-6/+11
enabled that should prevent it. (closes issue #14763) Reported by: cupotka git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@224565 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-17Fix stale caller id data from being reported in AMI NewChannel eventjpeeler1-2/+9
The problem here is that chan_dahdi is designed in such a way to set certain values in the dahdi_pvt only once. One of those such values is the configured caller id data in chan_dahdi.conf. For PRI, the configured caller id data could be overwritten during a call. Instead of saving the data and restoring, it was decided that for all non-analog channels it was simply best to not set the configured caller id in the first place and also clear it at the end of the call. (closes issue #15883) Reported by: jsmith git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@224330 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-16Never released PRI channels when using Busy() or Congestion() dialplan apps.rmudgett1-4/+12
When the Busy() or Congestion() application is used towards ISDN (an ISDN progress is sent), the responding ISDN Disconnect or Release may contain the ISDN cause user busy or one of the congestion causes. In chan_dahdi.c these causes will only set the needbusy or needcongestion flags and not activate the softhangup procedure. Unfortunately only the latter can interrupt the endless wait loop of Busy()/Congestion(). Result: PRI channels staying in state busy for the rest of asterisk life or until the other end times out and forces the call to clear. (in issue 0014292) Reported by: tomaso Patches: disc_rel_userbusy.patch uploaded by tomaso (license 564) (This patch is unrelated to the issue.) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@224260 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-13Fix PRI timer T309 operationjeang1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223955 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-12Ensure ringing continues for branched calls after progress is receivedjpeeler1-2/+7
While waiting for an answer, don't send progress for branched calls for which ringing was sent. (closes issue #15028) Reported by: fnordian git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223804 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-12Remove automatic switching from T.38 to voice mode in chan_sip.kpfleming1-2/+1
chan_sip has some code to automatically switch from T.38 mode to voice mode when a voice frame is written to the channel while it is in T.38 mode; this was intended to handle the situation when a FAX transmission has ended and the channel is not yet hung up, but is causing problems at the beginning of FAX sessions as well when there are still voice frames 'in flight' at the time the T.38 negotiation completes. This patch removes the automatic switchover. (issue #16025) Reported by: jamicque git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223692 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-11Remove a duplicate ao2_iterator_destroy().russell1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223550 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-11Remove some unnecessary code.russell1-4/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223486 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-11Don't use data outside of its scope.russell1-1/+5
The purpose of this code was to have a hangup frame put on the list of deferred frames. However, the code that read the hangup frame was outside of the scope of where the hangup frame was declared. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223485 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-09Signal timeouts by returning AST_CONTROL_RINGING when originating calls.mnicholson1-1/+5
(closes issue #15104) Reported by: nblasgen Patches: manager-timeout1.diff uploaded by mnicholson (license 96) Tested by: nblasgen, mnicholson git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223225 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-09Fix potential memory leak in app_dial.cmmichelson1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223213 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-09fixes sip registration using authuser in user.confdvossel1-3/+11
(closes issue #14954) Reported by: tornblad Tested by: mmichelson, tornblad, dvossel git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223205 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-09'auth=' did not parse md5 secret correctlydvossel1-12/+10
(closes issue https://issues.asterisk.org/view.php?id=15949) Reported by: ebroad Patches: authparsefix.patch uploaded by ebroad (license 878) 15949_trunk.diff uploaded by dvossel (license 671) Tested by: ebroad git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@223142 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-08Make filestream frame handling safer by isolating frames before returning them.russell4-68/+38
This patch is related to a number of issues on the bug tracker that show crashes related to freeing frames that came from a filestream. A number of fixes have been made over time while trying to figure out these problems, but there re still people seeing the crash. (Note that some of these bug reports include information about other problems. I am specifically addressing the filestream frame crash here.) I'm still not clear on what the exact problem is. However, what is _very_ clear is that we have seen quite a few problems over time related to unexpected behavior when we try to use embedded frames as an optimization. In some cases, this optimization doesn't really provide much due to improvements made in other areas. In this case, the patch modifies filestream handling such that the embedded frame will not be returned. ast_frisolate() is used to ensure that we end up with a completely mallocd frame. In reality, though, we will not actually have to malloc every time. For filestreams, the frame will almost always be allocated and freed in the same thread. That means that the thread local frame cache will be used. So, going this route doesn't hurt. With this patch in place, some people have reported success in not seeing the crash anymore. (SWP-150) (AST-208) (ABE-1834) (issue #15609) Reported by: aragon Patches: filestream_frisolate-1.4.diff2.txt uploaded by russell (license 2) Tested by: aragon, russell (closes issue #15817) Reported by: zerohalo Tested by: zerohalo (closes issue #15845) Reported by: marhbere Review: https://reviewboard.asterisk.org/r/386/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222878 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-08fixes an ast_netsock_list memory leak.dvossel2-2/+1
ABE-1998 Review: https://reviewboard.asterisk.org/r/395/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222877 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-08Fix memory leak if chan_misdn config parameter is repeated.rmudgett1-4/+15
Memory leak when the same config option is set more than once in an misdn.conf section. Why must this be considered? Templates! Defining a template with default port options and later adding to or overriding some of them. Patches: memleak-misdn.patch JIRA ABE-1998 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222797 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-07chan_misdn.c:process_ast_dsp() memory leakrmudgett1-2/+6
misdn.conf: astdtmf must be set to "yes". With "no", buffer loss does not occur. The translated frame "f2" when passing through ast_dsp_process() is not freed whenever it is not used further in process_ast_dsp(). Then in the end it is never ever freed. Patches: translate.patch JIRA ABE-1993 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222691 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-07crash on transferdvossel1-1/+4
handle_invite_replaces() attempts to uplock a pvt's owner channel without first verifing that it exists. (issue #16027) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222542 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-06Add missing unlock(s) in dahdi_readjpeeler1-1/+4
(two cases in trunk) (closes issue #15683) Reported by: alecdavis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222462 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-06Fix potential crash when entire span request is received.jpeeler1-2/+2
The variable index used in this scenario for accessing the dahdi_pvts was wrong and was most likely copied from the several other places it is used correctly. (closes issue #15998) Reported by: tsearle Patches: dahdi_reset_crash.patch uploaded by tsearle (license 373) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222393 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-06Fix ao2_iterator API to hold references to containers being iterated.kpfleming5-7/+107
See Mantis issue for details of what prompted this change. Additional notes: This patch changes the ao2_iterator API in two ways: F_AO2I_DONTLOCK has become an enum instead of a macro, with a name that fits our naming policy; also, it is now necessary to call ao2_iterator_destroy() on any iterator that has been created. Currently this only releases the reference to the container being iterated, but in the future this could also release other resources used by the iterator, if the iterator implementation changes to use additional resources. (closes issue #15987) Reported by: kpfleming Review: https://reviewboard.asterisk.org/r/383/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222152 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-02Removes unnecessary unlock, clarifies a memcpy.dvossel1-2/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@222026 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-02Ensure the result of the hash function is positive. Negative array offsets ↵tilghman1-1/+1
suck. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@221970 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-01Fix a bunch of off-by-one errorstilghman3-19/+19
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@221776 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-01Occasionally losing use of B channels in chan_misdn.rmudgett2-41/+66
I have not been able to reproduce the problem of losing channels. However, I have seen in the code a reentrancy problem that might give these symptoms. The reentrancy patch does several things: 1) Guards B channel and B channel structure allocation. 2) Makes the B channel structure find routines more precise in locating records. 3) Never leave a B channel allocated if we received cause 44. The last item may cause temporary outgoing call problems, but they should clear when the line becomes idle. (closes issue #15490) Reported by: slutec18 Patches: issue15490_channel_alloc_reentrancy.patch uploaded by rmudgett (license 664) Tested by: rmudgett, slutec18 (closes issue #15458) Reported by: FabienToune Patches: issue15458_channel_alloc_reentrancy.patch uploaded by rmudgett (license 664) Tested by: FabienToune, rmudgett, slutec18 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@221769 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-01Use unsigned ints for portinuri flags.mnicholson1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@221588 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30Make portinuri a bitfield.mnicholson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@221489 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30Fix SRV lookup and Request-URI generation in chan_sip.mnicholson2-4/+30
This patch adds a new field "portinuri" to the sip dialog struct and the sip peer struct. That field is used during RURI generation to determine if the port should be included in the RURI. It is also used in some places to determine if an SRV lookup should occur. (closes issue #14418) Reported by: klaus3000 Tested by: klaus3000, mnicholson Review: https://reviewboard.asterisk.org/r/369/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@221360 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-30changed the prototype definition of csv_quotemnick1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@221303 f38db490-d61c-443f-a65b-d21fe96a405b