Age | Commit message (Collapse) | Author | Files | Lines |
|
(closes issue #14089)
Reported by: caspy
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164605 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164422 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
deadlock scenario so that it is avoided in the future
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164416 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13800)
Reported by: dwagner
Patches:
asterisk-1.4.22-chan-sip-nullp.patch uploaded by tweety (license 608)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164350 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
not blindly assume Solaris does not.
(closes issue #13838)
Reported by: ano
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164343 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #14074)
Reported by: wetwired
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164204 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
The issue that was reported was about a case where a RINGING channel got
redirected to an extension to pick up a call from parking. Once the parked
call got taken out of parking, it heard silence until the other side answered.
Ideally, the caller that was parked would get a ringing indication. This patch
fixes this case so that the caller receives ringback once it comes out of
parking until the other side answers.
The fixes are:
- Make sure we remember that a channel was an outgoing channel when doing
a masquerade. This prevents an erroneous ast_answer() call on the channel,
which causes a bogus 200 OK to be sent in the case of SIP.
- Add some additional comments to explain related parts of code.
- Update the handling of the ast_channel visible_indication field. Storing
values that are not stateful is pointless. Control frames that are events
or commands should be ignored.
- When a bridge first starts, check to see if the peer channel needs to be
given ringing indication because the calling side is still ringing.
- Rework ast_indicate_data() a bit for the sake of readability.
(closes issue #13747)
Reported by: davidw
Tested by: russell
Review: http://reviewboard.digium.com/r/90/
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164201 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
can better detect an exceptional case. This follows on to the changes made
in revision 156386. Related to issue #13851.
(closes issue #13974)
Reported by: paradise
Patches:
20081208__bug13974.diff.txt uploaded by Corydon76 (license 14)
Tested by: file, blitzrage, ZX81
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@164082 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163785 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
pointer inside editline to look back to asterisk.c, so others don't spend
as much time as I did looking (in the wrong place) for the appropriate
function.
Reported by: ZX81, via the #asterisk-users channel
Fixed by: me (license 14)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163761 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
on 64-bit machines, as well.
(inspired by issue #13879)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163511 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
These changes come from team/russell/issue_12658
1) Change autoservice to put digits on the head of the channel's frame readq
instead of the tail. If there were frames on the readq that autoservice
had not yet read, the previous code would have resulted in out of order
processing. This required a new API call to queue a frame to the head
of the queue instead of the tail.
2) Change up the processing of DTMF in ast_read(). Some of the problems
were the result of having two sources of pending DTMF frames. There
was the dtmfq and the more generic readq. Both were used for pending
DTMF in various scenarios. Simplifying things to only use the frame
readq avoids some of the problems.
3) Fix a bug where a DTMF END frame could get passed through when it
shouldn't have. If code set END_DTMF_ONLY in the middle of digit emulation,
and a digit arrived before emulation was complete, digits would get
processed out of order.
(closes issue #12658)
Reported by: dimas
Tested by: russell, file
Review: http://reviewboard.digium.com/r/85/
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163448 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
is messed up. By intercepting those events with a signal handler in the remote
console, we can avoid those issues.
(closes issue #13464)
Reported by: tzafrir
Patches:
20081110__bug13464.diff.txt uploaded by Corydon76 (license 14)
Tested by: blitzrage
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163383 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13819)
Reported by: adomjan
Patches:
pbx_dundi.c-clearcache.patch uploaded by adomjan (license 487)
dundi_clearecache3.diff uploaded by mnicholson (license 96)
Tested by: adomjan
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163316 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
The change is to remove autoservice usage from dialplan functions that do not
need it because they do not perform operations that potentially block.
(closes issue #13940)
Reported by: tbelder
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163253 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
a custom feature at a time. This was especially problematic when custom
features ran for any appreciable amount of time.
The fix turned out to be quite simple. The dynamic features are now stored
in a read/write list instead of a list using a mutex.
(closes issue #13478)
Reported by: neutrino88
Fix suggested by file
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163092 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13885)
Reported by: bamby
Patches:
res_agi.c.patch uploaded by bamby (license 430)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163088 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
FreeBSD 32-bit build.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163084 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
This patch also contains a conversion from using long to time_t
for representing times for a queue, as well as some whitespace
fixes.
(closes issue #14060)
Reported by: nivek
Patches:
datastore_fixup.patch.corrected uploaded by nivek (license 636)
with slight modification from me
Tested by: nivek
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@163080 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162926 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Reported by: clegall_proformatique
Ensure that moh_generate does not return prematurely before local_ast_moh_stop is called. Also, the sleep in mp3_spawn now only occurs for http locations since it seems to have been added originally only for failing media streams.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162874 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
beginning of the URI if it is not already there and revert code to ignore destination check if subscribing for MWI.
(closes issue #12560)
Reported by: vsauer
Patches:
patch001.diff uploaded by ramonpeek (license 266)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162804 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
contains an expires of 0.
(closes issue #13599)
Reported by: hjourdain
Patches:
chan_sip.c.diff uploaded by hjourdain (license 583)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162738 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Reported by: wetwired
Tested by: murf
I checked, and I added a mod to the trunk version
of Asterisk that would make it 8-bit transparent
on 27 Nov 2007, but I made no such updates to
1.4. My best guess is that 1.4 was released, and
it was not appropriate to commit an enhancement.
But I'm going to add the same fixes to 1.4 now,
for the following reasons:
1. wetwired is correct; 1.4 is **mostly** 8-bit
transparent now. This is because the lexical
token forming rules use . in most 'word'
state continuances. It's just the beginning
of a 'word' that is picky.
2. Accepting 8-bit chars in some places and
not others leads to bug reports like this.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162671 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
parameters are not evaluated multiple times.
An example where this caused a problem was in chan_sip.c, with
the line
ast_string_field_set(p, fromdomain, ++fromdomain);
This patch was originally uploaded to issue #13783 by
jamessan. While the issue was closed for other reasons, this
patch is valid and fixes a separate problem, and is thus
being committed.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162670 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
it helped to fix.
(closes issue #13783)
Reported by: navkumar
(closes issue #14025)
Reported by: ffs
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162663 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #14052)
Reported by: festr
Patches:
misdn.txt.patch uploaded by festr (license 443)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162659 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
the RFC some more and doing some testing I agree with this change.
(closes issue #12983)
Reported by: vt
Patches:
dtmf_inc_seqnum_on_end_pkts.diff uploaded by vt (license 520)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162653 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162463 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
The test is not valid. Besides, if we actually suspected that recursive
mutexes were not working, we would get a ton of LOG_ERROR messages when
DEBUG_THREADS is turned on.
(inspired by a discussion on the asterisk-dev list)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162413 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
without actually having implemented it. Oops.
(Reported by Olivier on the -users list)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162348 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
receive session progress when dialing a device and not ringing.
(closes issue #14005)
Reported by: ddl
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162341 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
hear ringback.
We need to make sure that we don't start writing audio to the trunk channel until we're
actually ready to answer it. Otherwise, the channel driver will treat it as inband
progress, even though all they are getting is silence.
(closes issue #12471)
Reported by: mthomasslo
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162286 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #14038)
Reported by: ffloimair
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162273 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
be sure to decrease the number of active calls on the system.
This fix may relate to ABE-1713, but it is not certain yet.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162265 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
rule, and an option to suppress the default rule from being generated in the flex output, for the sake of those OS's where they didn't tweak flex's ECHO macro, and the compiler doesn't like it. The regressions are OK with this.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162264 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
frame and do not send audio when transmitting DTMF as this confuses some equipment.
(closes issue #13209)
Reported by: ip-rob
Patches:
13209.diff uploaded by file (license 11)
Tested by: ip-rob, bujones
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162204 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13535)
Reported by: davidw
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162188 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
standalone stuff. Fixed.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162136 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
'value computed is not used'. Fixing (for --enable-dev-mode).
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162071 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13330)
Reported by: jcovert
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162014 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Reported by: ckjohnsonme
Patches:
14019.diff uploaded by murf (license 17)
Tested by: ckjohnsonme, murf
This crash was the result of a few small errors that
would combine in 64-bit land to result in a crash.
32-bit land might have seen these combine to mysteriously
drop the args to an application call, in certain
circumstances.
Also, in trying to find this bug, I spotted
a situation in the flex input, where, in passing
back a 'word' to the parser, it would allocate
a buffer larger than necessary. I changed the
usage in such situations, so that strdup was
not used, but rather, an ast_malloc, followed
by ast_copy_string.
I removed a field from the pval struct, in
u2, that was never getting used, and set in
one spot in the code. I believe it was an
artifact of a previous fix to make switch
cases work invisibly with extens.
And, for goto's I removed a '!' from
before a strcmp, that has been there
since the initial merging of AEL2, that
might prevent the proper target of a
goto from being found. This was pretty
harmless on its own, as it would just
louse up a consistency check for users.
Many thanks to ckjohnsonme for providing
a simplified and complete set of information
about the bug, that helped considerably in
finding and fixing the problem.
Now, to get aelparse up and running again
in trunk, and out of its "horribly broken" state,
so I can run the regression suite!
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@162013 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
The previous code carried over group settings from the old channel to the new
one. However, it did nothing with the group settings that were already on the
new channel. This patch removes all group settings that already existed on the
new channel.
I have a more complicated version of this patch which addresses only the most
blatant problem with this, which is that a channel can end up with multiple
group settings in the same category. However, I could not think of a use case
for keeping any of the group settings from the old channel, so I went this route
for now.
(closes AST-152)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@161948 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
(closes issue #13474)
Reported by: mmaguire
Patches:
20080912_bug13474.diff uploaded by mmaguire (license 571)
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@161725 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r161421 | seanbright | 2008-12-05 15:50:23 -0500 (Fri, 05 Dec 2008) | 8 lines
Fix build errors on FreeBSD (uint -> unsigned int).
(closes issue #14006)
Reported by: alphaque
Patches:
astobj2.h-patch uploaded by alphaque (license 259)
(Slightly modified by seanbright)
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@161426 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@161354 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@161287 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
Reported by: matt_b
Tested by: jpeeler
This mirrors a check that was present in ast_rtp_read to also be in ast_rtp_raw_write to not schedule sending the receiver report if the remote RTCP endpoint address isn't present in the RTCP structure.
Closes AST-142.
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@161013 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
following: "name <number>" (including the quotation marks), then the parts
would be parsed as
name: "name
number: number
This is because the closing quotation mark was not discovered since the number
and everything after was parsed out of the string earlier. Now, there is a check
to see if the closing quote occurs after the number, so that we can know if we
should strip off the opening quote on the name.
Closes AST-158
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@160943 f38db490-d61c-443f-a65b-d21fe96a405b
|
|
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@160770 f38db490-d61c-443f-a65b-d21fe96a405b
|