aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-01-20Update ChangeLog and .version fileslmadsen2-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23@169572 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Creating tag for release of asterisk-1.4.23lmadsen936-0/+474597
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23@169571 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Creating tag for the asterisk-1.4.23 releaselmadsen933-452595/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23@169569 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Creating tag for the release of asterisk-1.4.23lmadsen0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23@169567 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-20Don't play audio to the channel if we've masqueradedtwilson1-12/+12
(closes issue #14066) Reported by: bluefox Tested by: otherwiseguy, bluefox git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@169485 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-19Truncate userevents at the end of a line, when the command exceeds the buffer.tilghman2-5/+14
(closes issue #14278) Reported by: fnordian git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@169364 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-19Prevent a crash in chan_local due to a potential NULL pointer dereferencemmichelson1-4/+4
Move the check for if both channels on a local_pvt have generators to below where p->chan is checked for NULLity (NULLness?). This prevents a crash from occurring if p->chan is NULL. (closes issue #14189) Reported by: sascha Patches: 14189.patch uploaded by putnopvut (license 60) Tested by: sascha git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@169210 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Account for possible NULL pointer when we receive a 408 in response to a ↵mmichelson1-1/+5
REGISTER It may be that by the time we receive a reply to a REGISTER request, the attempt has timed out and thus the registry structure pointed to by the corresponding sip_pvt has gone away. This situation was handled properly for a 200 OK response, but the 408 case assumed that the sip_registry struct was non-NULL, thus potentially causing a crash This commit fixes this assumption and prints out a message to the console if we should receive a late 408 response to a REGISTER (closes issue #14211) Reported by: aborghi Patches: 14211.diff uploaded by putnopvut (license 60) Tested by: aborghi git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168975 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Fix the conjugation of Russian and Ukrainian languages.tilghman3-148/+211
(related to issue #12475) Reported by: chappell Patches: vm_multilang.patch uploaded by chappell (license 8) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168828 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Use autotagged externalsrussell0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc4@168757 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Importing files for 1.4.23-rc4 releaserussell3-0/+22078
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc4@168756 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Creating tag for the release of asterisk-1.4.23-rc4russell933-0/+452519
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc4@168755 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16Creating taglmadsen0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc4@168752 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-16This patch fixes a problem where a goto (or jump, in this case)murf1-0/+1
fails a consistency check because it can't find a matching extension. The problem was a missing instruction to end the range notation in the code where it converts the pattern into a regex and uses the regex code to determine the match. I tested using the AEL code the user supplied, and now, the consistency check passes. (closes issue #14141) Reported by: dimas git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168745 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Meetme actually has realtime but wasn't documentedoej1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168721 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Convert call to park_call_full to masq_park_call_announcetwilson1-8/+9
Since we removed the AST_PBX_KEEPALIVE return value, we need to use masqueraded parking, otherwise we will try to call ast_hangup() in __pbx_run() and in do_parking_thread() and then promptly crash. (closes issue #14215) Reported by: waverly360 Tested by: otherwiseguy (closes issue #14228) Reported by: kobaz Tested by: otherwiseguy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168716 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Blocked revision 168632 from /branches/1.2:tilghman0-0/+0
1.2 regression on security fix AST-2009-001 (Closes issue #14238) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168633 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-15Fix some crashes from bad datastore handling in app_queue.cmmichelson1-5/+10
* The queue_transfer_fixup function was searching for and removing the datastore from the incorrect channel, so this was fixed. * Most datastore operations regarding the queue_transfer datastore were being done without the channel locked, so proper channel locking was added, too. (closes issue #14086) Reported by: ZX81 Patches: 14086v2.patch uploaded by putnopvut (license 60) Tested by: ZX81, festr git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168628 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14* Fixed create_process() allocation of process ID values.rmudgett1-44/+40
The allocated process IDs could overflow their respective NT and TE fields. Affects outgoing calls. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168622 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Update autosupport script to supply info for both Zaptel and DAHDI in 1.4 andseanbright1-7/+25
be sure to run dahdi_test in 1.6.x and trunk instead of zttest. (closes issue #14132) Reported by: dsedivec Patches: asterisk-1.4-autosupport.patch uploaded by dsedivec (license 638) asterisk-trunk-autosupport.patch uploaded by dsedivec (license 638) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168614 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14app_page was failing to compile in dev-mode on my gcc-4.2.4 system. This ↵murf1-1/+1
change gets rid of the warning. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168608 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Don't read into a buffer without first checking if a value is beyond the end.tilghman1-5/+3
(closes issue #13600) Reported by: atis Patches: 20090106__bug13600.diff.txt uploaded by Corydon76 (license 14) Tested by: atis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168603 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Fix a logic error I found while searching through chan_agent.cmmichelson1-3/+5
I found that the allow_multiple_logins function would never return 0 due to an incorrect comparison being used when traversing the list of agents. While I was modifying this function, I also did a little bit of coding guidelines cleanup, too. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168598 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-14Don't overflow when paging more than 128 extensionstwilson1-5/+19
The number of available slots for calls in app_page was hardcoded to 128. Proper bounds checking was not in place to enforce this limit, so if more than 128 extensions were passed to the Page() app, Asterisk would crash. This patch instead dynamically allocates memory for the ast_dial structures and removes the (non-functional) arbitrary limit. This issue would have special importance to anyone who is dynamically creating the argument passed to the Page application and allowing more than 128 extensions to be added by an outside user via some external interface. The patch posted by a_villacis was slightly modified for some coding guidelines and other cleanups. Thanks, a_villacis! (closes issue #14217) Reported by: a_villacis Patches: 20080912-asterisk-app_page-fix-buffer-overflow.patch uploaded by a (license 660) Tested by: otherwiseguy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168593 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Revert unnecessary indications API change from rev 122314russell11-72/+72
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168561 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13Don't pass a value with a side effect to a macrotwilson1-1/+3
(closes issue #14176) Reported by: paraeco Patches: chan_sip.c.diff uploaded by paraeco (license 658) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168551 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-13If either conditional is NULL, don't try copying it.tilghman1-1/+1
(closes issue #14226) Reported by: caspy Patches: 20090113__bug14226.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168546 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12(closes issue #13881)jpeeler1-0/+5
Reported by: hoowa Update the app CDR field for AGI commands that are not executing an application via "exec". git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168516 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12(closes issue #12269)jpeeler1-19/+28
Reported by: IgorG Tested by: denisgalvao This gits rid of the notion of an owning_app allowing the request and hangup to be initiated by different threads. Originating from an active agent channel requires this. The implementation primarily changes __login_exec to wait on a condition variable rather than a lock. Review: http://reviewboard.digium.com/r/35/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168507 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12I am reverting the fix made in revision 168128 (and its upward merges)mmichelson1-5/+1
after being contacted by Olle Johansson and being shown how this fix is incorrect. Thanks to Olle for clearing this up for me. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168482 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-12s/ringdance/ringcadence/ for Bulgariarussell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168480 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-10small commit to test new serverkpfleming1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168382 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-10small commit to test new serverkpfleming1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168379 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-09update to use new sound file packages that include license fileskpfleming1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168267 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-09Make this compile for mvanbaakrussell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168198 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-09* Fix for JIRA AST-175/ABE-1757rmudgett1-22/+222
* Miscellaneous doxygen comments added. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168191 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-09Add check_via calls to more request handlersmmichelson1-1/+5
INFO, NOTIFY, OPTIONS, REFER, and MESSAGE requests were not checking the topmost Via to determine where to send the response. Adding check_via calls to those request handlers solves this. (closes issue #13071) Reported by: baron Patches: check_via.patch uploaded by baron (license 531) Tested by: baron git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@168128 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-08Don't truncate database results at 255 chars.tilghman1-3/+22
(closes issue #14069) Reported by: evandro Patches: 20081214__bug14069.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167840 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-08remove an unnecessary argument to queue_request()kpfleming1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167714 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-07When a SIP request or response arrives for a dialog with an associated ↵kpfleming1-14/+115
Asterisk channel, and the lock on that channel cannot be obtained because it is held by another thread, instead of dropping the request/response, queue it for later processing when the channel lock becomes available. http://reviewboard.digium.com/r/117/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167620 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-07Fix the last couple of places where free() was improperly used directly.russell1-7/+8
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167566 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-07Don't fclose() the file early, the filestream destructor will handle it.russell1-1/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167554 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-07Only try to close the file if one was actually openedrussell1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167545 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-07Don't use free() directly. This caused a crash since ast_filestream is now ↵russell1-1/+1
an ao2 object. Reported by JunK-Y on IRC, #asterisk-dev git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167541 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-07Treat an empty string the same way as a NULL country argument.russell1-7/+4
In passing, simplify the handling of returning a default tone zone. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167432 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-06Use the correct variable when creating the format stringmmichelson1-1/+1
(closes issue #14177) Reported by: nic_bellamy Patches: asterisk-trunk-svn-r167242-ast_db_gettree.patch uploaded by nic (license 299) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167299 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-06Merged revisions 167259 via svnmerge from tilghman1-4/+16
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r167259 | tilghman | 2009-01-06 14:44:03 -0600 (Tue, 06 Jan 2009) | 2 lines Security fix AST-2009-001. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167260 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-05A couple of changes to T.38 SDP attribute handlingmmichelson1-28/+48
There are some boolean attributes for T.38 such as T38FaxFillBitRemoval, T38FaxTranscodingMMR, and T38FaxTranscodingJBIG. By simply being present, we should treat these as a "true" value. The current code, however, was requiring a 1 or 0 as the value of the attribute in order to parse it. This is due to the fact that there are some T.38 endpoints and gateways that also transmit this information incorrectly. This patch follows the "be liberal in what you accept and strict in what you send" philosophy by accepting both the correctly- and incorrectly-formatted attributes, but only sending information as it is supposed to be sent. It was also discovered that a particular type of T.38 gateway sends some non-standard T.38 SDP attributes. Instead of using T38FaxMaxDatagram and T38MaxBitRate, it used T38MaxDatagram and T38FaxMaxRate respectively. We now will properly accept these attributes as well. Note that there are a lot of patches cited in the below commit message template. This is because the person who submitted these patches is an awesome person and wrote 1.4, 1.6.0, and 1.6.1 variants. (closes issue #13976) Reported by: linulin Patches: chan_sip.c.1.4-update1.diff uploaded by arcivanov (license 648) chan_sip.c.1.6.0-update1.diff uploaded by arcivanov (license 648) chan_sip.c.1.6.1-update1.diff uploaded by arcivanov (license 648) chan_sip.c.1.4-relaxedT38_update1.diff uploaded by arcivanov (license 648) chan_sip.c.1.6.0-relaxedT38_update1.diff uploaded by arcivanov (license 648) chan_sip.c.1.6.1-relaxedT38_update1.diff uploaded by arcivanov (license 648) Tested by: arcivanov git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167179 f38db490-d61c-443f-a65b-d21fe96a405b
2009-01-01Repeat attempts to write when we receive -EAGAIN from the driver, as detailedtilghman1-3/+9
in the ALSA sample code (see http://www.alsa-project.org/alsa-doc/alsa-lib/_2test_2pcm_8c-example.html#a32) Reported by: Jerry Geis (via the -users list) Fixed by: me (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@167095 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-31Also inherit the musiconhold class.tilghman1-0/+1
(Closes #14153) Reported by: Jerry Geis, via the users list. Patch by: me (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@166953 f38db490-d61c-443f-a65b-d21fe96a405b