AgeCommit message (Collapse)AuthorFilesLines
2009-08-18git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.22-rc4@212958 ↵v1.4.22-rc4kpfleming8-20/+19
2008-09-08Use autotagged externalsrussell0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.22-rc4@141744 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-08Importing files for 1.4.22-rc4 releaserussell3-0/+20097
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.22-rc4@141743 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-08Creating tag for the release of asterisk-1.4.22-rc4russell0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.22-rc4@141742 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-08Remove RPM package targets from Makefile (and all associated parts).qwell4-160/+0
This has never worked in 1.4, and we decided that it makes no sense to be done here. There are many distros out there that already have "proper" spec files that can be (re)used. Closes issue #13113 Closes issue #10950 Closes issue #10952 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141741 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-08Actually use Zaptel CFLAGS if using Zaptel instead of DAHDIrussell2-1/+9
This fixes building against Zaptel when using a custom path git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141678 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-06This fix comes from Joshua Colp The Brilliant, who, given the trace, came up ↵murf1-0/+2
with a solution. This will most likely will close 13235 and 13409. I'll wait till Monday to verify, and then close these bugs. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141565 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-06Reverting behavior change (AGI should not exit non-zero on SUCCESS)tilghman1-1/+1
(closes issue #13434) Reported by: francesco_r git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141503 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-05Agent's should not try to call a channel's indicate callbackmmichelson1-1/+1
if the channel has been hung up. It will likely crash otherwise ABE-1159 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141366 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-05Since greetings are not stored in IMAP, we shouldmmichelson1-1/+9
not be DISPOSE'ing of them the same way we do with other messages. (closes issue #13414) Reported by: mthomasslo Patches: 13414v2.patch uploaded by putnopvut (license 60) Tested by: mthomasslo git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141267 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-05Commit 140417 had a logic flaw in it whichmmichelson1-3/+3
caused port 5060 to always be used when dialing a peer if no explicit port was specified. This broke the behavior of implicitly using the port from which the peer registered if no port is specified. This commit fixes the logic flaw. (closes issue #13424) Reported by: mdu113 Patches: 13424.patch uploaded by putnopvut (license 60) Tested by: mdu113 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141217 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-05A small change to prevent double-posting of CDR's; thanks to Daniel Ferrer ↵murf1-1/+1
for bringing it to our attention git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141156 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-04(closes issue #13357)murf5-442/+876
Reported by: pj Tested by: murf (closes issue #13416) Reported by: yarns Tested by: murf If you find this message overly verbose, relax, it's probably not meant for you. This message is meant for probably only two people in the whole world: me, or the poor schnook that has to maintain this code because I'm either dead or unavailable at the moment. This fix solves two reports, both having to do with embedding a function call in a ${} construct. It was tricky because the funccall syntax has parenthesis () in it. And up till now, the 'word' token in the flex stuff didn't allow that, because it would tend to steal the LP and RP tokens. To be truthful, the "word" token was the trickiest, most unstable thing in the whole lexer. I was lucky it made this long without complaints. I had to choose every character in the pattern with extreme care, and I knew that someday I'd have to revisit it. Well, the day has come. So, my brilliant idea (and I'm being modest), was to use the surrounding ${} construct to make a state machine and capture everything in it, no matter what it contains. But, I have to now treat the word token like I did with comments, in that I turn the whole thing into a state-machine sort of spec, with new contexts "curlystate", "wordstate", and "brackstate". Wait a minute, "brackstate"? Yes, well, it didn't take very many regression tests to point out if I do this for ${} constructs, I also have to do it with the $[] constructs, too. I had to create a separate pcbstack2 and pcbstack3 because these constructs can occur inside macro argument lists, and when we have two state machines operating on the same structures we'd get problems otherwise. I guess I could have stopped at pcbstack2 and had the brackstate stuff share it, but it doesn't hurt to be safe. So, the pcbpush and pcbpop routines also now have versions for "2" and "3". I had to add the {KEYWORD} construct to the initial pattern for "word", because previously word would match stuff like "default7", because it was a longer match than the keyword "default". But, not any more, because the word pattern only matches only one or two characters now, and it will always lose. So, I made it the winner again by making an optional match on any of the keywords before it's normal pattern. I added another regression test to make sure we don't lose this in future edits, and had to fix just one regression, where it no longer reports a 'cascaded' error, which I guess is a plus. I've given some thought as to whether to apply these fixes to 1.4 and the 1.6.x releases, vs trunk; I decided to put it in 1.4 because one of the bug reports was against 1.4; and it is unexpected that AEL cannot handle this situation. It actually reduced the amount of useless "cascade" error messages that appeared in the regressions (by one line, ehhem). There is a possible side-effect in that it does now do more careful checking of what's in those ${} constructs, as far as matching parens, and brackets are concerned. Some users may find a an insidious problem and correct it this way. This should be exceedingly rare, I hope. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141094 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-04(closes issue #11979)jpeeler2-5/+12
Fixes multiple parking problems: Crash when executing a park on an extension dialed by AGI due to not returning the proper return code. Crash when using a builtin feature that was a subset of a enabled dynamic feature. Crash due to always hanging up the peer despite the fact that the peer was supposed to be parked. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@141028 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-03Fix voicemail forwarding when using ODBC storage.mmichelson1-2/+13
(closes issue #13387) Reported by: moliveras Patches: 13387.patch uploaded by putnopvut (license 60) Tested by: putnopvut, moliveras git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140850 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-03Don't freak out if the poll emulation receives NULL for the pollfds arrayrussell1-5/+5
(closes issue #13307) Reported by: jcovert git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140816 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-02After adding the context checking to app_voicemailmmichelson1-0/+1
for IMAP storage, I left out a crucial place to copy the context to the vm_state structure. This is the correction. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140751 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-02I am turning the warnings generated in ast_cdr_free and post_cdr into ↵murf1-10/+10
verbose level 2 messages. Really, they matter little to end users. You either get the CDR's you wanted, or you don't, and it is a bug. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140747 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-02After reconsidering, with respect to 13409, ast_cdr_detach should be OK, ↵murf1-1/+1
better in fact, than ast_cdr_free, which generates lots of useless warnings that will undoubtably generate complaints. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140690 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-02(closes issue #13409)murf2-0/+7
Reported by: tomaso Patches: asterisk-1.6.0-rc2-cdrmemleak.patch uploaded by tomaso (license 564) I basically spent the day, verifying that this patch solves the problem, and doesn't hurt in non-problem cases. Why valgrind did not plainly reveal this leak absolutely mystifies and stuns me. Many, many thanks to tomaso for finding and providing the fix. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140670 f38db490-d61c-443f-a65b-d21fe96a405b
2008-09-02Make sure to use the correct length of the mohinterpret and mohsuggestseanbright1-2/+2
buffers when copying configuration values. (closes issue #13336) Reported by: decryptus_proformatique Patches: chan_iax2_mohinterpret_mohsuggest_general_settings.patch uploaded by decryptus (license 555) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140605 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-29After working on the ao2_containers branch, I noticedmmichelson3-5/+5
something a bit strange. In all cases where we provide a callback function to ao2_container_alloc, the callback function would only return 0 or CMP_MATCH. After inspecting the ao2_callback() code carefully, I found that if you're only looking for one specific item, then you should return CMP_MATCH | CMP_STOP. Otherwise, astobj2 will continue traversing the current bucket until the end searching for more matches. In cases like chan_iax2 where in 1.4, all the peers are shoved into a single bucket, this makes for potentially terrible performance since the entire bucket will be traversed even if the peer is one of the first ones come across in the bucket. All the changes I have made were for cases where the callback function defined was passed to ao2_container_alloc so that calls to ao2_find could find a unique instance of whatever object was being stored in the container. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140488 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-29Add context checking when retrieving a vm_state.mmichelson1-12/+15
This was causing a problem for people who had identically named mailboxes in separate voicemail contexts. This commit affects IMAP storage only. (closes issue #13194) Reported by: moliveras Patches: 13194.patch uploaded by putnopvut (license 60) Tested by: putnopvut, moliveras git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140421 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-29Fix SIP's parsing so that if a port is specifiedmmichelson1-1/+5
in a string to Dial(), it is not ignored. (closes issue #13355) Reported by: acunningham Patches: 13355v2.patch uploaded by putnopvut (license 60) Tested by: acunningham git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140417 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-27Fix tag checking in get_sip_pvt_byid_locked whenmmichelson1-8/+17
in pedantic mode. The problem was that the wrong tags would be compared depending on the direction of the call. (closes issue #13353) Reported by: flefoll Patches: chan_sip.c.br14.139015.patch-refer-pedantic uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140299 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-26add HAVE_PRI if define around dahdi_close_pri_fdjpeeler1-1/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140115 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-26Fix some bogus scheduler usage in chan_sip. This code used the return valuerussell1-5/+9
of a completely unrelated function to determine whether the scheduler should be run or not. This would have caused the scheduler to not run in cases where it should have. Also, leave a note about another scheduler issue that needs to be addressed at some point. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140060 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-26(closes issue #12071)jpeeler1-58/+31
Reported by: tzafrir Patches: dahdi_close.diff uploaded by tzafrir (license 46) Tested by: tzafrir, jpeeler This patch fixes closing open file descriptors in the case of an error. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140056 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-26Fix a race condition with the IAX scheduler thread. A lock and condition arerussell1-3/+2
used here to allow newly scheduled tasks to wake up the scheduler just in case the new task needs to run sooner than the current wakeup time when the thread is sleeping. However, there was a race condition such that a newly scheduled task would not properly wake up the scheduler or affect the wake up period. The order of execution would have been: 1) Scheduler thread determines wake up time of N ms. 2) Another thread schedules a task and signals the condition, with an execution time of < N ms. 3) Scheduler thread locks and goes to sleep for N ms. By moving the sleep time determination to inside the critical section, this possibility is avoided. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140051 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-26sounds/Makefile installs sounds using the "new" language directory ↵twilson1-2/+2
structure, but languageprefix needs to be set = yes for sounds in subdirectories (digits/1, etc.) to play as the correct language. Fix the generation of asterisk.conf to include languageprefix=yes git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140050 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-26correct a file location in an error messagekpfleming1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@140029 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-25Fix a typo I made. Lesson learned, apply the patch if one exists.jpeeler1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139927 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-25Some versions of awk (nawk, for example) don't like empty regular expressionsseanbright2-2/+2
so be slightly more verbose. (closes issue #13374) Reported by: dougm Patches: 13374.diff uploaded by seanbright (license 71) Tested by: dougm git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139909 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-25Make SIPADDHEADER() propagate indefinitelytwilson1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139869 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-25Fix the logic in config_text_file_save so that if anmmichelson1-3/+5
UpdateConfig manager action is issued and the file specified in DstFileName does not yet exist, an error is not returned. (closes issue #13341) Reported by: vadim Patches: 13341.patch uploaded by putnopvut (license 60) (with small modification from seanbright) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139769 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-25This patch reverts the changes made via 139347, and 139635, as usersmurf2-48/+0
are seeing adverse difference. I will un-close 13251. Back to the drawing board/ concept/ beginning/ whatever! git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139764 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-22I found some problems with the code I committed earlier, whenmurf1-0/+8
I merged them into trunk, so I'm coming back to clean up. And, in the process, I found an error in the code I added to trunk and 1.6.x, that I'll fix using this patch also. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139635 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-22(closes issue #13359)jpeeler1-1/+1
Reported by: Laureano Patches: originate_channel_check.patch uploaded by Laureano (license 265) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139621 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-22Fix compilation when DEBUG_THREAD_LOCALS is selectedmmichelson1-1/+1
(closes issue #13298) Reported by: snuffy Patches: bug13298_20080822.diff uploaded by snuffy (license 35) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139553 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-22Remove show_frame_stats_deprecated since it is notmmichelson1-17/+0
used anywhere and causes build errors if building under dev-mode with TRACE_FRAMES selected in menuselect. (closes issue #13362) Reported by: snuffy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139521 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-22Fix the build. Thanks, mvanbaak!mmichelson1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139466 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-22Prevent a deadlock in chan_iax2 resulting frommmichelson1-1/+4
incorrect locking order between iax2_pvt and ast_channel structures. AST-13 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139456 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-21Fixes loop that could possibly never exit in the event of a channel never ↵jpeeler1-1/+3
being able to be opened or specify after a restart. (closes issue #11017) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139387 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-21(closes issue #13251)murf2-0/+40
Reported by: sergee Tested by: murf THis is a bold move for a static release fix, but I wouldn't have made it if I didn't feel confident (at least a *bit* confident) that it wouldn't mess everyone up. The reasoning goes something like this: 1. We simply cannot do anything with CDR's at the current point (in pbx.c, after the __ast_pbx_run loop). It's way too late to have any affect on the CDRs. The CDR is already posted and gone, and the remnants have been cleared. 2. I was very much afraid that moving the running of the 'h' extension down into the bridge code (where it would be now practical to do it), would result in a lot more calls to the 'h' exten, so I implemented it as another exten under another name, but found, to my pleasant surprise, that there was a 1:1 correspondence to the running of the 'h' exten in the pbx_run loop, and the new spot at the end of the bridge. So, I ifdef'd out the current 'h' loop, and moved it into the bridge code. The only difference I can see is the stuff about the AST_PBX_KEEPALIVE, and hopefully, if this is still an important decision point, I can replicate it if there are complaints. To be perfectly honest, the KEEPALIVE situation is not totally clear to me, and how it relates to a post-bridge situation is less clear. I suspect the users will point out everything in total clarity if this steps on anyone's toes! 3. I temporarily swap the bridge_cdr into the channel before running the 'h' exten, which makes it possible for users to edit the cdr before it goes out the door. And, of course, with the endbeforehexten config var set, the users can also get at the billsec/duration vals. After the h exten finishes, the cdr is swapped back and processing continues as normal. Please, all who deal with CDR's, please test this version of Asterisk, and file bug reports as appropriate! git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139347 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-21Apply fix for issue #13310 to branch 1.4, too.phsultan1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139283 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-20Fix a crash in the ChanSpy application. The issue here is that if you callrussell1-2/+2
ChanSpy and specify a spy group, and sit in the application long enough looping through the channel list, you will eventually run out of stack space and the application with exit with a seg fault. The backtrace was always inside of a harmless snprintf() call, so it was tricky to track down. However, it turned out that the call to snprintf() was just the biggest stack consumer in this code path, so it would always be the first one to hit the boundary. (closes issue #13338) Reported by: ruddy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139213 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-20Fix bug where the samples were not accurate when in G723 mode, which would sruffell1-6/+16
cause the timestamp field of the RTP header to be invalid. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139151 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-20Backport support for Zaptel/DAHDI channel-level alarms from trunk/1.6, ↵kpfleming4-4/+147
because not doing so just makes it difficult for people with channels that are in alarm when Asterisk starts up to get them going once the alarm is cleared (closes issue #12160) Reported by: tzafrir Patches: asterisk-chanalarms_14.patch uploaded by tzafrir (license 46) Tested by: tzafrir git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139145 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-20(closes issue #13263)murf1-4/+7
Reported by: brainy Tested by: murf The specialized reset routine is tromping on the flags field of the CDR. I made a change to not reset the DISABLED bit. This should get rid of this problem. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139074 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-20sip_read should properly handle a NULL return from sip_rtp_read.mmichelson1-1/+1
(closes issue #13257) Reported by: travishein git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@139015 f38db490-d61c-443f-a65b-d21fe96a405b