aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-08-06We only need to unregister the QueueStatus managermmichelson1-1/+0
command once on an unload git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136238 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06-C option takes a filename, not a directory path.tilghman1-1/+1
(closes issue #13007) Reported by: klaus3000 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136190 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Remove the use of --no-print-directory when compiling subdirectories.russell1-2/+2
This allows vim :make functionality to work properly when errors have occurred in the build. Without printing the directories, vim did not know how to find the file that the error occurred in. If the extra bit of build noise annoys anyone, just let me know, and I'll make this optional. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136168 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Since adding the AST_CONTROL_SRCUPDATE frame type,mmichelson2-4/+4
there are places where ast_rtp_new_source may be called where the tech_pvt of a channel may not yet have an rtp structure allocated. This caused a crash in chan_skinny, which was fixed earlier, but now the same crash has been reported against chan_h323 as well. It seems that the best solution is to modify ast_rtp_new_source to not attempt to set the marker bit if the rtp structure passed in is NULL. This change to ast_rtp_new_source also allows the removal of what is now a redundant pointer check from chan_skinny. (closes issue #13247) Reported by: pj git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@136062 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Fix a longstanding bug in channel walking logic, and fix the explanation totilghman1-10/+13
make sense. (Closes issue #13124) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135949 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Since powerof() can return an error condition, it's foolhardy not to detect andtilghman1-1/+14
deal with that condition. (Related to issue #13240) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135915 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-061) Bugfix for debugging codetilghman2-2/+2
2) Reduce compiler warnings for another section of debugging code (Closes issue #13237) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135899 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Remove properties that should not be heremmichelson0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135850 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Revert inadvertent changes to app_skel that occurred whenmmichelson1-14/+15
I was testing for a memory leak git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135847 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-06Merging the issue11259 branch.mmichelson5-24/+75
The purpose of this branch was to take into account "burps" which could cause jitterbuffers to misbehave. One such example is if the L option to Dial() were used to inject audio into a bridged conversation at regular intervals. Since the audio here was not passed through the jitterbuffer, it would cause a gap in the jitterbuffer's timestamps which would cause a frames to be dropped for a brief period. Now ast_generic_bridge will empty and reset the jitterbuffer each time it is called. This causes injected audio to be handled properly. ast_generic_bridge also will empty and reset the jitterbuffer if it receives an AST_CONTROL_SRCUPDATE frame since the change in audio source could negatively affect the jitterbuffer. All of this was made possible by adding a new public API call to the abstract_jb called ast_jb_empty_and_reset. (closes issue #11259) Reported by: plack Tested by: putnopvut git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135841 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-05(closes issue #12982)murf5-11/+50
Reported by: bcnit Tested by: murf I discovered that also, in the previous bug fixes and changes, the cdr.conf 'unanswered' option is not being obeyed, so I fixed this. And, yes, there are two 'answer' times involved in this scenario, and I would agree with you, that the first answer time is the time that should appear in the CDR. (the second 'answer' time is the time that the bridge was begun). I made the necessary adjustments, recording the first answer time into the peer cdr, and then using that to override the bridge cdr's value. To get the 'unanswered' CDRs to appear, I purposely output them, using the dial cmd to mark them as DIALED (with a new flag), and outputting them if they bear that flag, and you are in the right mode. I also corrected one small mention of the Zap device to equally consider the dahdi device. I heavily tested 10-sec-wait macros in dial, and without the macro call; I tested hangups while the macro was running vs. letting the macro complete and the bridge form. Looks OK. Removed all the instrumentation and debug. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135799 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-05In a conversion to use ast_strlen_zero, the meaning of the flag IAX_HASCALLERIDtilghman1-19/+6
was perverted. This change reverts IAX2 to the original meaning, which was, that the callerid set on the client should be overridden on the server, even if that means the resulting callerid is blank. In other words, if you set "callerid=" in the IAX config, then the callerid should be overridden to blank, even if set on the client. Note that there's a distinction, even on realtime, between the field not existing (NULL in databases) and the field existing, but set to blank (override callerid to blank). git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135747 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-05Use PATH_MAX for filenamesseanbright1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135597 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-04fix a config sample typorussell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135536 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-04Define ASTSBINDIR for scripttilghman1-0/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135482 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-04Memory leak on unloadtilghman1-10/+21
(closes issue #13231) Reported by: eliel Patches: app_voicemail.leak.patch uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135479 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-04Add a minor clarification to the documentation of mohinterpret and mohsuggestrussell1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135473 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-01make app_ices compile on OpenBSD.mvanbaak1-6/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135058 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-01fix some potential deadlocks in chan_skinnymvanbaak1-0/+4
(closes issue #13215) Reported by: qwell Patches: 2008080100_bug13215.diff.txt uploaded by mvanbaak (license 7) Tested by: mvanbaak git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@135055 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-31accomodate users who seem to lack a sense of humor :-)kpfleming1-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134983 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-31Specify codecs in callfiles and manager, to allow video calls to be set uptilghman3-6/+22
from callfiles and AMI. (closes issue #9531) Reported by: Geisj Patches: 20080715__bug9531__1.4.diff.txt uploaded by Corydon76 (license 14) 20080715__bug9531__1.6.0.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134976 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-31Get app_ices working againrussell1-12/+22
(closes issue #12981) Reported by: dlogan Patches: 20080709__app_ices_v2_update_trunk.diff uploaded by bbryant (license 36) 20080709__app_ices_v2_update_14.diff uploaded by bbryant (license 36) Tested by: bbryant git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134915 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-31(closes issue #11849)murf1-5/+14
Reported by: greyvoip Tested by: murf OK, a few days of debugging, a bunch of instrumentation in chan_sip, main/channel.c, main/pbx.c, etc. and 5 solid notebook pages of notes later, I have made the small tweek necc. to get the start time right on the second CDR when: A Calls B B answ. A hits Xfer button on sip phone, A dials C and hits the OK button, A hangs up C answers ringing phone B and C converse B and/or C hangs up But does not harm the scenario where: A Calls B B answ. B hits xfer button on sip phone, B dials C and hits the OK button, B hangs up C answers ringing phone A and C converse A and/or C hangs up The difference in start times on the second CDR is because of a Masquerade on the B channel when the xfer number is sent. It ends up replacing the CDR on the B channel with a duplicate, which ends up getting tossed out. We keep a pointer to the first CDR, and update *that* after the bridge closes. But, only if the CDR has changed. I hope this change is specific enough not to muck up any current CDR-based apps. In my defence, I assert that the previous information was wrong, and this change fixes it, and possibly other similar scenarios. I wonder if I should be doing the same thing for the channel, as I did for the peer, but I can't think of a scenario this might affect. I leave it, then, as an exersize for the users, to find the scenario where the chan's CDR changes and loses the proper start time. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134883 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-31In case we have some processing threads that free more frames than they ↵russell1-8/+19
allocate, do not let the frame cache grow forever. (closes issue #13160) Reported by: tavius Tested by: tavius, russell git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134814 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-31Add more timeout checks into app_queue, specificallymmichelson1-1/+43
targeting areas where an unknown and potentially long time has just elapsed. Also added a check to try_calling() to return early if the timeout has elapsed instead of potentially setting a negative timeout for the call (thus making it have *no* timeout at all). (closes issue #13186) Reported by: miquel_cabrespina Patches: 13186.diff uploaded by putnopvut (license 60) Tested by: miquel_cabrespina git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134758 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30Oops, wrong definetilghman2-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134704 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30(closes issue #13197)murf1-2/+7
Reported by: pj (closes issue #13051) Reported by: pj This patch substitutes commas in the expr supplied to the if () statement, as in if ( expr ) ... This solves both the bugs above, and makes the source symmetric with switch statements, which were earlier reported to need this sort of treatment. I tested this using the examples, both for the compiler and at run time. Looks good. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134652 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30Qwell pointed out, via IRC, that the previous fix only worked when explicitlytilghman2-3/+3
set. When nothing is set, and the option is implied, it breaks, because configure sets the prefix to 'NONE'. Fixing. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134649 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30Reduce stack consumption by 12.5% of the max stack size to fix a crash whenrussell1-34/+55
compiled with LOW_MEMORY. (closes issue #13154) Reported by: edantie git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134595 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30Fix a memory leak in func_curl. Every thread that used this function leakedrussell1-0/+2
an allocation the size of a pointer. (reported by jmls in #asterisk-dev) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134540 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30Only override sysconfdir and mandir when prefix=/usrtilghman2-11/+15
(closes issue #13093) Reported by: pabelanger git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134536 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30launch_netscript sometimes returns -1, which fails to set AGISTATUS. Maptilghman1-1/+1
failure to -1, so that AGISTATUS is always set. (closes issue #13199) Reported by: smw1218 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134480 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30Fix a spot where a function could return without bringingmmichelson1-1/+5
a channel out of autoservice. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134475 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-30use the proper method for building version.hkpfleming1-2/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134352 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-29build against the now-typedef-free dahdi/user.hkpfleming8-62/+60
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134254 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-29Merging the imap_consistency branch.mmichelson1-1553/+1223
The main aim of this branch was to make the IMAP code function in the same manner as the ODBC code does, eliminating the need for so many IMAP-specific code chunks. The focal point of all of this work was to make the various macros (e.g. RETRIEVE, DISPOSE) functionally equivalent. While doing the above work, I also fixed a few bugs that I came across in my testing. Among these were 1. Fixed message forwarding. This was completely broken when using IMAP. 2. Fixed the inability to save new messages as old and vice versa. 3. Fixed the "delete" options in voicemail.conf when using IMAP storage. Even though a few bugs were fixed and the code is a lot more consistent, the one thing that was *not* improved in this branch was performance. The merge of this to trunk may not come immediately due to the amount of work it will probably involve. (closes issue #12764) Reported by: balsamcn git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134223 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-28Detect when sox fails to raise the volume, because sox can't read the file.tilghman1-4/+11
(closes issue #12939) Reported by: rickbradley Patches: 20080728__bug12939.diff.txt uploaded by Corydon76 (license 14) Tested by: rickbradley git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@134161 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-26Add the licensing section to the docs in 1.4, as well, so that we can work onrussell2-8/+32
having an accurate list for each version of Asterisk that is supported git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133980 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-25Remove unnecessary mmap flagtilghman1-1/+1
(Closes issue #13161) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133709 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-25Fix some errant device states by making the devicestate API more strict intilghman3-28/+22
terms of the device argument (only without the unique identifier appended). (closes issue #12771) Reported by: davidw Patches: 20080717__bug12771.diff.txt uploaded by Corydon76 (license 14) Tested by: davidw, jvandal, murf git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133649 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-25Merged revisions 133577 via svnmerge from russell1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r133577 | russell | 2008-07-25 10:00:13 -0500 (Fri, 25 Jul 2008) | 2 lines Fix the IAX2 URI for calling Digium ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133578 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-25We need to make sure to null-terminate the "name"mmichelson1-0/+2
portion of SIP URI parameters so that there are no bogus comparisons. Thanks to bbryant for pointing this out. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133572 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-24Fix rtautoclear and rtcachefriendstilghman1-5/+11
(Closes issue #12707) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133488 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-24Blocked revisions 133360 via svnmergetilghman0-0/+0
........ r133360 | tilghman | 2008-07-23 22:46:01 -0500 (Wed, 23 Jul 2008) | 2 lines This part was not correctly patched for AST-2008-010. ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133361 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-23inbandrelease is gone - it's now inbanddisconnectqwell1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133295 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-23revert an optimization that broke ABI... thanks russell!kpfleming2-47/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133237 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-23make some more changes to the dahdi/zap channel name support stuff to ensure ↵kpfleming6-29/+28
allthe globals are 'const', and clean up mmichelson's changes to app_chanspy to simplify the code git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133226 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-23As suggested by seanbright, the PSEUDO_CHAN_LEN in mmichelson4-7/+17
app_chanspy should be set at load time, not at compile time, since dahdi_chan_name is determined at load time. Also changed the next_unique_id_to_use to have the static qualifier. Also added the dahdi_chan_name_len variable so that strlen(dahdi_chan_name) isn't necessary. Thanks to seanbright for the suggestion. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133169 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-23Zap/pseudo is ten characters, but DAHDI/pseudo ismmichelson1-1/+10
twelve. The strncmp call in next_channel should account for this. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133104 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-23Update the "last" channel in next_channel in app_chanspy sommichelson1-0/+1
that the same pseudo channel isn't constantly returned. related to issue #13124 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@133101 f38db490-d61c-443f-a65b-d21fe96a405b