aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-03-03It is possible for no audio to pass between the current digit and next digit ↵file1-1/+8
so expand logic that clears emulation to AST_FRAME_NULL. (closes issue #11911) Reported by: edgreenberg Patches: v1-11911.patch uploaded by dimas (license 88) Tested by: tbsky git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105560 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Add a comment to describe some logic.file1-0/+1
(closes issue #12120) Reported by: flefoll Patches: chan_sip.c.br14.patch-just-a-comment uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105557 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Fix a major bug in autoservice. There was a race condition in the handling ofrussell1-0/+18
the list of channels in autoservice. The problem was that it was possible for a channel to get removed from autoservice and destroyed, while the autoservice thread was still messing with the channel. This led to memory corruption, and caused crashes. This explains multiple backtraces I have seen that have references to autoservice, but do to the nature of the issue (memory corruption), could cause crashes in a number of areas. (fixes the crash in BE-386) (closes issue #11694) (closes issue #11940) The following issues could be related. If you are the reporter of one of these, please update to include this fix and try again. (potentially fixes issue #11189) (potentially fixes issue #12107) (potentially fixes issue #11573) (potentially fixes issue #12008) (potentially fixes issue #11189) (potentially fixes issue #11993) (potentially fixes issue #11791) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105409 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Fix a potential memory leakphsultan1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105326 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29If the message file does not exist, just return harmlessly, instead of crashing.tilghman1-1/+3
(Closes issue #12108) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105296 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Bump up the size of the uniqueid variable.file1-1/+1
(closes issue #12107) Reported by: asgaroth git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105261 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Automatically create new buddy upon reception of a presence stanza ofphsultan1-19/+12
type subscribed. (closes issue #12066) Reported by: ffadaie Patches: branch-1.4-12066-1.diff uploaded by phsultan (license 73) trunk-12066-1.diff uploaded by phsultan (license 73) Tested by: ffadaie, phsultan git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105209 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Fix a bug in the lock tracking code that was discovered by mmichelson. The ↵russell2-14/+18
issue is that if the lock history array was full, then the functions to mark a lock as acquired or not would adjust the stats for whatever lock is at the end of the array, which may not be itself. So, do a sanity check to make sure that we're updating lock info for the proper lock. (This explains the bizarre stats on lock #63 in BE-396, thanks Mark!) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105116 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Update init script for LSB compattilghman1-22/+23
(closes issue #9843) Reported by: ibc Patches: rc.debian.asterisk.patch uploaded by ibc (license 211) Tested by: paravoid git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105113 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28When using autofill, members who are in use should be counted towards the mmichelson1-0/+4
number of available members to call if ringinuse is set to yes. Thanks to jmls who brought this issue up on IRC git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105059 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Make pbx_exec pass an empty string into applications, if we get NULL.qwell2-8/+4
This protects against possible segfaults in applications that may try to use data before checking length (ast_strdupa'ing it, for example) (closes issue #12100) Reported by: foxfire Patches: 12100-nullappargs.diff uploaded by qwell (license 4) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105005 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28According to a video at www.cisco.com, the 7921G supports 6 line appearances.qwell1-1/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104920 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Compatibility fix for PPC64tilghman2-2/+11
(closes issue #12081) Reported by: jcollie Patches: asterisk-1.4.18-funcdesc.patch uploaded by jcollie (license 412) Tested by: jcollie, Corydon76 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104868 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Two fixes:mmichelson1-5/+31
1. Make the list of ast_dial_channels a lockable list. This is because in some cases, the ast_dial may exist in multiple threads due to asynchronous execution of its application, and I found some cases where race conditions could exist. 2. Check in ast_dial_join to be sure that the channel still exists before attempting to lock it, since it could have gotten hung up but the is_running_app flag on the ast_dial_channel may not have been cleared yet. (closes issue #12038) Reported by: jvandal Patches: 12038v2.patch uploaded by putnopvut (license 60) Tested by: jvandal git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104841 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Don't loop around infinitely trying to spy on our own channel, and don't ↵file1-5/+5
forget to free/detach the datastore upon hangup of the spy. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104787 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Bump a couple of more buffers up by 2 so that annoying warnings aren't generatedmmichelson1-2/+2
like crazy on every fileexists_core call. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104783 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Ensure the session ID can't be 0.tilghman1-1/+6
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104704 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Bump up the buffer by 2.file1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104665 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Fix a problem in ChanSpy where it could get stuck in an infinite loop withoutrussell1-1/+7
being able to detect that the calling channel hung up. (closes issue #12076, reported by junky, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104625 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Inherit language from the transfering channel on a blind transfer.qwell1-3/+4
(closes issue #11682) Reported by: caio1982 Patches: local_atxfer_lang3-1.4.diff uploaded by caio1982 (license 22) Tested by: caio1982, victoryure git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104598 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Use the lock (which already existed, it just wasn't used) on the updaters ↵file1-6/+6
list to protect the contents instead of the overall module list lock. (closes issue #12080) Reported by: ChaseVenters git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104596 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27fallback to standard English prompts properly when using new prompt ↵kpfleming1-14/+22
directory layout (closes issue #11831) Reported by: IgorG Patches: fallbacken.v1.diff uploaded by IgorG (license 20) (modified by me to improve code and conform rest of function to coding guidelines) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104593 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27When we receive a known alarm, make sure that the unknown alarm flag is not ↵russell1-0/+4
still set to make sure that when we come back out of alarm, it gets reported in the log and manager interface (after discussion with tzafrir on the -dev list) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104591 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Only stop the MWI monitor thread if it was actually started.file1-1/+3
(closes issue #12086) Reported by: francesco_r git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104536 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Avoid some recursion in the cleanup code for the chanspy datastorerussell1-0/+2
(closes issue #12076, reported by junky, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104334 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-27Zaptel 1.4 now exposes FXO battery state as an alarm. However, Asterisk 1.4russell1-16/+47
does not know what to do with these alarms. Only Asterisk 1.6 cares about it. So, if we get an unknown alarm in chan_zap, don't generate confusing log messages about it. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104332 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26Add badshell to .PHONY target (thanks Kevin)qwell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104141 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26Since all shells aren't as awesome as bash, we have to fail if somebody ↵qwell1-1/+8
tries to use a literal "~" in DESTDIR. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104139 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26Revert previous abspath change.qwell1-2/+2
...abspath is new in GNU make 3.81. I feel so...defeated. Must find new fix! git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104135 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26Fix a very bizarre issue we were seeing with our buildbot when using a ↵qwell1-2/+2
DESTDIR that wasn't an absolute path (such as DESTDIR=~/asterisk-1.4). Apparently what was happening, was that some of the targets were being expanded to the full path, so $@ ended up being /root/asterisk-1.4/[...]/ rather than ~/asterisk-1.4/[...]/ It appears that this may be a new "feature" in GNU make. (*cough* http://en.wikipedia.org/wiki/Principle_of_least_surprise *cough*) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104132 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26Merge changes from team/russell/smdi-1.4russell5-329/+979
This commit brings in a significant set of changes to the SMDI support in Asterisk. There were a number of bugs in the current implementation, most notably being that it was very likely on busy systems to pop off the wrong message from the SMDI message queue. So, this set of changes fixes the issues discovered as well as introducing some new ways to use the SMDI support which are required to avoid the bugs with grabbing the wrong message off of the queue. This code introduces a new interface to SMDI, with two dialplan functions. First, you get an SMDI message in the dialplan using SMDI_MSG_RETRIEVE() and then you access details in the message using the SMDI_MSG() function. A side benefit of this is that it now supports more than just chan_zap. For example, with this implementation, you can have some FXO lines being terminated on a SIP gateway, but the SMDI link in Asterisk. Another issue with the current implementation is that it is quite common that the station ID that comes in on the SMDI link is not necessarily the same as the Asterisk voicemail box. There are now additional directives in the smdi.conf configuration file which let you map SMDI station IDs to Asterisk voicemail boxes. Yet another issue with the current SMDI support was related to MWI reporting over the SMDI link. The current code could only report a MWI change when the change was made by someone calling into voicemail. If the change was made by some other entity (such as with IMAP storage, or with a web interface of some kind), then the MWI change would never be sent. The SMDI module can now poll for MWI changes if configured to do so. This work was inspired by and primarily done for the University of Pennsylvania. (also related to issue #9260) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104119 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-26IPTOS_MINCOST is not defined on Solaris.qwell1-1/+1
(closes issue #12050) Reported by: asgaroth Patches: 12050.patch uploaded by putnopvut (license 60) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104111 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25This patch fixes some pretty significant problems with how app_chanspy handlesrussell1-32/+178
pointers to channels that are being spied upon. It was very likely that a crash would occur if the channel being spied upon hung up. This was because the current ast_channel handling _requires_ that the object is locked or else it could disappear at any time (except in the owning channel thread). So, this patch uses some channel datastore magic on the spied upon channel to be able to detect if and when the channel goes away. (closes issue #11877) (patch written by me, but thanks to kpfleming for the idea, and to file for review) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104106 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Improve the lock tracking code a bit so that a bunch of old locks that threadsrussell1-1/+10
failed to lock don't sit around in the history. When a lock is first locked, this checks to see if the last lock in the list was one that was failed to be locked. If it is, then that was a lock that we're no longer sitting in a trylock loop trying to lock, so just remove it. (inspired by issue #11712) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104102 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Make it so a users.conf user creates both a SIP peer and a SIP user. The ↵file1-5/+11
user will be used for inbound authentication for the device, and peer will be used for placing calls to the device. (closes issue #9044) Reported by: queuetue Patches: sip-gui-friend.diff uploaded by qwell (license 4) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104095 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25If the destination folder is full, don't delete a message when exiting.tilghman1-2/+4
(closes issue #12065) Reported by: selsky Patch by: (myself) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104094 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Allow the use of #include and #exec in situations where the max include ↵qwell1-1/+2
depth was only 1. Specifically, this fixes using #include and #exec in extconfig.conf. This was basically caused because the config file itself raises the include level to 1. I opted not to raise the include limit, because recursion here could cause very bizarre behavior. Pointed out, and tested by jmls (closes issue #12064) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104092 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Ensure that the channel doesn't disappear in agent_logoff(). If it does, itrussell1-2/+21
could cause a crash. (fixes the crash reported in BE-396) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104086 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25If a resubscription comes in for a dialog we no longer know about tell the ↵file1-0/+12
remote side that the dialog does not exist so they subscribe again using a new dialog. (closes issue #10727) Reported by: s0l4rb03 Patches: 10727-2.diff uploaded by file (license 11) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104084 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25Due to recent changes tag will no longer be NULL if not present so we have ↵file1-1/+1
to use ast_strlen_zero to see if it's actually blank. (closes issue #12061) Reported by: flefoll Patches: chan_sip.c.br14.patch_pedantic_no_totag uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104082 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-22Backwards debug message.tilghman1-2/+2
(closes issue #12052) Reported by: flefoll Patches: chan_sip.c.br14.patch_found-notfound uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104037 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-21And as a followup to revision 104026, completely remove event-relatedmmichelson1-4/+0
calls from a section of code where we know there was no event to handle or get. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104027 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-21Remove an incorrect debug message. It reported that it had received a ↵mmichelson1-2/+0
specific event and tried to report which event was received. What actually was happening was that it was reporting the number of bytes returned from a call to read(). Thanks to Jared Smith for bringing the issue up on IRC git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104026 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-21reduce the likelihood that HTTP Manager session ids will consist of ↵kpfleming1-1/+1
primarily '1' bits git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104015 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-20Clear up confusion when viewing the QUEUE_WAITING_COUNT of a mmichelson1-0/+8
"dead" realtime queue. Since from the user's perspective, the queue does exist, we shouldn't tell them we couldn't find the queue. Instead since it is a dead queue, report a 0 waiting count This issue was brought up on IRC by jmls git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103956 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-20Don't wait for additional digits when overlap dialing is enabled if the ↵file1-1/+1
setup message contains the sending_complete information element. (closes issue #11785) Reported by: klaus3000 Patches: sending_complete_overlap_asterisk-1.4.17.patch.txt uploaded by klaus3000 (license 65) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103953 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-20Fix a crash if the channel becomes NULL while attempting to lock it.mmichelson1-3/+5
(closes issue #12039) Reported by: danpwi git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103904 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-20Compat fix for Solaristilghman1-0/+2
(closes issue #12022) Reported by: asgaroth Patches: 20080219__bug12022.diff.txt uploaded by Corydon76 (license 14) Tested by: asgaroth git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103845 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-19Send CallerID Name in setup message.file1-2/+3
(closes issue #11241) Reported by: tusar Patches: h323id_as_callerid_name.patch uploaded by tusar (license 344) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103823 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-19Account for the fact that the "other" channel can disappear while the local pvtrussell1-13/+11
is not locked. (fixes a problem introduced in rev 100581) (closes issue #12012) Reported by: stevedavies Patch by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@103821 f38db490-d61c-443f-a65b-d21fe96a405b