aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2009-09-01Fix memory corruption caused by format_mp3.russell1-12/+1
format_mp3 claimed that it provided AST_FRIENDLY_OFFSET in frames returned by read(). However, it lied. This means that other parts of the code that attempted to make use of the offset buffer would end up corrupting the fields in the ast_filestream structure. This resulted in quite a few crashes due to unexpected values for fields in ast_filestream. This patch closes out quite a few bugs. However, some of these bugs have been open for a while and have been an area where more than one bug has been discussed. So with that said, anyone that is following one of the issues closed here, if you still have a problem, please open a new bug report for the specific problem you are still having. If you do, please ensure that the bug report is based on the newest version of Asterisk, and that this patch is applied if format_mp3 is in use. Thanks! (closes issue #15109) Reported by: jvandal Tested by: aragon, russell, zerohalo, marhbere, rgj (closes issue #14958) Reported by: aragon (closes issue #15123) Reported by: axisinternet (closes issue #15041) Reported by: maxnuv (closes issue #15396) Reported by: aragon (closes issue #15195) Reported by: amorsen Tested by: amorsen (closes issue #15781) Reported by: jensvb (closes issue #15735) Reported by: thom4fun (closes issue #15460) Reported by: marhbere git-svn-id: http://svn.digium.com/svn/asterisk/trunk@215212 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-01Ensure that frame dumps of AST_CONTROL_T38_PARAMETERS frames are properlykpfleming1-1/+1
decoded. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@215161 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-01Removing whitespace that causes red dots in reviewboardoej1-561/+561
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@215110 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-31Fix a trunk compilation warning.tilghman1-2/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@215070 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-31Properly initialize the session to prevent a crash.tilghman1-1/+1
(closes issue #15774) Reported by: lasko Patches: 20090831__issue15774.diff.txt uploaded by tilghman (license 14) Tested by: lasko git-svn-id: http://svn.digium.com/svn/asterisk/trunk@215069 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-31By copying this code I got bad comments in reviewboard... Better fix the ↵oej1-1/+1
original. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@215023 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-31Merged revisions 214940 via svnmerge from tilghman1-0/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214940 | tilghman | 2009-08-31 11:16:52 -0500 (Mon, 31 Aug 2009) | 7 lines Also unlock the "other" channel, when returning, due to glare. (closes issue #15787) Reported by: tim_ringenbach Patches: chan_local.diff uploaded by tim ringenbach (license 540) Tested by: tim_ringenbach ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214945 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-30Force Darwin on ppc platforms to compile with a target level that supports ↵tilghman1-1/+1
aliasing. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214898 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-30Various patches, to enable Asterisk to once again compile on Mac OS X.tilghman2-0/+8
One note on defining _POSIX_C_SOURCE: while this feature test macro works to require certain behaviors on Linux, it works differently on *BSD platforms to REMOVE certain API calls that are not in the POSIX specification, such as vasprintf(3). Thus, defining it while depending upon vasprintf (and other extensions to the POSIX standard) to be defined is a recipe to ensure that Asterisk is only buildable on Linux. Hence, this define which was meant to INCREASE portability, effectively ensures the opposite. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214863 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-30If lua is detected with the lua5.1 prefix (or not), adjust the include path ↵tilghman4-10061/+9324
accordingly. Based upon feedback to a release announcement on the -users list. See http://lists.digium.com/pipermail/asterisk-users/2009-August/236954.html git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214819 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-28Update configure script so that CONFIG_CFLAGS and CONFIG_LDFLAGS doesn't ↵russell1-9271/+10051
break the build. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214777 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-28Merged revisions 214701 via svnmerge from tilghman1-4/+4
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214701 | tilghman | 2009-08-28 15:13:32 -0500 (Fri, 28 Aug 2009) | 8 lines Modify comment to be a bit more accurate. We have kept this comment around long enough, that it's pretty clear that we're keeping the code, because changing the code would require a pretty fundamental architectural shift. We've also taken criticism in some quarters, because it was believed that it was referring to the code being nasty. No, the code isn't nasty, just the operation itself is rather odd. Fixed for eternity (probably not). ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214702 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-28Ensure that CFLAGS and/or LDFLAGS provided to configure script are preserved.kpfleming4-32/+36
Cross-compilation environments want to provide 'defaults' for compiler and linker options, and frequently do this by specifying CFLAGS and LDFLAGS in the environment or as command-line arguments to the configure script. This patch modifies the configure script and Makefile to preserve these settings and ensure they are used in the build process. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214696 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-28Move discardremoteholdretrieval test so it applies only to the specific ↵rmudgett1-7/+13
notification indicator values. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214654 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-28Fix some incorrect documentation of sched_thread functions.mmichelson1-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214650 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-28Remove unnecessary define for Solaristilghman1-3/+0
(closes issue #15358) Reported by: snuffy Patches: bug_res_moh_remove_unneeded_include.diff uploaded by snuffy (license 35) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214611 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Merged revisions 214517 via svnmerge from tilghman4-106/+700
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214517 | tilghman | 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) | 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue #15714) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214518 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Ensure that we check for the special value CONFIG_STATUS_FILEINVALID.tilghman1-5/+17
(closes issue #15786) Reported by: a_villacis Patches: asterisk-1.6.2.0-beta4-manager-fix-crash-on-include-nonexistent-file.patch uploaded by a villacis (license 660) (Plus a few of my own, to catch the remaining places within manager.c where it could have been a problem) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214514 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Merged revisions 214436 via svnmerge from tilghman4-13746/+930
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214436 | tilghman | 2009-08-27 11:53:58 -0500 (Thu, 27 Aug 2009) | 2 lines One more build system change, to make the descriptions look better, if we have better information. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214466 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Merged revisions 214357 via svnmerge from tilghman3-421/+1216
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214357 | tilghman | 2009-08-27 11:03:50 -0500 (Thu, 27 Aug 2009) | 3 lines Make autoheader descriptions render correctly in our autoconfig.h file. (Figured out while working with issue #14906) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214360 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Add forgotten documentation for new channel variables added in 214309.jpeeler1-0/+3
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214355 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-26Add two new dialplan variables when using featuresjpeeler2-0/+13
Added DYNAMIC_FEATURENAME which holds the last triggered dynamic feature. Added DYNAMIC_PEERNAME which holds the unique channel name on the other side and is set when a dynamic feature is triggered. (closes issue #14663) Reported by: tamiel Patches: 20090313_features.diff uploaded by tamiel (license 712) Tested by: tamiel git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214309 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-26Minor punctuation change.rmudgett1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214272 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-26Typo fix ("SIP/2.0 XXX" is 11 chars, not 10)tilghman1-1/+1
(closes issue #15362) Reported by: klaus3000 Patches: chan_sip.c_logmessagefix_patch.txt uploaded by klaus3000 (license 65) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214199 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-26Merged revisions 214194 via svnmerge from dvossel1-2/+25
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214194 | dvossel | 2009-08-26 11:36:42 -0500 (Wed, 26 Aug 2009) | 19 lines ast_write() ignores ast_audiohook_write() results In ast_write(), if a channel has a list of audiohooks, those lists are written to and the resulting frame is what ast_write() should continue with. The problem was the returned audiohook frame was not being handled at all, and the original frame passed into it did not contain the mixed audio, so essentially audio was being lost. One result of this was chan_spy's whisper mode no longer worked. To complicate the issue, frames passed into ast_write may either be a single frame, or a list of frames. So, as the list of frames is processed in the audiohook_write, the returned frames had to be added to a new list. (closes issue #15660) Reported by: corruptor Tested by: dvossel ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214195 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-25Not all versions of gnu-linux use glibc, which contains iconv. Some ↵tilghman3-12932/+12019
(especially embedded systems) don't have iconv at all. (closes issue #15169) Reported by: pprindeville git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214152 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-25Merged revisions 214068-214069 via svnmerge from tilghman1-8/+17
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214068 | tilghman | 2009-08-25 14:26:50 -0500 (Tue, 25 Aug 2009) | 6 lines Fix pronunciation of German dates. (closes issue #15273) Reported by: Benjamin Kluck Patches: say_c.patch uploaded by Benjamin Kluck (license 803) ........ r214069 | tilghman | 2009-08-25 14:28:42 -0500 (Tue, 25 Aug 2009) | 2 lines I should always compile before committing... ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214071 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-25DUNDILOOKUP function in 1.6 should use comma delimiters.tilghman1-25/+26
(closes issue #15322) Reported by: chappell Patches: dundilookup-0015322.patch uploaded by chappell (license 8) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213975 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-25Merged revisions 213970 via svnmerge from tilghman1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213970 | tilghman | 2009-08-25 01:34:44 -0500 (Tue, 25 Aug 2009) | 7 lines Improve error message by informing user exactly which function is missing a parethesis. (closes issue #15242) Reported by: Nick_Lewis Patches: pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790) pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213971 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-25The DTD should be installed in the same path as the rest of the XML ↵tilghman1-1/+1
documentation. (closes issue #15344) Reported by: tzafrir Patches: makefile_appdocs_dtd.diff uploaded by tzafrir (license 46) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213904 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-25Merged revisions 213899 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213899 | tilghman | 2009-08-24 21:40:22 -0500 (Mon, 24 Aug 2009) | 4 lines Use the default runlevels for Debian derivatives, instead of making up our own. (closes issue #14730) Reported by: pkempgen ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213900 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-24Fix storage of greetings when using IMAP_STORAGEjpeeler1-5/+8
The store macro was not getting called preventing storage of IMAP greetings at all. This has been corrected along with fixing checking if the imapgreetings option is turned on to store the greeting in IMAP. Lastly, the attachment filename was incorrectly using the full path instead of just the basename, which was causing problems with retrieval of the greeting. (closes issue #14950) Reported by: noahisaac (closes issue #15729) Reported by: lmadsen git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213833 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-24improve handling of openr2_chan_disconnect_call API failure, unlikely, but ↵moy1-8/+22
happened on openr2 library bug git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213790 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Update configure script for libpri COLP feature dependency requirements.rmudgett3-15/+14
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213748 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Clarifying comments in sip_register, and removing a dead sectiontilghman1-7/+19
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213738 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Register request line contains wrong address when user domain and register ↵dvossel1-4/+3
host differ (closes issue #15539) Reported by: Nick_Lewis Patches: chan_sip.c-registraraddr.patch uploaded by Nick (license 657) register_domain_fix_1.6.2 uploaded by dvossel (license 671) Tested by: Nick_Lewis, dvossel git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213716 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Ensure that realtime mailboxes properly report status on subscription.kpfleming1-13/+18
This patch modifies app_voicemail's response to mailbox status subscriptions (via the internal event system) to ensure that a subscription triggers an explicit poll of the mailbox, so the subscriber can get an immediate cached event with that status. Previously, the cache was only populated with the status of non-realtime mailboxes. (closes issue #15717) Reported by: natmlt git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213697 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21fixes sip register parsing when user@domain is useddvossel1-13/+30
(issue #15008) (issue #15672) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213635 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Blocked revisions 213631 via svnmergekpfleming0-0/+0
........ r213631 | kpfleming | 2009-08-21 15:23:45 -0500 (Fri, 21 Aug 2009) | 8 lines Ensure that T.38 INVITEs generated by Asterisk properly result in T.38 being enabled. (closes issue #15373) Reported by: dcolombo Patches: chan_sip.patch uploaded by mbrancaleoni (license 342) Tested by: dcolombo, mbrancaleoni ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213632 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Merged revisions 213559 via svnmerge from tilghman1-0/+6
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213559 | tilghman | 2009-08-21 11:52:53 -0500 (Fri, 21 Aug 2009) | 7 lines Permit DEBUG_FD_LEAKS to be used with C++ source files. (closes issue #15698) Reported by: slavon Patches: 20090817__issue15698.diff.txt uploaded by tilghman (license 14) Tested by: slavon, tilghman ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213560 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Merged revisions 213493 via svnmerge from qwell1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213493 | qwell | 2009-08-21 11:03:21 -0500 (Fri, 21 Aug 2009) | 5 lines Clarify queues.conf comments to specify that variables should be set in the dialplan. (closes issue #15755) Reported by: trendboy ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213494 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21increment the mfcr2 monitor count when clearing the call requestmoy1-0/+5
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213454 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Make LOAD_ORDER actually worktwilson1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213450 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Add original position, when logging a caller entering a queue.tilghman1-2/+2
(closes issue #15146) Reported by: arabe Patches: asterisk-trunk.patch uploaded by arabe (license 786) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213414 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Fix greeting retrieval from IMAPjpeeler1-4/+15
Properly check for the current voicemail state and if it doesn't exist, create it. (closes issue #14597) Reported by: wtca Patches: 14597_v2.patch uploaded by mmichelson (license 60) Tested by: jpeeler git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213404 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Blocked revisions 213339 via svnmergemnicholson0-0/+0
........ r213339 | mnicholson | 2009-08-20 15:33:07 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue #15751) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213340 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Fix a crash by checking the proper pointer for validity before deferencing it.mnicholson1-1/+1
(closes issue #15751) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213327 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Merged revisions 213283 via svnmerge from jpeeler1-0/+20
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213283 | jpeeler | 2009-08-20 14:53:34 -0500 (Thu, 20 Aug 2009) | 2 lines Make all the symbols for the C-client callbacks global ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213284 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20Select uncommented lines, not commented ones.tilghman1-1/+1
(closes issue #15746) Reported by: makoto git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213248 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-20fixed bug caused by calling ast_request without calling ast_call on an R2 ↵moy1-1/+8
channel, ie, CHANISAVAIL git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213216 f38db490-d61c-443f-a65b-d21fe96a405b
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 10:40:13 +0000