aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-03-11fix various other problems found by gcc 4.3kpfleming3-11/+7
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107464 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11stop checking for mktime() in the configure script... we don't use it, and ↵kpfleming4-524/+151
the test is buggy under gcc 4.3 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107461 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11check for compiler support for -fno-strict-overflow before using it (tested ↵kpfleming4-4/+30
with Debian's gcc 4.3, 4.1 and 3.4) (closes issue #12179) Reported by: Netview git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107408 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11fix small bug in IMAP toolkit testingkpfleming2-3/+3
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107405 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11fix up various compiler warnings found with gcc-4.3:kpfleming5-6/+12
- the output of flex includes a static function called 'input' that is not used, so for the moment we'll stop having the compiler tell us about unused variables in the flex source files (a better fix would be to improve our flex post-processing to remove the unused function) - main/stdtime/localtime.c makes assumptions about signed integer overflow, and gcc-4.3's improved optimizer tries to take advantage of handling potential overflow conditions at compile time; for now, suppress these optimizations until we can fiure out if the code needs improvement - main/udptl.c has some references to uninitialized variables; in one case there was no bug, but in the other it was certainly possibly for unexpected behavior to occur - main/editline/readline.c had an unused variable git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107352 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11If we fail to alloc a channel, we should re-lock the pvt structure before ↵twilson1-0/+1
returning. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107290 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Use non-global storage for eswitchtilghman1-11/+12
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107230 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Make sure to reenable echo can after a "failed" (canceled, etc) three-way call.qwell1-0/+1
(closes issue #11335) Reported by: rebuild git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107173 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Fix another bug specifically related to asynchronous call origination. Once therussell1-1/+1
PBX is started on the channel using ast_pbx_start(), then the ownership of the channel has been passed on to another thread. We can no longer access it in this code. If the channel gets hung up very quickly, it is possible that we could access a channel that has been free'd. (inspired by BE-386) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107161 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Fix some bugs related to originating calls. If the code failed to start a PBXrussell1-1/+8
on the channel (such as if you set a call limit based on the system's load average), then there were cases where a channel that has already been free'd using ast_hangup() got accessed. This caused weird memory corruption and crashes to occur. (fixes issue BE-386) (much debugging credit goes to twilson, final patch written by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107158 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Resolve a compiler warning.russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107102 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Fix a race condition where the generator can go awayrussell1-1/+5
(closes issue #12175, reported by edantie, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107099 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-10Move where unanswered CDRs are dropped to the CDR core, not everything uses ↵file3-25/+6
app_dial. (closes issue #11516) Reported by: ys Patches: branch_1.4_cdr.diff uploaded by ys (license 281) Tested by: anest, jcapp, dartvader git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@107016 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-08don't generate D-Channel "up" and "down" messages unless the channel state ↵kpfleming1-7/+13
is actually changing; also, generate the "up" message when an implicit "up" occurs due to reception of a normal event when we thought the channel was "down" git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106945 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Only start the SLA thread if SLA has actually been configured.russell1-1/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106895 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Fix hardcoded grep in editline, were GNU grep is required.qwell1-1/+1
(closes issue #12124) Reported by: dmartin git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106842 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Ignore source update control frame.file1-0/+1
(closes issue #12168) Reported by: plack git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106788 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Change a warning message to a debug message. This is happening quite ↵russell1-1/+1
frequently, and it is not worth spamming users with these messages unless we are pretty confident that it should never happen. As it stands today, it _will_ and _does_ happen and until that gets cleaned up a reasonable amount on the development side, let's not spam the logs of everyone else. (closes issue #12154) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106704 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Warn the user when a temporary greeting existstilghman1-1/+5
(Closes issue #11409) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106635 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Properly initialize rtp->schedidtilghman1-0/+1
(Closes issue #12154) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106606 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-07Safely use the strncat() function.tilghman10-27/+23
(closes issue #11958) Reported by: norman Patches: 20080209__bug11958.diff.txt uploaded by Corydon76 (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106552 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-06Quell an annoying message that is likely to print every single time that mmichelson1-3/+1
ast_pbx_outgoing_app is called. The reason is that __ast_request_and_dial allocates the cdr for the channel, so it should be expected that the channel will have a cdr on it. Thanks to joetester on IRC for pointing this out git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106437 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-06Upgrade to the next release of soundstilghman1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106328 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Fix a potential deadlock and a few different potential crashes.russell1-11/+28
(closes issue #12145, reported by thiagarcia, patched by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106237 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Add a control frame to indicate the source of media has changed. Depending ↵file15-65/+117
on the underlying technology it may need to change some things. (closes issue #12148) Reported by: jcomellas git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106235 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05document var_metric so no bugreports will come in when it's actually a ↵mvanbaak1-0/+14
configuration issue. (issue #12151) Reported and patched by: caio1982 1.4 patch by me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106178 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05when a PRI call must be moved to a different B channel at the request of the ↵kpfleming1-16/+23
other endpoint, ensure that any DSP active on the original channel is moved to the new one (closes issue #11917) Reported by: mavetju Tested by: mavetju git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106038 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Correctly initialize retransid in SIP, and ensure that the warning when ↵tilghman2-1/+2
failing to delete a schedule entry can actually hit the log. (closes issue #12140) Reported by: slavon Patches: sch2.patch uploaded by slavon (license 288) (Patch slightly modified by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@106015 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-05Fix a bug that I just noticed in the RTP code. The calculation for setting therussell3-12/+15
len field in an ast_frame of audio was wrong when G.722 is in use. The len field represents the number of ms of audio that the frame contains. It would have set the value to be twice what it should be. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105932 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-04In addition to setting the marker bit let's change our ssrc so they know for ↵file1-0/+1
sure it is a different source. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105676 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-04When a new source of audio comes in (such as music on hold) make sure the ↵file3-1/+22
marker bit gets set. (closes issue #10355) Reported by: wdecarne Patches: 10355.diff uploaded by file (license 11) (closes issue #11491) Reported by: kanderson git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105674 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-04Backport a minor bug fix from trunk that I found while doing random coderussell1-6/+10
cleanup. Properly break out of the loop when a context isn't found when verify that includes are valid. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105591 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Fix type for astNumChannels.qwell1-1/+1
(closes issue #12114) Reported by: jeffg Patches: 12114.patch uploaded by jeffg (license 192) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105572 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03In the case of an ast_channel allocation failure, take the local_pvt out of therussell1-1/+8
pvt list before destroying it. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105570 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Fix a potential memory leak of the local_pvt struct when ast_channel allocationrussell1-10/+14
fails. Also, in passing, centralize the code necessary to destroy a local_pvt. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105568 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Update the copyright information for autoservice. Most of the code in this filerussell1-1/+3
now is stuff that I have written recently ... git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105565 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Merge in some changes from team/russell/autoservice-nochans-1.4russell4-5/+21
These changes fix up some dubious code that I came across while auditing what happens in the autoservice thread when there are no channels currently in autoservice. 1) Change it so that autoservice thread doesn't keep looping around calling ast_waitfor_n() on 0 channels twice a second. Instead, use a thread condition so that the thread properly goes to sleep and does not wake up until a channel is put into autoservice. This actually fixes an interesting bug, as well. If the autoservice thread is already running (almost always is the case), then when the thread goes from having 0 channels to have 1 channel to autoservice, that channel would have to wait for up to 1/2 of a second to have the first frame read from it. 2) Fix up the code in ast_waitfor_nandfds() for when it gets called with no channels and no fds to poll() on, such as was the case with the previous code for the autoservice thread. In this case, the code would call alloca(0), and pass the result as the first argument to poll(). In this case, the 2nd argument to poll() specified that there were no fds, so this invalid pointer shouldn't actually get dereferenced, but, this code makes it explicit and ensures the pointers are NULL unless we have valid data to put there. (related to issue #12116) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105563 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03It is possible for no audio to pass between the current digit and next digit ↵file1-1/+8
so expand logic that clears emulation to AST_FRAME_NULL. (closes issue #11911) Reported by: edgreenberg Patches: v1-11911.patch uploaded by dimas (license 88) Tested by: tbsky git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105560 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-03Add a comment to describe some logic.file1-0/+1
(closes issue #12120) Reported by: flefoll Patches: chan_sip.c.br14.patch-just-a-comment uploaded by flefoll (license 244) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105557 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Fix a major bug in autoservice. There was a race condition in the handling ofrussell1-0/+18
the list of channels in autoservice. The problem was that it was possible for a channel to get removed from autoservice and destroyed, while the autoservice thread was still messing with the channel. This led to memory corruption, and caused crashes. This explains multiple backtraces I have seen that have references to autoservice, but do to the nature of the issue (memory corruption), could cause crashes in a number of areas. (fixes the crash in BE-386) (closes issue #11694) (closes issue #11940) The following issues could be related. If you are the reporter of one of these, please update to include this fix and try again. (potentially fixes issue #11189) (potentially fixes issue #12107) (potentially fixes issue #11573) (potentially fixes issue #12008) (potentially fixes issue #11189) (potentially fixes issue #11993) (potentially fixes issue #11791) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105409 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Fix a potential memory leakphsultan1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105326 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29If the message file does not exist, just return harmlessly, instead of crashing.tilghman1-1/+3
(Closes issue #12108) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105296 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Bump up the size of the uniqueid variable.file1-1/+1
(closes issue #12107) Reported by: asgaroth git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105261 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29Automatically create new buddy upon reception of a presence stanza ofphsultan1-19/+12
type subscribed. (closes issue #12066) Reported by: ffadaie Patches: branch-1.4-12066-1.diff uploaded by phsultan (license 73) trunk-12066-1.diff uploaded by phsultan (license 73) Tested by: ffadaie, phsultan git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105209 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Fix a bug in the lock tracking code that was discovered by mmichelson. The ↵russell2-14/+18
issue is that if the lock history array was full, then the functions to mark a lock as acquired or not would adjust the stats for whatever lock is at the end of the array, which may not be itself. So, do a sanity check to make sure that we're updating lock info for the proper lock. (This explains the bizarre stats on lock #63 in BE-396, thanks Mark!) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105116 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Update init script for LSB compattilghman1-22/+23
(closes issue #9843) Reported by: ibc Patches: rc.debian.asterisk.patch uploaded by ibc (license 211) Tested by: paravoid git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105113 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28When using autofill, members who are in use should be counted towards the mmichelson1-0/+4
number of available members to call if ringinuse is set to yes. Thanks to jmls who brought this issue up on IRC git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105059 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Make pbx_exec pass an empty string into applications, if we get NULL.qwell2-8/+4
This protects against possible segfaults in applications that may try to use data before checking length (ast_strdupa'ing it, for example) (closes issue #12100) Reported by: foxfire Patches: 12100-nullappargs.diff uploaded by qwell (license 4) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@105005 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28According to a video at www.cisco.com, the 7921G supports 6 line appearances.qwell1-1/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104920 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-28Compatibility fix for PPC64tilghman2-2/+11
(closes issue #12081) Reported by: jcollie Patches: asterisk-1.4.18-funcdesc.patch uploaded by jcollie (license 412) Tested by: jcollie, Corydon76 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@104868 f38db490-d61c-443f-a65b-d21fe96a405b