aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2010-01-25Remove debugging that indeed should have been gone before commit. Sorry.oej1-3/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242851 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Report error when writing to functions returns error in AMI setvar actionoej1-3/+14
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242850 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Buildbot pointed out an error (thanks, buildbot!)tilghman2-8/+8
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242728 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Oops, should have used CMD_PREFIX, not ECHO_PREFIX, for the commands.tilghman2-7/+7
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242723 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Make the build of the Asterisk expression parser match that of the AEL parser.tilghman1-5/+15
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242683 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-24Only rebuild bison and flex source files on demand, if bison and flex are ↵tilghman6-6229/+19441
detected by the configure script. Changed after discussion on the -dev list about possible unnecessary build failures, due to checkouts/untars causing these special source files to possibly be newer than their resulting C files. This should additionally ensure that nobody need learn about extra Makefile arguments to ensure the proper files get rebuilt when changes are made to these special source files. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242520 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-22Rebuild from flex, bison sources when necessary.tilghman1-2/+4
(issue #14629) Reported by: Marquis Patches: 20100121__issue14629.diff.txt uploaded by tilghman (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242423 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-22Initialize notify_types to NULLoej1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242226 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-22Add Dialed Number Identifier (DNID) field to cdr.alecdavis1-0/+1
Branch support, retains ABI, if backend CDR collector is adaptive then database requires 'dnid' field to be added, otherwise no functional changes. Reported by: alecdavis Tested by: alecdavis Patch cdr_dnid.diff2.txt uploaded by alecdavis (license 585) Review: https://reviewboard.asterisk.org/r/455/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@242142 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-21Fix configure check for PTHREAD_ONCE_INIT when manually adding -Wall to CFLAGS.seanbright2-4/+6
(closes issue #16666) Reported by: romain_proformatique git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241932 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-21Guard against division by zero.tilghman1-1/+5
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241765 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-20fixes parsing error in Makefile.dvossel1-5/+5
Some echo lines were missing "; . Thanks to jparker for pointing out the problem. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241626 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-20Modify fix for issue 16554 to be more inline with what is already in trunk.seanbright1-8/+9
I should have taken a closer look at trunk/1.6.x, as this bug has already been fixed in a much more simple manner, by just settings o->vars to NULL after the ast_pbx_outgoing_* calls. (issue #16554) Reported by: mav3rick git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241544 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-20Fix a memory leak in pbx_spool when using SetVar in a call file.seanbright1-7/+10
In pbx_spool, when we are freeing our 'outgoing' struct, we weren't deallocating the ast_variable list we had built from SetVars in a call file. Adding a call to ast_variables_destroy in our deallocation routine works, but only if the variables have not already been passed into ast_pbx_outgoing_app() or _exten(), both of which take care of destroying the variable list for us. (closes issue #16554) Reported by: mav3rick Patches: issue16554_20100119.patch uploaded by seanbright (license 71) Tested by: mav3rick git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241543 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-20Update CDR variables as pbx startsalecdavis1-0/+4
Allows CDR variables added in cdr.c:set_one_cid to become visable during the call, by executing ast_cdr_update() early in __ast_pbx_run. Based on cdr_update.diff3.txt (issue #16638) Reported by: alecdavis Patches: cdr_update.diff3.txt uploaded by alecdavis (license 585) Tested by: alecdavis git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241458 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-19Allow parallel make (-j) to work properly.qwell1-2/+2
1.4 changes are quite different from the others. (issue #16489) Reported by: Chainsaw Tested by: qwell git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241228 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-19Fix deadlock in agent_read by removing call to agent_logoff.jpeeler1-1/+22
One must always lock the agents list lock before the agent private. agent_read locks the private immediately, so locking the agents list lock is not an option (which is what agent_logoff requires). Because agent_read already has access to the agent private all that is necessary is to do the required hanging up that agent_logoff performed. (closes issue #16321) Reported by: valon24 Patches: bug16321.patch uploaded by jpeeler (license 325) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241227 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-18Plug a memory leak when reading configs with their comments.seanbright1-8/+15
While reading through configuration files with the intent of returning their full contents (comments specifically) we allocated some memory and then forgot to free it. This doesn't fix 16554 but clears up a leak I had in the lab. (issue #16554) Reported by: mav3rick Patches: issue16554_20100118.patch uploaded by seanbright (license 71) Tested by: seanbright git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@241015 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-18updated transmit_silence option documentation in asterisk.confdvossel1-1/+5
This patch updates the transmit_silence option to better document why the option exists, and what it affects. Thanks to russell for providing the verbage for this update. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@240891 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-18Fix muted compilation in 1.4 onlyoej1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@240768 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-15Fix a spelling error in the asterisk.conf sample.russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@240547 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-15Disallow leaving more than maxmsg voicemails.tilghman1-5/+72
This is a possibility because our previous method assumed that no messages are left in parallel, which is not a safe assumption. Due to the vmu structure duplication, it was necessary to track in-process messages via a separate structure. If at some point, we switch vmu to an ao2-reference-counted structure, which would eliminate the prior noted duplication of structures, then we could incorporate this new in-process structure directly into vmu. (closes issue #16271) Reported by: sohosys Patches: 20100108__issue16271.diff.txt uploaded by tilghman (license 14) 20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14) 20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14) Tested by: jsutton git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@240414 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-13Fix regression for timed out parked call returning to callerjpeeler1-0/+5
This issue seems to have been exposed by the fix in 160390 whereby using a masquerade prevented a crash. The new channel used in the masquerade was not copying the macro information from the old channel. (closes issue #15459) Reported by: djrodman Patches: patch_15459.txt uploaded by mnick (license ) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@239838 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-13add silence gen to wait appsdvossel4-8/+43
asterisk.conf's 'transmit_silence' option existed before this patch, but was limited to only generating silence while recording and sending DTMF. Now enabling the transmit_silence option generates silence during wait times as well. To achieve this, ast_safe_sleep has been modified to generate silence anytime no other generators are present and transmit_silence is enabled. Wait apps not using ast_safe_sleep now generate silence when transmit_silence is enabled as well. (closes issue 0016524) Reported by: kobaz (closes issue 0016523) Reported by: kobaz Tested by: dvossel Review: https://reviewboard.asterisk.org/r/456/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@239718 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-12Portability and other fixes for the safe_asterisk scripttilghman1-38/+32
(closes issue #16416) Reported by: bklang Patches: safe_asterisk-compat-1.patch uploaded by bklang (license 919) 20100106__issue16416__trunk.diff.txt uploaded by tilghman (license 14) Tested by: bklang git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@239307 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-09-1 is interpreted as an error, intead of the maximum mask.tilghman1-1/+1
(closes issue #16241) Reported by: vnovy Patches: manager.c.patch uploaded by vnovy (license 922) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238915 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-08Stop a crash when no peer is passed to masq_park_call.jpeeler1-1/+1
(distantly related to issue #16406) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238834 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-08Properly calculate the remaining space in the output string when reducing ↵mnicholson1-4/+7
format strings. (closes issue #16560) Reported by: goldwein git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238629 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-07fixes crash in "scheduled_destroy" in chan_iaxdvossel1-1/+1
A signed short was used to represent a callnumber. This is makes it possible to attempt to access the iaxs array with a negative index. (closes issue #16565) Reported by: jensvb git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238411 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-07Change in sip show channels display format allowing more digits for CIDdvossel1-3/+3
(closes issue 0016459) Reported by: Rzadzins Patches: chan_sip_longer_cid.patch uploaded by Rzadzins (license 953) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238409 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-06Revise documentation on disposition values to the actual values used.tilghman1-4/+5
(closes issue #16289) Reported by: wdoekes git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238230 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-06Resolve a crash due to an ast_frame not being fully initialized.russell1-2/+4
(closes issue #16531) Reported by: john8675309 (closes SWP-615) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@238009 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-05Change a NOTICE log message to DEBUG where it belongs.russell1-1/+3
(closes issue #16479) Reported by: alexrecarey (closes SWP-577) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237697 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-04Bounds checking for input stringtilghman1-25/+25
(closes issue #16407) Reported by: qwell Patches: 20100104__issue16407.diff.txt uploaded by tilghman (license 14) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237573 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-04Regression in issue #15421 - Pattern matchingtilghman1-22/+20
(closes issue #16482) Reported by: wdoekes Patches: astsvn-16482-betterfix.diff uploaded by wdoekes (license 717) 20091223__issue16482.diff.txt uploaded by tilghman (license 14) Tested by: wdoekes, tilghman git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237493 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-04Add a flag to disable the Background behavior, for AGI users.tilghman3-2/+17
This is in a section of code that relates to two other issues, namely issue #14011 and issue #14940), one of which was the behavior of Background when called with a context argument that matched the current context. This fix broke FreePBX, however, in a post-Dial situation. Needless to say, this is an extremely difficult collision of several different issues. While the use of an exception flag is ugly, fixing all of the issues linked is rather difficult (although if someone would like to propose a better solution, we're happy to entertain that suggestion). (closes issue #16434) Reported by: rickead2000 Patches: 20091217__issue16434.diff.txt uploaded by tilghman (license 14) 20091222__issue16434__1.6.1.diff.txt uploaded by tilghman (license 14) Tested by: rickead2000 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237405 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-04It's also possible for the Local channel to directly execute an Application.tilghman1-1/+1
Reviewboard: https://reviewboard.asterisk.org/r/452/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237318 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-02Release memory of the contact acl before unloading moduleoej1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@237135 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-30Don't queue frames to channels that have no means to process them.tilghman1-1/+3
(closes issue #15609) Reported by: aragon Patches: 20091230__issue16521__1.4__chan_local_only.diff.txt uploaded by tilghman (license 14) Tested by: aragon Review: https://reviewboard.asterisk.org/r/452/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236981 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-30Remove conflicting function definitions (asterisk.h) so LOW_MEMORY compiles.jpeeler1-18/+0
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236890 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-28Try a test compile to see if PTHREAD_ONCE_INIT requires extra braces.seanbright4-19299/+6277
There was conditional code (based on build platform) to optioinally wrap PTHREAD_ONCE_INIT in braces that was removed since it is fixed in newer versions of Solaris/OpenSolaris, but I am still running into it on Solaris 10 x86 so add a configure-time check for it. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236585 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-28Avoid a crash with large numbers of MeetMe conferences.seanbright1-30/+33
Similar to changes made to Queue(), when we have large numbers of conferences in meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and crash, so instead just use a single fixed buffer. (closes issue #16509) Reported by: Kashif Raza Patches: 20091223_16509.patch uploaded by seanbright (license 71) Tested by: seanbright git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236509 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-27Turn on colors in the daemon, since there's many requests for it on Ubuntu.tilghman1-1/+10
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236433 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-26update to latest releases with zero uid/gidkpfleming1-2/+2
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236357 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-23Properly set T.38 attributes and don't return before T.38 ports are ↵mnicholson1-31/+29
configured when T.38 is found but no audio stream is found. (closes issue #16318) Reported by: bird_of_Luck Patches: t38-sdp-parsing-fix3.diff uploaded by mnicholson (license 96), written by vrban and mnicholson Tested by: vrban, mihaill git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236261 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-23If EXEC only gets a single argument, don't crash when the second is used.tilghman1-1/+1
(closes issue #16504) Reported by: bklang git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236184 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-22fixes issue with p->method incorrectly set to ACKdvossel1-2/+9
It is possible for a second ACK to come in for a retransmitted message. If an ack does not match an unacked message in our queue, restore the previous p->method as this ACK is completely ignored. (closes issue #16295) Reported by: omolenkamp Patches: issue16295_v2.diff uploaded by dvossel (license 671) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@236062 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-21Change Monitor to not assume file to write to does not contain pathing.jpeeler1-2/+2
227944 changed the fname_base argument to always append the configured monitor path. This change was necessary to properly compare files for uniqueness. If a full path is given though, nothing needs to be appended and that is handled correctly now. (closes issue #16377) (closes issue #16376) Reported by: bcnit Patches: res_monitor.c-issue16376-1.patch uploaded by dant (license 670) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@235940 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-21Send parking lot announcement to the channel which parked the call, not the ↵tilghman1-1/+2
park-ee. (closes issue #16234) Reported by: yeshuawatso Patches: 20091210__issue16234.diff.txt uploaded by tilghman (license 14) 20091221__issue16234__1.4.diff.txt uploaded by tilghman (license 14) Tested by: yeshuawatso git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@235821 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-18Revise verbiage, per #asterisk-dev discussiontilghman2-4/+4
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@235652 f38db490-d61c-443f-a65b-d21fe96a405b