aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2008-12-01Use autotagged externalstilghman0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc2@160146 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Importing files for 1.4.23-rc2 releasetilghman3-0/+21080
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc2@160145 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Creating tag for the release of asterisk-1.4.23-rc2tilghman3-21076/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc2@160143 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Use autotagged externalstilghman0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc2@160136 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Importing files for 1.4.23-rc2 releasetilghman3-0/+21076
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc2@160135 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Creating tag for the release of asterisk-1.4.23-rc2tilghman0-0/+0
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.23-rc2@160134 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Apply some logic used in iax2_indicate() to iax2_setoption(), as well, since ↵russell1-12/+42
they both have the potential to send control frames in the middle of call setup. We have to wait until we have received a message back from the remote end before we try to send any more frames. Otherwise, the remote end will consider it invalid, and we'll get stuck in an INVAL/VNAK storm. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@160003 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Get rid of the useless format string and argument in the Bogus/ manager ↵mvanbaak1-1/+1
channelname. Noted by kpfleming and name Bogus/manager suggested by eliel git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159976 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01Force a "make clean" to avoid a bizarre build issue ...russell1-1/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159900 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01make manager compile on OpenBSD.mvanbaak1-1/+1
The last (10th) argument to ast_channel_alloc here should be a pointer and NULL is not really a pointer. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159897 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-29update dev-mode compiler flags to match the ones used by default on Ubuntu ↵kpfleming35-79/+111
Intrepid, so all developers will see the same warnings and errors since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them format attributes in a consistent way git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159808 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-26rename these files so as to avoid conflicts when users update their working ↵kpfleming5-8/+8
copies and have unversioned files already in place git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159571 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-26simplify (and slightly bug-fix) the recent developer-oriented COMPILE_DOUBLE ↵kpfleming7-21/+98
mode add channels/busy.h and channels/ringtone.h to the repository instead of generating them repeatedtly; most users do not change the settings to build them, but the Makefile rules are still there if they wish to do so ensure that 'make clean' removes dependency files for .i files that are created in COMPILE_DOUBLE mode git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159476 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25(closes issue #12694)murf2-0/+10
Reported by: yraber Patches: 12694.2nd.diff uploaded by murf (license 17) Tested by: murf, laurav Thanks to file (Joshua Colp) for his IAX fix. the change to cdr.c allows no-answer to percolate up into CDR's, and feels like the right place to locate this fix; if BUSY is done here, no-answer should be, too. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159316 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25Don't try to send a response on a NULL pvt.tilghman1-1/+1
(closes issue #13919) Reported by: barthpbx Patches: chan_iax2.c.patch uploaded by eliel (license 64) Tested by: barthpbx git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159269 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25Merged revisions 159245 via svnmerge from tilghman1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r159245 | tilghman | 2008-11-25 15:37:06 -0600 (Tue, 25 Nov 2008) | 7 lines Regression fix for last security fix. Set the iseqno correctly. (closes issue #13918) Reported by: ffloimair Patches: 20081119__bug13918.diff.txt uploaded by Corydon76 (license 14) Tested by: ffloimair ........ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159246 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25Add ao2_trylock() to go along with ao2_lock() and ao2_unlock()russell2-0/+34
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159158 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25Add missing variable declaration in the PPC codetwilson1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159096 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25System call ioperm is non-portable, so check for its existence in autoconf.tilghman4-5/+19
(Closes issue #13863) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@159025 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-22(closes issue #13786)jpeeler2-14/+276
Reported by: tzafrir When compiling against Zaptel dahdi_compat will now only define all the DAHDI defines if the Zaptel define is present. Also, there is no such thing as DAHDI_PRI. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158629 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-21In reference to the fix made for 13871, I wasmurf1-9/+14
merging the fix into 1.6.0 and realized I missed the code in the h-exten block, and didn't catch it because my test case had the h-exten commented out. So, this corrects the code I missed, as a preventative against another crash report. Tested with the h-exten defined, all is well. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158603 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-21The passed extension may not be the same in the list as the current entry,tilghman1-1/+1
because we strip spaces when copying the extension into the structure. Therefore, use the copied item to place the item into the list. (found by lmadsen on -dev, fixed by me) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158600 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-21When compiling with DEBUG_THREADS, report the real file/func/line for ↵russell2-0/+26
ao2_lock/ao2_unlock git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158539 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-21(closes issue #13871)murf1-3/+5
Reported by: mdu113 This one is totally my fault. The code doesn't even create a bridge if the channel CDR has POST_DISABLED. I didn't check for that at the end of the bridge. Fixed with a few small insertions. Tested. Looks good. No cdr generated, no crash, no unnecc. data objects created either. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158483 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-21This change had somehow gotten reverted due to ammichelson1-2/+3
completely unrelated commit. Thanks to Theo Belder on the Asterisk-dev list for pointing this out. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158306 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-20There was an issue when attempting to reference an embeddedmmichelson4-41/+101
frame in a freed ast_filestream. This patch makes use of the ao2 functions to make sure that we do not free an ast_filestream structure until the embedded ast_frame has been "freed" as well. (closes issue #13496) Reported by: fst-onge Patches: filestream_frame_1_4.diff uploaded by putnopvut (license 60) Tested by: putnopvut Closes AST-89 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158126 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-20We don't handle 4XX responses to BYE well. According tommichelson1-0/+14
section 15 of RFC 3261, we should terminate a dialog if we receive a 481 or 408 in response to our BYE. Since I am aware of at least one phone manufacturer who may sometimes send a 404 as well, I am being liberal and saying that any 4XX response to a BYE should result in a terminated dialog. (closes issue #12994) Reported by: pabelanger Patches: 12994.patch uploaded by putnopvut (license 60) Closes AST-129 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158071 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-20Make sure to set the hangup cause on the calling channel in the casemmichelson2-0/+5
that ast_call() fails. For incoming SIP channels, this was causing us to send a 603 instead of a 486 when the call-limit was reached on the destination channel. (closes issue #13867) Reported by: still_nsk Patches: 13867.diff uploaded by putnopvut (license 60) Tested by: blitzrage git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158053 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-20Merged revision 157977 fromrmudgett1-31/+46
https://origsvn.digium.com/svn/asterisk/team/group/issue8824 ........ Fixes JIRA ABE-1726 The dial extension could be empty if you are using MISDN_KEYPAD to control ISDN provider features. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@158010 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19the gcc optimizer frequently finds broken code (use of uninitalized ↵kpfleming8-31/+82
variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems. with this build system change, if (and only if) --enable-dev-mode was used and DONT_OPTIMIZE is turned on, when a source file is compiled it will actually be preprocessed (into a .i or .ii file), then compiled once with optimization (with the result sent to /dev/null) and again without optimization (but only if the first compile succeeded, of course). while making these changes, i did some cleanup work in Makefile.rules to move commonly-used combinations of flag variables into their own variables, to make the file easier to read and maintain git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@157859 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18Add some missing invite state changes necessary in the sip_writemmichelson1-2/+4
function. Not setting the invite state correctly on the call was resulting in the Record application leaving empty files. I also have updated the doxygen comment next to the declaration of the INV_EARLY_MEDIA constant to reflect that we also use this state when we *send* a 18X response to an INVITE. (closes issue #13878) Reported by: nahuelgreco Patches: sip-early-media-recording-1.4.22.patch uploaded by nahuelgreco (license 162) Tested by: putnopvut git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@157503 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18(closes issue #13899)jpeeler1-1/+1
Reported by: akkornel This fix is the result of a bug fix in ast_app_separate_args r124395. If an argument does not exist it should always be set to a null string rather than a null pointer. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@157365 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18Fix a crash in the end_bridge_callback of app_dial andmmichelson5-1/+26
app_followme which would occur at the end of an attended transfer. The error occurred because we initially stored a pointer to an ast_channel which then was hung up due to a masquerade. This commit adds a "fixup" callback to the bridge_config structure to allow for end_bridge_callback_data to be changed in the case that a new channel pointer is needed for the end_bridge_callback. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@157305 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15when an individual directory dist-clean is run, run clean in that directory ↵kpfleming2-4/+6
first, and when running top-level dist-clean, do not run subdirectory clean operations twice git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@157163 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15dist-clean should remove dependency information files as wellkpfleming1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@157162 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15major update to doxygen configuration file:kpfleming1-77/+156
1) update to doxygen 1.5.x style file, as used in trunk 2) tell doxygen where are header files are, so include-file processing can be done 3) make all macros that are used to define variables/functions be expanded, so that doxygen will properly document the resulting variable/function 4) make all macros that are used to provide the contents of a variable (structure) be expanded, so that doxygen will be able to document the resulting fields 5) suppress compiler attributes (__attribute__(xxx)) from being seen by doxygen, so it will properly match up function definition and usage (for an example of th effect of this, look at the doxygen docs for ast_log() from before and afte this commit) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@157104 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14If the prompt to reenter a voicemail password timed out, itmmichelson1-1/+1
resulted in the password not being saved, even if the input matched what you gave when first prompted to enter a new password. This is because the return value of ast_readstring was checked, but not checked properly. This bug was discovered by Jared Smith during an Asterisk training course. Thanks for reporting it! git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156816 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14ast_waitfordigit() requires that the channel be up, for no good logicaltilghman1-1/+5
reason. This prevents While/EndWhile from working within the "h" extension. Reported by: jgalarneau (for ABE C.2) Fixed by: me git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156755 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13Provide more space for all the data which can appear in an originatingtilghman1-1/+2
channel name. (closes issue #13398) Reported by: bamby Patches: manager.c.diff uploaded by bamby (license 430) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156688 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13revert this change... non-functional changes don't belong herekpfleming2-8/+8
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156510 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13correct minor syntax error... no functional changekpfleming2-8/+8
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156485 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12When using call limits under 1 second, infinite call lengths are allowed,tilghman1-1/+4
instead. (closes issue #13851) Reported by: ruddy git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156386 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12It turns out that the 0x0XX00 codes being returned formurf1-3/+3
N, X, and Z are off by one, as per conversation with jsmith on #asterisk-dev; he was teaching a class and disconcerted that this published rule was not being followed, with patterns _NXX, _[1-8]22 and _[2-9]22... and NXX was winning, but [1-8] should have been. This change, tested on these 3 patterns now picks the proper one. However, this change may surprise users who set up dialplans based on previous behavior, which has been there for what, 2 and half years or so now. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156297 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12If the SLA thread is not started, then reload causes a memory leak.tilghman1-0/+4
(closes issue #13889) Reported by: eliel Patches: app_meetme.c.patch uploaded by eliel (license 64) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156294 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12For whatever reason, gcc only warned me about the possible use of an ↵jpeeler1-1/+1
uninitialized variable when compiling 1.6.1. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156289 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12Revert revision 132506, since it occasionally caused IAX2 HANGUP packets nottilghman1-3/+23
to be sent, and instead, schedule a task to destroy the iax2 pvt structure 10 seconds later. This allows the IAX2 HANGUP packet to be queued, transmitted, and ACKed before the pvt is destroyed. (closes issue #13645) Reported by: dzajro Patches: 20081111__bug13645__3.diff.txt uploaded by Corydon76 (license 14) Tested by: vazir Reviewed: http://reviewboard.digium.com/r/51/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156229 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12(closes issue #13173)jpeeler1-23/+149
Reported by: pep This change adds an announce_thread responsible for playing announcements to an existing conference. This allows all announcing to be immediately stopped if necessary but more importantly allows other threads that need to play something to not block. There are multiple benefits to this, but the actual bug is for solving the scenario for a channel to be unusable after hang up for the entire duration of the parting announcement. The parting announcement can be extremely long depending on what the user recorded upon joining the conference. Reviewed by Russell on Review Board: http://reviewboard.digium.com/r/25/ git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156178 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12When doing some tests, I was having a crash at the end of every callmmichelson1-0/+4
if an attended transfer occurred during the call. I traced the cause to the CDR on one of the channels being NULL. murf suggested a check in the end bridge callback to be sure the CDR is non-NULL before proceeding, so that's what I'm adding. git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156167 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12Move the sanity check that makes sure "always fork" is not set along with the russell1-6/+8
console option to be after the code that reads options from asterisk.conf. This resolves a situation where Asterisk can start taking up 100% when misconfigured. (Thanks to Bryce Porter (x86 on IRC) for letting me log in to his system to figure out what was causing the 100% CPU problem.) git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156164 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-10Channel drivers assume that when their indicate callbackmmichelson1-3/+9
is invoked, that the channel on which the callback was called is locked. This patch corrects an instance in chan_agent where a channel's indicate callback is called directly without first locking the channel. This was leading to some observed locking issues in chan_local, but considering that all channel drivers operate under the same expectations, the generic fix in chan_agent is the right way to go. AST-126 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@155861 f38db490-d61c-443f-a65b-d21fe96a405b