aboutsummaryrefslogtreecommitdiffstats
path: root/doc/janitor-projects.txt
diff options
context:
space:
mode:
Diffstat (limited to 'doc/janitor-projects.txt')
-rw-r--r--doc/janitor-projects.txt12
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/janitor-projects.txt b/doc/janitor-projects.txt
index 9d89ef18c..b111204f0 100644
--- a/doc/janitor-projects.txt
+++ b/doc/janitor-projects.txt
@@ -1,3 +1,15 @@
+ -- There a bunch of places where the result of pbx_builtin_getvar_helper()
+ gets stored and used. This is not threadsafe. This code should be replaced
+ with the following thread-safe version:
+
+ const char *var;
+
+ ast_channel_lock(chan);
+ if ((var = pbx_builtin_getvar_helper(chan, "MYVAR"))) {
+ var = ast_strdupa(var);
+ }
+ ast_channel_unlock(chan);
+
-- Convert all existing uses of astobj.h to astobj2.h
-- (chan_sip already in progress in a branch)