diff options
Diffstat (limited to 'apps')
-rw-r--r-- | apps/app_chanspy.c | 31 | ||||
-rw-r--r-- | apps/app_mixmonitor.c | 28 |
2 files changed, 15 insertions, 44 deletions
diff --git a/apps/app_chanspy.c b/apps/app_chanspy.c index f433c0d1a..56052a4a4 100644 --- a/apps/app_chanspy.c +++ b/apps/app_chanspy.c @@ -211,21 +211,6 @@ static int start_spying(struct ast_channel *chan, struct ast_channel *spychan, s return res; } -static void stop_spying(struct ast_channel_spy *spy) -{ - /* If our status has changed to DONE, then the channel we're spying on is gone.... - DON'T TOUCH IT!!! RUN AWAY!!! */ - if (spy->status == CHANSPY_DONE) - return; - - if (!spy->chan) - return; - - ast_channel_lock(spy->chan); - ast_channel_spy_remove(spy->chan, spy); - ast_channel_unlock(spy->chan); -}; - /* Map 'volume' levels from -4 through +4 into decibel (dB) settings for channel drivers */ @@ -327,10 +312,11 @@ static int channel_spy(struct ast_channel *chan, struct ast_channel *spyee, int */ while ((res = ast_waitfor(chan, -1) > -1) && csth.spy.status == CHANSPY_RUNNING && - !ast_check_hangup(chan) && csth.spy.chan) { - if (!(f = ast_read(chan))) + if (!(f = ast_read(chan)) || ast_check_hangup(chan)) { + running = -1; break; + } if (ast_test_flag(flags, OPTION_WHISPER) && (f->frametype == AST_FRAME_VOICE)) { @@ -381,13 +367,16 @@ static int channel_spy(struct ast_channel *chan, struct ast_channel *spyee, int else ast_deactivate_generator(chan); - stop_spying(&csth.spy); + /* If a channel still exists on our spy structure then we need to remove ourselves */ + if (csth.spy.chan) { + csth.spy.status = CHANSPY_DONE; + ast_channel_spy_remove(csth.spy.chan, &csth.spy); + } + ast_channel_spy_free(&csth.spy); if (option_verbose >= 2) ast_verbose(VERBOSE_PREFIX_2 "Done Spying on channel %s\n", name); - ast_mutex_destroy(&csth.spy.lock); - return running; } @@ -532,6 +521,8 @@ static int common_exec(struct ast_channel *chan, const struct ast_flags *flags, peer = NULL; } } + if (res == -1) + break; } ast_clear_flag(chan, AST_FLAG_SPYING); diff --git a/apps/app_mixmonitor.c b/apps/app_mixmonitor.c index aa7602f65..5038776a3 100644 --- a/apps/app_mixmonitor.c +++ b/apps/app_mixmonitor.c @@ -122,23 +122,6 @@ AST_APP_OPTIONS(mixmonitor_opts, { AST_APP_OPTION_ARG('W', MUXFLAG_VOLUME, OPT_ARG_VOLUME), }); -static void stopmon(struct ast_channel_spy *spy) -{ - struct ast_channel *chan = spy->chan; - - /* If our status has changed to DONE, then the channel we're spying on is gone.... - DON'T TOUCH IT!!! RUN AWAY!!! */ - if (spy->status == CHANSPY_DONE) - return; - - if (!chan) - return; - - ast_channel_lock(chan); - ast_channel_spy_remove(chan, spy); - ast_channel_unlock(chan); -} - static int startmon(struct ast_channel *chan, struct ast_channel_spy *spy) { struct ast_channel *peer; @@ -176,9 +159,8 @@ static void *mixmonitor_thread(void *obj) ast_channel_spy_trigger_wait(&mixmonitor->spy); - if (!mixmonitor->spy.chan || mixmonitor->spy.status != CHANSPY_RUNNING) { + if (!mixmonitor->spy.chan || mixmonitor->spy.status != CHANSPY_RUNNING) break; - } while (1) { if (!(f = ast_channel_spy_read_frame(&mixmonitor->spy, SAMPLES_PER_FRAME))) @@ -194,15 +176,15 @@ static void *mixmonitor_thread(void *obj) next = AST_LIST_NEXT(f, frame_list); if (write) ast_writestream(mixmonitor->fs, f); - ast_frfree(f); + ast_frame_free(f, 0); } } } ast_mutex_unlock(&mixmonitor->spy.lock); - - stopmon(&mixmonitor->spy); + ast_channel_spy_free(&mixmonitor->spy); + if (option_verbose > 1) ast_verbose(VERBOSE_PREFIX_2 "End MixMonitor Recording %s\n", mixmonitor->name); @@ -211,8 +193,6 @@ static void *mixmonitor_thread(void *obj) ast_verbose(VERBOSE_PREFIX_2 "Executing [%s]\n", mixmonitor->post_process); ast_safe_system(mixmonitor->post_process); } - - ast_mutex_destroy(&mixmonitor->spy.lock); ast_closestream(mixmonitor->fs); |