diff options
author | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
---|---|---|
committer | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
commit | 47c8ea00b89b1941c88858209af9be34740d7b4a (patch) | |
tree | 66604362a97aec13e31eae19ea0258e0042b8397 /utils | |
parent | 93798f79e2a924d37153ea63869ee78786837519 (diff) |
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88166 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'utils')
-rw-r--r-- | utils/extconf.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/utils/extconf.c b/utils/extconf.c index 0d30cc9f9..fa31102eb 100644 --- a/utils/extconf.c +++ b/utils/extconf.c @@ -5700,6 +5700,7 @@ static void pbx_substitute_variables_helper_full(struct ast_channel *c, struct v char *vars, *vare; int pos, brackets, needsub, len; + *cp2 = 0; /* just in case there's nothing to do */ whereweare=tmp=cp1; while (!ast_strlen_zero(whereweare) && count) { /* Assume we're copying the whole remaining string */ @@ -5731,6 +5732,7 @@ static void pbx_substitute_variables_helper_full(struct ast_channel *c, struct v count -= pos; cp2 += pos; whereweare += pos; + *cp2 = 0; } if (nextvar) { @@ -5802,6 +5804,7 @@ static void pbx_substitute_variables_helper_full(struct ast_channel *c, struct v memcpy(cp2, cp4, length); count -= length; cp2 += length; + *cp2 = 0; } } else if (nextexp) { /* We have an expression. Find the start and end, and determine @@ -5859,6 +5862,7 @@ static void pbx_substitute_variables_helper_full(struct ast_channel *c, struct v ast_log(LOG_DEBUG, "Expression result is '%s'\n", cp2); count -= length; cp2 += length; + *cp2 = 0; } } else break; |