aboutsummaryrefslogtreecommitdiffstats
path: root/static-http
diff options
context:
space:
mode:
authormmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b>2010-04-30 20:08:15 +0000
committermmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b>2010-04-30 20:08:15 +0000
commit3722f0ac1c0777b4f85fc5899ff935ab82c564d5 (patch)
tree99fe0748670372932225c07ad84ac1e3d1c8e55c /static-http
parentd337ca36324d17c3507a9cd25b68a1c1a4dca03f (diff)
Fix potential crash from race condition due to accessing channel data without the channel locked.
In res_musiconhold.c, there are several places where a channel's stream's existence is checked prior to calling ast_closestream on it. The issue here is that in several cases, the channel was not locked while checking the stream. The result was that if two threads checked the state of the channel's stream at approximately the same time, then there could be a situation where both threads attempt to call ast_closestream on the channel's stream. The result here is that the refcount for the stream would go below 0, resulting in a crash. I have added proper channel locking to res_musiconhold.c to ensure that we do not try to check chan->stream without the channel locked. A Digium customer has been using this patch for several weeks and has not had any crashes since applying the patch. ABE-2147 git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@260345 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'static-http')
0 files changed, 0 insertions, 0 deletions