diff options
| author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-07-15 18:46:40 +0000 |
|---|---|---|
| committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-07-15 18:46:40 +0000 |
| commit | 4db5706de8e65695dc0c23fc16b9c9a967c29403 (patch) | |
| tree | 9d569121b7149739c55a69b51503aab5887d1aa9 /res | |
| parent | cdc7f99d9ae84d9938b41cce555ac877c250f9ee (diff) | |
Fix a couple of places in res_agi where the agi_commands lock would not be
released, causing a deadlock. (Reported by mvanbaak in #asterisk-dev,
discovered by bbryant's change to the lock tracking code to yell at you
if a thread exits with a lock still held)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@131072 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'res')
| -rw-r--r-- | res/res_agi.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/res/res_agi.c b/res/res_agi.c index b509ef67d..0f59855f5 100644 --- a/res/res_agi.c +++ b/res/res_agi.c @@ -2434,8 +2434,10 @@ static agi_command *find_command(char *cmds[], int exact) if (!e->cmda[y] && !exact) break; /* don't segfault if the next part of a command doesn't exist */ - if (!e->cmda[y]) + if (!e->cmda[y]) { + AST_RWLIST_UNLOCK(&agi_commands); return NULL; + } if (strcasecmp(e->cmda[y], cmds[y])) match = 0; } @@ -2443,8 +2445,10 @@ static agi_command *find_command(char *cmds[], int exact) a candidate (unless we're looking for a really inexact answer */ if ((exact > -1) && e->cmda[y]) match = 0; - if (match) + if (match) { + AST_RWLIST_UNLOCK(&agi_commands); return e; + } } AST_RWLIST_UNLOCK(&agi_commands); return NULL; |