diff options
| author | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
|---|---|---|
| committer | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
| commit | 47c8ea00b89b1941c88858209af9be34740d7b4a (patch) | |
| tree | 66604362a97aec13e31eae19ea0258e0042b8397 /res | |
| parent | 93798f79e2a924d37153ea63869ee78786837519 (diff) | |
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88166 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'res')
| -rw-r--r-- | res/ael/pval.c | 1 | ||||
| -rw-r--r-- | res/res_agi.c | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/res/ael/pval.c b/res/ael/pval.c index 4c26d1aa1..5deb01828 100644 --- a/res/ael/pval.c +++ b/res/ael/pval.c @@ -3788,7 +3788,6 @@ void add_extensions(struct ael_extension *exten) do { struct ael_priority *last = 0; - memset(realext, '\0', sizeof(realext)); /* make sure this is properly initialized */ pbx_substitute_variables_helper(NULL, exten->name, realext, sizeof(realext) - 1); if (exten->hints) { if (ast_add_extension2(exten->context, 0 /*no replace*/, realext, PRIORITY_HINT, NULL, exten->cidmatch, diff --git a/res/res_agi.c b/res/res_agi.c index 8f722f082..80dd168a3 100644 --- a/res/res_agi.c +++ b/res/res_agi.c @@ -1192,7 +1192,7 @@ static int handle_getvariable(struct ast_channel *chan, AGI *agi, int argc, char static int handle_getvariablefull(struct ast_channel *chan, AGI *agi, int argc, char **argv) { - char tmp[4096] = ""; + char tmp[4096]; struct ast_channel *chan2=NULL; if ((argc != 4) && (argc != 5)) |