diff options
author | phsultan <phsultan@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-05-23 11:02:21 +0000 |
---|---|---|
committer | phsultan <phsultan@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-05-23 11:02:21 +0000 |
commit | 3e7f8750f1c22da79cf7ede176935b1d448b675a (patch) | |
tree | 2eefb6effd1dab9591c4f590666508de269efb77 /res | |
parent | 8be0af63ee684227f84827332d9c535c7972499c (diff) |
Merged revisions 118020 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
........
r118020 | phsultan | 2008-05-23 12:33:21 +0200 (Fri, 23 May 2008) | 15 lines
- remove whitespaces between tags in received XML packets before giving
them to the parser ;
- report Gtalk error messages from a buddy to the console.
This patch makes Asterisk "Google Jingle" (chan_gtalk) implementation
work with Empathy. Note that this is only true for audio streams, not
video.
Thank you to PH for his great help!
(closes issue #12647)
Reported by: PH
Patches:
trunk-12647-1.diff uploaded by phsultan (license 73)
Tested by: phsultan, PH
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@118021 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'res')
-rw-r--r-- | res/res_jabber.c | 37 |
1 files changed, 34 insertions, 3 deletions
diff --git a/res/res_jabber.c b/res/res_jabber.c index d56505af8..653537df4 100644 --- a/res/res_jabber.c +++ b/res/res_jabber.c @@ -35,6 +35,7 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") +#include <ctype.h> #include <iksemel.h> #include "asterisk/channel.h" @@ -638,23 +639,53 @@ static int aji_recv (struct aji_client *client, int timeout) { int len, ret; char buf[NET_IO_BUF_SIZE -1]; + char newbuf[NET_IO_BUF_SIZE -1]; + int pos = 0; + int newbufpos = 0; + unsigned char c; memset(buf, 0, sizeof(buf)); + memset(newbuf, 0, sizeof(newbuf)); while (1) { len = aji_io_recv(client, buf, NET_IO_BUF_SIZE - 1, timeout); if (len < 0) return IKS_NET_RWERR; if (len == 0) return IKS_NET_EXPIRED; buf[len] = '\0'; - + + /* our iksemel parser won't work as expected if we feed + it with XML packets that contain multiple whitespace + characters between tags */ + while (pos < len) { + c = buf[pos]; + /* if we stumble on the ending tag character, + we skip any whitespace that follows it*/ + if (c == '>') { + while (isspace(buf[pos+1])) { + pos++; + } + } + newbuf[newbufpos] = c; + newbufpos ++; + pos++; + } + pos = 0; + newbufpos = 0; + /* Log the message here, because iksemel's logHook is unaccessible */ aji_log_hook(client, buf, len, 1); - - ret = iks_parse(client->p, buf, len, 0); + + /* let iksemel deal with the string length, + and reset our buffer */ + ret = iks_parse(client->p, newbuf, 0, 0); + memset(newbuf, 0, sizeof(newbuf)); + if (ret != IKS_OK) { + ast_log(LOG_WARNING, "XML parsing failed\n"); return ret; } + ast_debug(3, "XML parsing successful\n"); } return IKS_OK; } |