diff options
author | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
---|---|---|
committer | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
commit | 47c8ea00b89b1941c88858209af9be34740d7b4a (patch) | |
tree | 66604362a97aec13e31eae19ea0258e0042b8397 /pbx/pbx_loopback.c | |
parent | 93798f79e2a924d37153ea63869ee78786837519 (diff) |
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88166 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'pbx/pbx_loopback.c')
-rw-r--r-- | pbx/pbx_loopback.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pbx/pbx_loopback.c b/pbx/pbx_loopback.c index dcbef909b..3221fb65d 100644 --- a/pbx/pbx_loopback.c +++ b/pbx/pbx_loopback.c @@ -87,7 +87,6 @@ static char *loopback_helper(char *buf, int buflen, const char *exten, const cha char tmp[80]; snprintf(tmp, sizeof(tmp), "%d", priority); - memset(buf, 0, buflen); AST_LIST_HEAD_INIT_NOLOCK(&headp); AST_LIST_INSERT_HEAD(&headp, ast_var_assign("EXTEN", exten), entries); AST_LIST_INSERT_HEAD(&headp, ast_var_assign("CONTEXT", context), entries); @@ -141,8 +140,9 @@ static int loopback_canmatch(struct ast_channel *chan, const char *context, cons static int loopback_exec(struct ast_channel *chan, const char *context, const char *exten, int priority, const char *callerid, const char *data) { + int found; LOOPBACK_COMMON; - res = ast_spawn_extension(chan, newcontext, newexten, newpriority, callerid); + res = ast_spawn_extension(chan, newcontext, newexten, newpriority, callerid, &found, 0); /* XXX hmmm... res is overridden ? */ if (newpattern && !ast_extension_match(newpattern, exten)) res = -1; |