diff options
author | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-08-20 22:53:48 +0000 |
---|---|---|
committer | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-08-20 22:53:48 +0000 |
commit | 8b5681e22acd883fc692455b460a6385e521b683 (patch) | |
tree | ba8c79a84cc6cbddcd2d849a6b9895d6124c4452 /main | |
parent | 160c516178ec81b8a2321f84b18ea8cece00f142 (diff) |
This change set fixes bug 8126 in trunk. It is implemented via compile time options, activated via the menuselect stuff, which defaults to the old way. non-zero sample data added. Translate tables expressed in microseconds instead of milliseconds, with 5-digit data now instead of 3, giving 2 more digits of precision.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@80113 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'main')
-rw-r--r-- | main/alaw.c | 138 | ||||
-rw-r--r-- | main/translate.c | 21 | ||||
-rw-r--r-- | main/ulaw.c | 165 |
3 files changed, 292 insertions, 32 deletions
diff --git a/main/alaw.c b/main/alaw.c index d388d1e61..fbc99b0fe 100644 --- a/main/alaw.c +++ b/main/alaw.c @@ -18,7 +18,7 @@ /*! \file * - * \brief u-Law to Signed linear conversion + * \brief a-Law to Signed linear conversion * * \author Mark Spencer <markster@digium.com> */ @@ -28,18 +28,20 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") #include "asterisk/alaw.h" +#include "asterisk/logger.h" +#ifndef G711_NEW_ALGORITHM #define AMI_MASK 0x55 -static inline unsigned char linear2alaw (short int linear) +static inline unsigned char linear2alaw(short int linear) { int mask; int seg; int pcm_val; static int seg_end[8] = - { - 0xFF, 0x1FF, 0x3FF, 0x7FF, 0xFFF, 0x1FFF, 0x3FFF, 0x7FFF - }; + { + 0xFF, 0x1FF, 0x3FF, 0x7FF, 0xFFF, 0x1FFF, 0x3FFF, 0x7FFF + }; pcm_val = linear; if (pcm_val >= 0) { @@ -50,7 +52,7 @@ static inline unsigned char linear2alaw (short int linear) mask = AMI_MASK; pcm_val = -pcm_val; } - + /* Convert the scaled magnitude to segment number. */ for (seg = 0; seg < 8; seg++) { if (pcm_val <= seg_end[seg]) @@ -59,13 +61,56 @@ static inline unsigned char linear2alaw (short int linear) /* Combine the sign, segment, and quantization bits. */ return ((seg << 4) | ((pcm_val >> ((seg) ? (seg + 3) : 4)) & 0x0F)) ^ mask; } -/*- End of function --------------------------------------------------------*/ +#else +static unsigned char linear2alaw(short sample, int full_coding) +{ + static const unsigned exp_lut[128] = { + 1,1,2,2,3,3,3,3, + 4,4,4,4,4,4,4,4, + 5,5,5,5,5,5,5,5, + 5,5,5,5,5,5,5,5, + 6,6,6,6,6,6,6,6, + 6,6,6,6,6,6,6,6, + 6,6,6,6,6,6,6,6, + 6,6,6,6,6,6,6,6, + 7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7 }; + unsigned sign, exponent, mantissa, mag; + unsigned char alawbyte; + + ast_alaw_get_sign_mag(sample, &sign, &mag); + if (mag > 32767) + mag = 32767; /* clip the magnitude for -32768 */ + + exponent = exp_lut[(mag >> 8) & 0x7f]; + mantissa = (mag >> (exponent + 3)) & 0x0f; + if (mag < 0x100) + exponent = 0; + + if (full_coding) { + /* full encoding, with sign and xform */ + alawbyte = (unsigned char)(sign | (exponent << 4) | mantissa); + alawbyte ^= AST_ALAW_AMI_MASK; + } else { + /* half-cooked coding -- mantissa+exponent only (for lookup tab) */ + alawbyte = (exponent << 4) | mantissa; + } + return alawbyte; +} +#endif +#ifndef G711_NEW_ALGORITHM static inline short int alaw2linear (unsigned char alaw) { int i; int seg; - + alaw ^= AMI_MASK; i = ((alaw & 0x0F) << 4); seg = (((int) alaw & 0x70) >> 4); @@ -73,8 +118,31 @@ static inline short int alaw2linear (unsigned char alaw) i = (i + 0x100) << (seg - 1); return (short int) ((alaw & 0x80) ? i : -i); } +#else +static inline short alaw2linear(unsigned char alawbyte) +{ + unsigned exponent, mantissa; + short sample; + + alawbyte ^= AST_ALAW_AMI_MASK; + exponent = (alawbyte & 0x70) >> 4; + mantissa = alawbyte & 0x0f; + sample = (mantissa << 4) + 8 /* rounding error */; + if (exponent) + sample = (sample + 0x100) << (exponent - 1); + if (!(alawbyte & 0x80)) + sample = -sample; + return sample; +} +#endif + + +#ifndef G711_NEW_ALGORITHM unsigned char __ast_lin2a[8192]; +#else +unsigned char __ast_lin2a[AST_ALAW_TAB_SIZE]; +#endif short __ast_alaw[256]; void ast_alaw_init(void) @@ -82,14 +150,62 @@ void ast_alaw_init(void) int i; /* * Set up mu-law conversion table - */ + */ +#ifndef G711_NEW_ALGORITHM for (i = 0; i < 256; i++) { - __ast_alaw[i] = alaw2linear(i); + __ast_alaw[i] = alaw2linear(i); } /* set up the reverse (mu-law) conversion table */ for (i = -32768; i < 32768; i++) { __ast_lin2a[((unsigned short)i) >> 3] = linear2alaw(i); } - +#else + for (i = 0; i < 256; i++) { + __ast_alaw[i] = alaw2linear(i); + } + /* set up the reverse (a-law) conversion table */ + for (i = 0; i <= 32768; i += AST_ALAW_STEP) { + AST_LIN2A_LOOKUP(i) = linear2alaw(i, 0 /* half-cooked */); + } +#endif + +#ifdef TEST_CODING_TABLES + for (i = -32768; i < 32768; ++i) { +#ifndef G711_NEW_ALGORITHM + unsigned char e1 = linear2alaw(i); +#else + unsigned char e1 = linear2alaw(i, 1); +#endif + short d1 = alaw2linear(e1); + unsigned char e2 = AST_LIN2A(i); + short d2 = alaw2linear(e2); + short d3 = AST_ALAW(e1); + + if (e1 != e2 || d1 != d3 || d2 != d3) { + ast_log(LOG_WARNING, "a-Law coding tables test failed on %d: e1=%u, e2=%u, d1=%d, d2=%d\n", + i, (unsigned)e1, (unsigned)e2, (int)d1, (int)d2); + } + } + ast_log(LOG_NOTICE, "a-Law coding tables test complete.\n"); +#endif /* TEST_CODING_TABLES */ + +#ifdef TEST_TANDEM_TRANSCODING + /* tandem transcoding test */ + for (i = -32768; i < 32768; ++i) { + unsigned char e1 = AST_LIN2A(i); + short d1 = AST_ALAW(e1); + unsigned char e2 = AST_LIN2A(d1); + short d2 = AST_ALAW(e2); + unsigned char e3 = AST_LIN2A(d2); + short d3 = AST_ALAW(e3); + + if (e1 != e2 || e2 != e3 || d1 != d2 || d2 != d3) { + ast_log(LOG_WARNING, "a-Law tandem transcoding test failed on %d: e1=%u, e2=%u, d1=%d, d2=%d, d3=%d\n", + i, (unsigned)e1, (unsigned)e2, (int)d1, (int)d2, (int)d3); + } + } + ast_log(LOG_NOTICE, "a-Law tandem transcoding test complete.\n"); +#endif /* TEST_TANDEM_TRANSCODING */ + } diff --git a/main/translate.c b/main/translate.c index 3f9ffd764..c26e627a2 100644 --- a/main/translate.c +++ b/main/translate.c @@ -46,7 +46,7 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") #include "asterisk/cli.h" #include "asterisk/term.h" -#define MAX_RECALC 200 /* max sample recalc */ +#define MAX_RECALC 1000 /* max sample recalc */ /*! \brief the list of translators */ static AST_RWLIST_HEAD_STATIC(translators, ast_translator); @@ -371,6 +371,7 @@ static void calc_cost(struct ast_translator *t, int seconds) int sofar=0; struct ast_trans_pvt *pvt; struct timeval start; + struct timeval end; int cost; if (!seconds) @@ -379,13 +380,13 @@ static void calc_cost(struct ast_translator *t, int seconds) /* If they don't make samples, give them a terrible score */ if (!t->sample) { ast_log(LOG_WARNING, "Translator '%s' does not produce sample frames.\n", t->name); - t->cost = 99999; + t->cost = 999999; return; } pvt = newpvt(t); if (!pvt) { ast_log(LOG_WARNING, "Translator '%s' appears to be broken and will probably fail.\n", t->name); - t->cost = 99999; + t->cost = 999999; return; } start = ast_tvnow(); @@ -395,7 +396,7 @@ static void calc_cost(struct ast_translator *t, int seconds) if (!f) { ast_log(LOG_WARNING, "Translator '%s' failed to produce a sample frame.\n", t->name); destroy(pvt); - t->cost = 99999; + t->cost = 999999; return; } framein(pvt, f); @@ -405,7 +406,8 @@ static void calc_cost(struct ast_translator *t, int seconds) ast_frfree(f); } } - cost = ast_tvdiff_ms(ast_tvnow(), start); + end = ast_tvnow(); + cost = ((end.tv_sec - start.tv_sec)*1000000) + end.tv_usec - start.tv_usec; destroy(pvt); t->cost = cost / seconds; if (!t->cost) @@ -516,7 +518,7 @@ static int show_translation(int fd, int argc, char *argv[]) AST_RWLIST_RDLOCK(&translators); - ast_cli(fd, " Translation times between formats (in milliseconds) for one second of data\n"); + ast_cli(fd, " Translation times between formats (in microseconds) for one second of data\n"); ast_cli(fd, " Source Format (Rows) Destination Format (Columns)\n\n"); /* Get the length of the longest (usable?) codec name, so we know how wide the left side should be */ for (x = 0; x < SHOW_TRANS; x++) { @@ -530,12 +532,13 @@ static int show_translation(int fd, int argc, char *argv[]) ast_str_set(&out, -1, " "); for (y = -1; y < SHOW_TRANS; y++) { curlen = strlen(ast_getformatname(1 << (y))); - + if (curlen < 5) + curlen = 5; if (x >= 0 && y >= 0 && tr_matrix[x][y].step) { - /* XXX 999 is a little hackish + /* XXX 99999 is a little hackish We don't want this number being larger than the shortest (or current) codec For now, that is "gsm" */ - ast_str_append(&out, -1, "%*d", curlen + 1, tr_matrix[x][y].cost > 999 ? 0 : tr_matrix[x][y].cost); + ast_str_append(&out, -1, "%*d", curlen + 1, tr_matrix[x][y].cost > 99999 ? 0 : tr_matrix[x][y].cost); } else if (x == -1 && y >= 0) { /* Top row - use a dynamic size */ ast_str_append(&out, -1, "%*s", curlen + 1, ast_getformatname(1 << (x + y + 1)) ); diff --git a/main/ulaw.c b/main/ulaw.c index 2735f6cce..8e47d8a77 100644 --- a/main/ulaw.c +++ b/main/ulaw.c @@ -28,15 +28,25 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") #include "asterisk/ulaw.h" +#include "asterisk/logger.h" +#if 0 +/* ZEROTRAP is the military recommendation to improve the encryption + * of u-Law traffic. It is irrelevant with modern encryption systems + * like AES, and will simply degrade the signal quality. + * ZEROTRAP is not implemented in AST_LIN2MU and so the coding table + * tests will fail if you use it */ #define ZEROTRAP /*!< turn on the trap as per the MIL-STD */ +#endif + #define BIAS 0x84 /*!< define the add-in bias for 16 bit samples */ #define CLIP 32635 +#ifndef G711_NEW_ALGORITHM + unsigned char __ast_lin2mu[16384]; short __ast_mulaw[256]; - static unsigned char linear2ulaw(short sample) { static int exp_lut[256] = { @@ -58,26 +68,102 @@ static unsigned char linear2ulaw(short sample) 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7 }; int sign, exponent, mantissa; unsigned char ulawbyte; - + /* Get the sample into sign-magnitude. */ sign = (sample >> 8) & 0x80; /* set aside the sign */ - if (sign != 0) + if (sign != 0) sample = -sample; /* get magnitude */ if (sample > CLIP) sample = CLIP; /* clip the magnitude */ - + /* Convert from 16 bit linear to ulaw. */ sample = sample + BIAS; exponent = exp_lut[(sample >> 7) & 0xFF]; mantissa = (sample >> (exponent + 3)) & 0x0F; ulawbyte = ~(sign | (exponent << 4) | mantissa); + #ifdef ZEROTRAP if (ulawbyte == 0) ulawbyte = 0x02; /* optional CCITT trap */ #endif + + return ulawbyte; +} + +#else + +unsigned char __ast_lin2mu[AST_ULAW_TAB_SIZE]; +short __ast_mulaw[256]; + +static unsigned char linear2ulaw(short sample, int full_coding) +{ + static const unsigned exp_lut[256] = { + 0,0,1,1,2,2,2,2,3,3,3,3,3,3,3,3, + 4,4,4,4,4,4,4,4,4,4,4,4,4,4,4,4, + 5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5, + 5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5, + 6,6,6,6,6,6,6,6,6,6,6,6,6,6,6,6, + 6,6,6,6,6,6,6,6,6,6,6,6,6,6,6,6, + 6,6,6,6,6,6,6,6,6,6,6,6,6,6,6,6, + 6,6,6,6,6,6,6,6,6,6,6,6,6,6,6,6, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7, + 7,7,7,7,7,7,7,7,7,7,7,7,7,7,7,7 }; + unsigned sign, exponent, mantissa, mag; + unsigned char ulawbyte; + + /* Get the sample into sign-magnitude. */ + ast_ulaw_get_sign_mag(sample, &sign, &mag); + if (mag > CLIP) + mag = CLIP; /* clip the magnitude */ + + sign = (sample >> 8) & 0x80; /* set aside the sign */ + if (sign != 0) + sample = -sample; /* get magnitude */ + if (sample > CLIP) + sample = CLIP; /* clip the magnitude */ + + /* Convert from 16 bit linear to ulaw. */ + mag += BIAS; + exponent = exp_lut[(mag >> 7) & 0xFF]; + mantissa = (mag >> (exponent + 3)) & 0x0F; + + if (full_coding) { + /* full encoding, with sign and xform */ + ulawbyte = ~(sign | (exponent << 4) | mantissa); +#ifdef ZEROTRAP + if (ulawbyte == 0) + ulawbyte = 0x02; /* optional CCITT trap */ +#endif + } else { + /* half-cooked coding -- mantissa+exponent only (for lookup tab) */ + ulawbyte = (exponent << 4) | mantissa; + } return ulawbyte; } + +static inline short ulaw2linear(unsigned char ulawbyte) +{ + unsigned exponent, mantissa; + short sample; + static const short etab[]={0,132,396,924,1980,4092,8316,16764}; + + ulawbyte = ~ulawbyte; + exponent = (ulawbyte & 0x70) >> 4; + mantissa = ulawbyte & 0x0f; + sample = mantissa << (exponent + 3); + sample += etab[exponent]; + if (ulawbyte & 0x80) + sample = -sample; + return sample; +} +#endif /*! * \brief Set up mu-law conversion table @@ -85,22 +171,77 @@ static unsigned char linear2ulaw(short sample) void ast_ulaw_init(void) { int i; - for (i = 0; i < 256; i++) { - short mu, e, f, y; - static short etab[] = {0,132,396,924,1980,4092,8316,16764}; - - mu = 255 - i; - e = (mu & 0x70) / 16; + + /* + * Set up mu-law conversion table + */ +#ifndef G711_NEW_ALGORITHM + for (i = 0;i < 256;i++) { + short mu,e,f,y; + static short etab[]={0,132,396,924,1980,4092,8316,16764}; + + mu = 255-i; + e = (mu & 0x70)/16; f = mu & 0x0f; y = f * (1 << (e + 3)); y += etab[e]; - if (mu & 0x80) - y = -y; + if (mu & 0x80) y = -y; __ast_mulaw[i] = y; } /* set up the reverse (mu-law) conversion table */ for (i = -32768; i < 32768; i++) { __ast_lin2mu[((unsigned short)i) >> 2] = linear2ulaw(i); } +#else + + for (i = 0; i < 256; i++) { + __ast_mulaw[i] = ulaw2linear(i); + } + /* set up the reverse (mu-law) conversion table */ + for (i = 0; i <= 32768; i += AST_ULAW_STEP) { + AST_LIN2MU_LOOKUP(i) = linear2ulaw(i, 0 /* half-cooked */); + } +#endif + +#ifdef TEST_CODING_TABLES + for (i = -32768; i < 32768; ++i) { +#ifndef G711_NEW_ALGORITHM + unsigned char e1 = linear2ulaw(i); +#else + unsigned char e1 = linear2ulaw(i, 1); +#endif + short d1 = ulaw2linear(e1); + unsigned char e2 = AST_LIN2MU(i); + short d2 = ulaw2linear(e2); + short d3 = AST_MULAW(e1); + + if (e1 != e2 || d1 != d3 || d2 != d3) { + ast_log(LOG_WARNING, "u-Law coding tables test failed on %d: e1=%u, e2=%u, d1=%d, d2=%d\n", + i, (unsigned)e1, (unsigned)e2, (int)d1, (int)d2); + } + } + ast_log(LOG_NOTICE, "u-Law coding table test complete.\n"); +#endif /* TEST_CODING_TABLES */ + +#ifdef TEST_TANDEM_TRANSCODING + /* tandem transcoding test */ + for (i = -32768; i < 32768; ++i) { + unsigned char e1 = AST_LIN2MU(i); + short d1 = AST_MULAW(e1); + unsigned char e2 = AST_LIN2MU(d1); + short d2 = AST_MULAW(e2); + unsigned char e3 = AST_LIN2MU(d2); + short d3 = AST_MULAW(e3); + + if (i < 0 && e1 == 0x7f && e2 == 0xff && e3 == 0xff) + continue; /* known and normal negative 0 case */ + + if (e1 != e2 || e2 != e3 || d1 != d2 || d2 != d3) { + ast_log(LOG_WARNING, "u-Law tandem transcoding test failed on %d: e1=%u, e2=%u, d1=%d, d2=%d, d3=%d\n", + i, (unsigned)e1, (unsigned)e2, (int)d1, (int)d2, (int)d3); + } + } + ast_log(LOG_NOTICE, "u-Law tandem transcoding test complete.\n"); +#endif /* TEST_TANDEM_TRANSCODING */ } |