diff options
author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-12-18 21:39:25 +0000 |
---|---|---|
committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-12-18 21:39:25 +0000 |
commit | bc48debd4dfbc47b379b6d4795df45e30d18b1bc (patch) | |
tree | e691a713ef308605523538521880c8eeec9bb5f0 /main/utils.c | |
parent | 16ac4622b74df861ddbb1e40a4e0818127fc7c4d (diff) |
Make ast_carefulwrite() be more careful.
This patch handles some additional cases that could result in partial writes
to the file description. This was done to address complaints about partial
writes on AMI.
(issue #13546) (more changes needed to address potential problems in 1.6)
Reported by: srt
Tested by: russell
Review: http://reviewboard.digium.com/r/99/
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@165796 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'main/utils.c')
-rw-r--r-- | main/utils.c | 51 |
1 files changed, 38 insertions, 13 deletions
diff --git a/main/utils.c b/main/utils.c index bbebe8b35..7bc854a95 100644 --- a/main/utils.c +++ b/main/utils.c @@ -921,29 +921,54 @@ int ast_wait_for_input(int fd, int ms) int ast_carefulwrite(int fd, char *s, int len, int timeoutms) { - /* Try to write string, but wait no more than ms milliseconds - before timing out */ int res = 0; - struct pollfd fds[1]; + while (len) { + struct pollfd pfd = { + .fd = fd, + .events = POLLOUT, + }; + + /* poll() until the fd is writable without blocking */ + while ((res = poll(&pfd, 1, timeoutms)) <= 0) { + if (res == 0) { + /* timed out. */ + ast_log(LOG_NOTICE, "Timed out trying to write\n"); + return -1; + } else if (res == -1) { + /* poll() returned an error, check to see if it was fatal */ + + if (errno == EINTR || errno == EAGAIN) { + /* This was an acceptable error, go back into poll() */ + continue; + } + + /* Fatal error, bail. */ + ast_log(LOG_ERROR, "poll returned error: %s\n", strerror(errno)); + + return -1; + } + } + res = write(fd, s, len); - if ((res < 0) && (errno != EAGAIN)) { + + if (res < 0 && errno != EAGAIN && errno != EINTR) { + /* fatal error from write() */ + ast_log(LOG_ERROR, "write() returned error: %s\n", strerror(errno)); return -1; } - if (res < 0) + + if (res < 0) { + /* It was an acceptable error */ res = 0; + } + + /* Update how much data we have left to write */ len -= res; s += res; res = 0; - if (len) { - fds[0].fd = fd; - fds[0].events = POLLOUT; - /* Wait until writable again */ - res = poll(fds, 1, timeoutms); - if (res < 1) - return -1; - } } + return res; } |