When MD5 authentication is not possible because there is no challenge present,

either because the Challenge action was never issued, or some other reason,
give a proper error message and return an error instead of claiming that the
user wasn't found.
(reported by jsmith on IRC)


git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@63886 f38db490-d61c-443f-a65b-d21fe96a405b

1 files changed, 5 insertions, 0 deletions

diff --git a/main/manager.c b/main/manager.c
index 383411fbe..b7c37c925 100644
--- a/main/manager.c
+++ b/main/manager.c
@@ -946,6 +946,11 @@ static int authenticate(struct mansession *s, const struct message *m)
 							ast_config_destroy(cfg);
 							return -1;
 						}
+					} else {
+						ast_log(LOG_DEBUG, "MD5 authentication is not possible.  challenge: '%s'\n", 
+							S_OR(s->challenge, ""));
+						ast_config_destroy(cfg);
+						return -1;
 					}
 				} else if (password && !strcmp(password, pass)) {
 					break;