diff options
author | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-11-21 22:40:28 +0000 |
---|---|---|
committer | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-11-21 22:40:28 +0000 |
commit | de52c7b0d1787ebbeb826bc5531af3435e38b4e4 (patch) | |
tree | 1396cadc6647b84ca5207c4f7c9a725f0a43dc4d /main/features.c | |
parent | d0d333cc8bdb84ab7d0f0e65033fd783cccce0c5 (diff) |
Merged revisions 158484 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
................
r158484 | murf | 2008-11-21 14:47:16 -0700 (Fri, 21 Nov 2008) | 19 lines
Merged revisions 158483 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r158483 | murf | 2008-11-21 14:19:47 -0700 (Fri, 21 Nov 2008) | 11 lines
(closes issue #13871)
Reported by: mdu113
This one is totally my fault. The code doesn't even
create a bridge CDR if the channel CDR has POST_DISABLED.
I didn't check for that at the end of the bridge.
Fixed with a few small insertions. Tested. Looks
good. No cdr generated, no crash, no unnecc. data
objects created either.
........
................
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@158545 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'main/features.c')
-rw-r--r-- | main/features.c | 31 |
1 files changed, 18 insertions, 13 deletions
diff --git a/main/features.c b/main/features.c index 79acbcfbd..493cf569d 100644 --- a/main/features.c +++ b/main/features.c @@ -2186,23 +2186,25 @@ int ast_bridge_call(struct ast_channel *chan,struct ast_channel *peer,struct ast autoloopflag = ast_test_flag(chan, AST_FLAG_IN_AUTOLOOP); ast_set_flag(chan, AST_FLAG_IN_AUTOLOOP); if (res != AST_PBX_KEEPALIVE && !ast_test_flag(&(config->features_caller),AST_FEATURE_NO_H_EXTEN) && ast_exists_extension(chan, chan->context, "h", 1, chan->cid.cid_num)) { - struct ast_cdr *swapper; + struct ast_cdr *swapper = NULL; char savelastapp[AST_MAX_EXTENSION]; char savelastdata[AST_MAX_EXTENSION]; char save_exten[AST_MAX_EXTENSION]; int save_prio; int found = 0; /* set if we find at least one match */ - if (ast_opt_end_cdr_before_h_exten) { + if (bridge_cdr && ast_opt_end_cdr_before_h_exten) { ast_cdr_end(bridge_cdr); } /* swap the bridge cdr and the chan cdr for a moment, and let the endbridge dialplan code operate on it */ - swapper = chan->cdr; - ast_copy_string(savelastapp, bridge_cdr->lastapp, sizeof(bridge_cdr->lastapp)); - ast_copy_string(savelastdata, bridge_cdr->lastdata, sizeof(bridge_cdr->lastdata)); ast_channel_lock(chan); - chan->cdr = bridge_cdr; + if (bridge_cdr) { + swapper = chan->cdr; + ast_copy_string(savelastapp, bridge_cdr->lastapp, sizeof(bridge_cdr->lastapp)); + ast_copy_string(savelastdata, bridge_cdr->lastdata, sizeof(bridge_cdr->lastdata)); + chan->cdr = bridge_cdr; + } ast_copy_string(save_exten, chan->exten, sizeof(save_exten)); save_prio = chan->priority; ast_copy_string(chan->exten, "h", sizeof(chan->exten)); @@ -2222,12 +2224,15 @@ int ast_bridge_call(struct ast_channel *chan,struct ast_channel *peer,struct ast ast_channel_lock(chan); ast_copy_string(chan->exten, save_exten, sizeof(chan->exten)); chan->priority = save_prio; - chan->cdr = swapper; + if (bridge_cdr) + chan->cdr = swapper; ast_set_flag(chan, AST_FLAG_BRIDGE_HANGUP_RUN); ast_channel_unlock(chan); /* protect the lastapp/lastdata against the effects of the hangup/dialplan code */ - ast_copy_string(bridge_cdr->lastapp, savelastapp, sizeof(bridge_cdr->lastapp)); - ast_copy_string(bridge_cdr->lastdata, savelastdata, sizeof(bridge_cdr->lastdata)); + if (bridge_cdr) { + ast_copy_string(bridge_cdr->lastapp, savelastapp, sizeof(bridge_cdr->lastapp)); + ast_copy_string(bridge_cdr->lastdata, savelastdata, sizeof(bridge_cdr->lastdata)); + } } ast_set2_flag(chan, autoloopflag, AST_FLAG_IN_AUTOLOOP); @@ -2237,10 +2242,10 @@ int ast_bridge_call(struct ast_channel *chan,struct ast_channel *peer,struct ast if (!new_chan_cdr || (new_chan_cdr && !ast_test_flag(new_chan_cdr, AST_CDR_FLAG_POST_DISABLED))) { struct ast_channel *chan_ptr = NULL; - ast_cdr_end(bridge_cdr); - - ast_cdr_detach(bridge_cdr); - + if (bridge_cdr) { + ast_cdr_end(bridge_cdr); + ast_cdr_detach(bridge_cdr); + } /* do a specialized reset on the beginning channel CDR's, if they still exist, so as not to mess up issues in future bridges; |