diff options
author | file <file@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-04-25 19:21:54 +0000 |
---|---|---|
committer | file <file@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-04-25 19:21:54 +0000 |
commit | 6038c1b458cb5fdf4b376054d550a59936775ce4 (patch) | |
tree | 984c0ba0ef8d6d6187522d0e47795733059fdb99 /main/cli.c | |
parent | 9c435dda79d5e9608ab446151502b193391d84e9 (diff) |
Merged revisions 61804 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61804 | file | 2007-04-25 14:52:50 -0400 (Wed, 25 Apr 2007) | 2 lines
Merge rewritten group counting support. No more storing data on the variable list of the channels. That was bad, mmmk? (issue #7497 reported by sabbathbh)
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@61805 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'main/cli.c')
-rw-r--r-- | main/cli.c | 34 |
1 files changed, 13 insertions, 21 deletions
diff --git a/main/cli.c b/main/cli.c index 9665fcbfa..57093319e 100644 --- a/main/cli.c +++ b/main/cli.c @@ -1289,10 +1289,8 @@ static int group_show_channels(int fd, int argc, char *argv[]) { #define FORMAT_STRING "%-25s %-20s %-20s\n" - struct ast_channel *c = NULL; + struct ast_group_info *gi = NULL; int numchans = 0; - struct ast_var_t *current; - struct varshead *headp; regex_t regexbuf; int havepattern = 0; @@ -1306,26 +1304,20 @@ static int group_show_channels(int fd, int argc, char *argv[]) } ast_cli(fd, FORMAT_STRING, "Channel", "Group", "Category"); - while ( (c = ast_channel_walk_locked(c)) != NULL) { - headp=&c->varshead; - AST_LIST_TRAVERSE(headp,current,entries) { - if (!strncmp(ast_var_name(current), GROUP_CATEGORY_PREFIX "_", strlen(GROUP_CATEGORY_PREFIX) + 1)) { - if (!havepattern || !regexec(®exbuf, ast_var_value(current), 0, NULL, 0)) { - ast_cli(fd, FORMAT_STRING, c->name, ast_var_value(current), - (ast_var_name(current) + strlen(GROUP_CATEGORY_PREFIX) + 1)); - numchans++; - } - } else if (!strcmp(ast_var_name(current), GROUP_CATEGORY_PREFIX)) { - if (!havepattern || !regexec(®exbuf, ast_var_value(current), 0, NULL, 0)) { - ast_cli(fd, FORMAT_STRING, c->name, ast_var_value(current), "(default)"); - numchans++; - } - } + + ast_app_group_list_lock(); + + gi = ast_app_group_list_head(); + while (gi) { + if (!havepattern || !regexec(®exbuf, gi->group, 0, NULL, 0)) { + ast_cli(fd, FORMAT_STRING, gi->chan->name, gi->group, (ast_strlen_zero(gi->category) ? "(default)" : gi->category)); + numchans++; } - numchans++; - ast_channel_unlock(c); + gi = AST_LIST_NEXT(gi, list); } - + + ast_app_group_list_unlock(); + if (havepattern) regfree(®exbuf); |