diff options
| author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-09-09 01:47:56 +0000 |
|---|---|---|
| committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-09-09 01:47:56 +0000 |
| commit | 8fa2e42c38d7753f70b5f3b55e90ad75a916b9c6 (patch) | |
| tree | 74ee904837c93f9d938049329e18c0bfb7aaf43d /main/channel.c | |
| parent | 9c23c45ae90f5700cb89695a96f0373fa2316005 (diff) | |
Modify ast_answer() to not hold the channel lock while calling ast_safe_sleep()
or when calling ast_waitfor(). These are inappropriate times to hold the channel
lock. This is what has caused "could not get the channel lock" messages from
chan_sip and has likely caused a negative impact on performance results of SIP
in Asterisk 1.6. Thanks to file for pointing out this section of code.
(closes issue #13287)
(closes issue #13115)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@141949 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'main/channel.c')
| -rw-r--r-- | main/channel.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/main/channel.c b/main/channel.c index b19c4c929..fd496e5f0 100644 --- a/main/channel.c +++ b/main/channel.c @@ -1674,16 +1674,21 @@ int __ast_answer(struct ast_channel *chan, unsigned int delay) return -1; } + ast_channel_unlock(chan); + switch (chan->_state) { case AST_STATE_RINGING: case AST_STATE_RING: - if (chan->tech->answer) + ast_channel_lock(chan); + if (chan->tech->answer) { res = chan->tech->answer(chan); + } ast_setstate(chan, AST_STATE_UP); ast_cdr_answer(chan->cdr); - if (delay) + ast_channel_unlock(chan); + if (delay) { ast_safe_sleep(chan, delay); - else { + } else { struct ast_frame *f; int ms = ANSWER_WAIT_MS; while (1) { @@ -1719,8 +1724,8 @@ int __ast_answer(struct ast_channel *chan, unsigned int delay) default: break; } + chan->visible_indication = 0; - ast_channel_unlock(chan); return res; } |