diff options
| author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-04-08 12:35:57 +0000 |
|---|---|---|
| committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-04-08 12:35:57 +0000 |
| commit | 7578403318a8d71f60f83b4c956bc1d5b7964515 (patch) | |
| tree | 196c9daa0f5f9c1a1d1fd20f6f249d2f276610f8 /include/asterisk/doxygen | |
| parent | cb3c695481ebea99904738b8fddfe451c67939b6 (diff) | |
Update some comments and resolve potential memory corruption in chan_sip.
While browsing chan_sip the other day, I noticed this dangerous code in
dialog_needdestroy(). This function is an ao2_callback. It is absolutely
_not_ okay to unlock the container from within this function. It's also not
clear why it was useful. Given that it could cause memory corruption, I have
removed it.
There was also a TODO comment left describing a potential implementation of
an improvement to the needdestroy handling. I'm not convinced that what was
described is the best choice here, so I have briefly described the way that
this function is used today that could be improved.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@186928 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'include/asterisk/doxygen')
0 files changed, 0 insertions, 0 deletions