diff options
| author | qwell <qwell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-06-14 15:21:29 +0000 |
|---|---|---|
| committer | qwell <qwell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-06-14 15:21:29 +0000 |
| commit | 14dbc53ff0071d7e221a7f658050c4bc8410d391 (patch) | |
| tree | 1435af922a6dc50d318380c21c94e6a8c1aea7e7 /funcs | |
| parent | e3baff5ddf83dc10fa0bafc1d21af81e959f2bb7 (diff) | |
Merged revisions 69258 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r69258 | qwell | 2007-06-14 10:15:53 -0500 (Thu, 14 Jun 2007) | 4 lines
Change a quite broken while loop to a for loop, so "continue;" works as expected instead of eating 99% CPU...
Issue 9966, patch by me.
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@69259 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'funcs')
| -rw-r--r-- | funcs/func_groupcount.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/funcs/func_groupcount.c b/funcs/func_groupcount.c index f08f0241c..93ec1e52f 100644 --- a/funcs/func_groupcount.c +++ b/funcs/func_groupcount.c @@ -47,7 +47,7 @@ static int group_count_function_read(struct ast_channel *chan, char *cmd, if ((count = ast_app_group_get_count(group, category)) == -1) ast_log(LOG_NOTICE, "No group could be found for channel '%s'\n", chan->name); - else + else snprintf(buf, len, "%d", count); return 0; @@ -101,15 +101,13 @@ static int group_function_read(struct ast_channel *chan, char *cmd, ast_app_group_list_lock(); - gi = ast_app_group_list_head(); - while (gi) { + for (gi = ast_app_group_list_head(); gi; gi = AST_LIST_NEXT(gi, list)) { if (gi->chan != chan) continue; if (ast_strlen_zero(data)) break; if (!ast_strlen_zero(gi->category) && !strcasecmp(gi->category, data)) break; - gi = AST_LIST_NEXT(gi, list); } if (gi) @@ -159,23 +157,21 @@ static int group_list_function_read(struct ast_channel *chan, char *cmd, ast_app_group_list_lock(); - gi = ast_app_group_list_head(); - while (gi) { + for (gi = ast_app_group_list_head(); gi; gi = AST_LIST_NEXT(gi, list)) { if (gi->chan != chan) continue; if (!ast_strlen_zero(tmp1)) { ast_copy_string(tmp2, tmp1, sizeof(tmp2)); if (!ast_strlen_zero(gi->category)) snprintf(tmp1, sizeof(tmp1), "%s %s@%s", tmp2, gi->group, gi->category); - else + else snprintf(tmp1, sizeof(tmp1), "%s %s", tmp2, gi->group); } else { if (!ast_strlen_zero(gi->category)) snprintf(tmp1, sizeof(tmp1), "%s@%s", gi->group, gi->category); - else + else snprintf(tmp1, sizeof(tmp1), "%s", gi->group); } - gi = AST_LIST_NEXT(gi, list); } ast_app_group_list_unlock(); |