prevent copying of NULL (bug #4307)

git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5708 f38db490-d61c-443f-a65b-d21fe96a405b

1 files changed, 6 insertions, 4 deletions

diff --git a/funcs/func_logic.c b/funcs/func_logic.c
index d20b7719f..8df1732ba 100755
--- a/funcs/func_logic.c
+++ b/funcs/func_logic.c
@@ -52,12 +52,14 @@ static char *builtin_function_if(struct ast_channel *chan, char *cmd, char *data
 				*iffalse = '\0';
 				iffalse++;
 			}
-		} else 
-			iffalse = "";
+		} 
+
 		if (expr && iftrue) {
 			ret = ast_true(expr) ? iftrue : iffalse;
-			strncpy(buf, ret, len);
-			ret = buf;
+			if (ret) {
+				ast_copy_string(buf, ret, len);
+				ret = buf;
+			}
 		} else {
 			ast_log(LOG_WARNING, "Syntax $(if <expr>?[<truecond>][:<falsecond>])\n");
 			ret = NULL;