diff options
author | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
---|---|---|
committer | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
commit | 47c8ea00b89b1941c88858209af9be34740d7b4a (patch) | |
tree | 66604362a97aec13e31eae19ea0258e0042b8397 /funcs/func_strings.c | |
parent | 93798f79e2a924d37153ea63869ee78786837519 (diff) |
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88166 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'funcs/func_strings.c')
-rw-r--r-- | funcs/func_strings.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/funcs/func_strings.c b/funcs/func_strings.c index f4869f4da..0ed4bc159 100644 --- a/funcs/func_strings.c +++ b/funcs/func_strings.c @@ -48,7 +48,7 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") static int function_fieldqty(struct ast_channel *chan, const char *cmd, char *parse, char *buf, size_t len) { - char *varsubst, varval[8192] = "", *varval2 = varval; + char *varsubst, varval[8192], *varval2 = varval; int fieldcount = 0; AST_DECLARE_APP_ARGS(args, AST_APP_ARG(varname); @@ -734,8 +734,6 @@ static struct ast_custom_function strptime_function = { static int function_eval(struct ast_channel *chan, const char *cmd, char *data, char *buf, size_t len) { - memset(buf, 0, len); - if (ast_strlen_zero(data)) { ast_log(LOG_WARNING, "EVAL requires an argument: EVAL(<string>)\n"); return -1; |