diff options
author | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-07-02 21:09:18 +0000 |
---|---|---|
committer | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-07-02 21:09:18 +0000 |
commit | ca1d54fd32089eedea8f3a12d1109ec362d87f21 (patch) | |
tree | 906f6417fb12eb6cf1dca0056a1638c8738ffc6d /doc | |
parent | 912d3b446152fa619158a351eda9edea449f7c96 (diff) |
Add a janitor project to use ARRAY_LEN instead of in-line
sizeof() and division.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127566 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'doc')
-rw-r--r-- | doc/janitor-projects.txt | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/doc/janitor-projects.txt b/doc/janitor-projects.txt index a43f9c957..b3c1a75df 100644 --- a/doc/janitor-projects.txt +++ b/doc/janitor-projects.txt @@ -32,3 +32,11 @@ -- Audit all channel/res/app/etc. modules to ensure that they do not register any entrypoints with the Asterisk core until after they are ready to service requests; all config file reading/processing, structure allocation, etc. must be completed before Asterisk is made aware of any services the module offers. -- Ensure that Realtime-enabled modules do not depend on the order of columns returned by the database lookup (example: outboundproxy and host settings in chan_sip). + + -- There are several places in the code where the length of arrays is calculated in-line with sizeof() and division. A common place to find this is in for loops, like this: + + for (i = 0; i < sizeof(array)/sizeof(array[0]); i++) + + There is a macro in utils.h called ARRAY_LEN which should be used instead for readability's sake. + + for (i = 0; i < ARRAY_LEN(array); i++) |