diff options
| author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-03-28 22:52:02 +0000 |
|---|---|---|
| committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-03-28 22:52:02 +0000 |
| commit | 98197a94a97c33f3a5b0f951d13fe0ecbcd92c8c (patch) | |
| tree | 6641ee97c25084de42b2f33b8eed299b592bd399 /doc | |
| parent | 667187be08b1c7c155afbda3bcfa377fbfe73955 (diff) | |
Merged revisions 111908-111909 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
........
r111908 | russell | 2008-03-28 17:45:43 -0500 (Fri, 28 Mar 2008) | 3 lines
Note a minor race condition that I noticed while reviewing Jeff's changes
to this code.
........
r111909 | russell | 2008-03-28 17:50:46 -0500 (Fri, 28 Mar 2008) | 3 lines
Make some notes about common usage of pbx_builtin_getvar_helper() that is not
thread-safe.
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.0@111910 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/janitor-projects.txt | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/janitor-projects.txt b/doc/janitor-projects.txt index 9d89ef18c..b111204f0 100644 --- a/doc/janitor-projects.txt +++ b/doc/janitor-projects.txt @@ -1,3 +1,15 @@ + -- There a bunch of places where the result of pbx_builtin_getvar_helper() + gets stored and used. This is not threadsafe. This code should be replaced + with the following thread-safe version: + + const char *var; + + ast_channel_lock(chan); + if ((var = pbx_builtin_getvar_helper(chan, "MYVAR"))) { + var = ast_strdupa(var); + } + ast_channel_unlock(chan); + -- Convert all existing uses of astobj.h to astobj2.h -- (chan_sip already in progress in a branch) |