diff options
author | tilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-08-10 20:14:34 +0000 |
---|---|---|
committer | tilghman <tilghman@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-08-10 20:14:34 +0000 |
commit | fea057f6474ed94062cf3cbf4ad096bba62d6832 (patch) | |
tree | e189c9a20520ae30231ac1c6573db5f3a289b84c /doc/CODING-GUIDELINES | |
parent | 247584d4d4239bc8da24b94e97211296de846046 (diff) |
Changes to make 1.4.26 into 1.4.26.1v1.4.26.1
git-svn-id: http://svn.digium.com/svn/asterisk/tags/1.4.26.1@211596 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'doc/CODING-GUIDELINES')
-rw-r--r-- | doc/CODING-GUIDELINES | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/doc/CODING-GUIDELINES b/doc/CODING-GUIDELINES index c3ffacd3c..67837e928 100644 --- a/doc/CODING-GUIDELINES +++ b/doc/CODING-GUIDELINES @@ -284,6 +284,18 @@ you wish to put into it (even if you did not allocate the buffer yourself), use a direct strcpy(), as it can be inlined and optimized to simple processor operations, unlike ast_copy_string(). +* String conversions +-------------------- + +When converting from strings to integers or floats, use the sscanf function +in preference to the atoi and atof family of functions, as sscanf detects +errors. Always check the return value of sscanf to verify that your numeric +variables successfully scanned before using them. Also, to avoid a potential +libc bug, always specify a maximum width for each conversion specifier, +including integers and floats. A good length for both integers and floats is +30, as this is more than generous, even if you're using doubles or long +integers. + * Use of functions ------------------ |