diff options
| author | rizzo <rizzo@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-06-03 23:34:01 +0000 |
|---|---|---|
| committer | rizzo <rizzo@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-06-03 23:34:01 +0000 |
| commit | 5fe44dda7645ae343f45670710a27cc5f34bea40 (patch) | |
| tree | 1918461a652da4c1f25cc9d0c6817789b164485b /channels | |
| parent | 093f7912103754c23a8b64501ebbfcfc00288b0e (diff) | |
mark XXX some places where there is a return right before
a large "else" block, which is suitable for a reduction of
the nesting depth.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@31870 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'channels')
| -rw-r--r-- | channels/chan_sip.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 4b8947f46..63897dcf3 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -6750,6 +6750,9 @@ static enum check_auth_result check_auth(struct sip_pvt *p, struct sip_request * sip_scheddestroy(p, SIP_TRANS_TIMEOUT); return AUTH_CHALLENGE_SENT; } else { /* We have auth, so check it */ + + /* XXX reduce nesting here */ + /* Whoever came up with the authentication section of SIP can suck my %&#$&* for not putting an example in the spec of just what it is you're doing a hash on. */ char a1_hash[256]; @@ -12602,6 +12605,8 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req, ast_set_flag(&p->flags[0], SIP_NEEDDESTROY); return 0; } else { + /* XXX reduce nesting here */ + /* Initialize tag for new subscriptions */ if (ast_strlen_zero(p->tag)) make_our_tag(p->tag, sizeof(p->tag)); @@ -12700,6 +12705,7 @@ static int handle_request_subscribe(struct sip_pvt *p, struct sip_request *req, ast_set_flag(&p->flags[0], SIP_NEEDDESTROY); return 0; } else { + /* XXX reduce nesting here */ struct sip_pvt *p_old; transmit_response(p, "200 OK", req); |