diff options
| author | twilson <twilson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-09-22 23:10:09 +0000 |
|---|---|---|
| committer | twilson <twilson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2010-09-22 23:10:09 +0000 |
| commit | fcca2ea91a02e58717221a94f46085fa2405d7c2 (patch) | |
| tree | aa416fd8927268e77a59ae9b517651b5ada75b5f /channels | |
| parent | 1dcfcfcb95360a7adc6cb61fa04db57c43ef8797 (diff) | |
Merged revisions 288499 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r288499 | twilson | 2010-09-22 16:00:30 -0700 (Wed, 22 Sep 2010) | 8 lines
Don't let a Local channel get bridged to itself
If a local channel gets bridged to itself, it becomes orphaned with no devices
left to actually tell it to hang up. This patch modifies local_fixup() to detect
this case and deny it.
Review: https://reviewboard.asterisk.org/r/934
........
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.6.2@288500 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'channels')
| -rw-r--r-- | channels/chan_local.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/channels/chan_local.c b/channels/chan_local.c index 62568ca57..835ae88de 100644 --- a/channels/chan_local.c +++ b/channels/chan_local.c @@ -531,6 +531,15 @@ static int local_fixup(struct ast_channel *oldchan, struct ast_channel *newchan) p->owner = newchan; else p->chan = newchan; + + /* Do not let a masquerade cause a Local channel to be bridged to itself! */ + if (p->owner->_bridge == p->chan || p->chan->_bridge == p->owner) { + ast_log(LOG_WARNING, "You can not bridge a Local channel to itself!\n"); + ast_mutex_unlock(&p->lock); + ast_queue_hangup(newchan); + return -1; + } + ast_mutex_unlock(&p->lock); return 0; } |