diff options
| author | qwell <qwell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2011-01-24 17:20:03 +0000 |
|---|---|---|
| committer | qwell <qwell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2011-01-24 17:20:03 +0000 |
| commit | 58c3f0fcba19be4e308481fdb1cb8a2234217c74 (patch) | |
| tree | f9c93275dfa187cb2fdad171daa279c4dea0c50a /channels | |
| parent | 989df76bcbfa4c6ab8c4bf2758c0a1d9558c88e0 (diff) | |
Merged revisions 303285 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r303285 | qwell | 2011-01-21 15:48:09 -0600 (Fri, 21 Jan 2011) | 15 lines
Merged revisions 303284 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r303284 | qwell | 2011-01-21 15:45:34 -0600 (Fri, 21 Jan 2011) | 8 lines
Reset configuration before parsing users.conf.
Some values configured in chan_dahdi.conf were able to leak in to users.conf
configuration. This was surprising users, and potentially setting non-sane
"defaults".
ASTNOW-125
........
................
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.8@303467 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'channels')
| -rw-r--r-- | channels/chan_dahdi.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c index 7bb664535..7da07debe 100644 --- a/channels/chan_dahdi.c +++ b/channels/chan_dahdi.c @@ -17494,7 +17494,7 @@ static void deep_copy_dahdi_chan_conf(struct dahdi_chan_conf *dest, const struct * \retval 0 on success. * \retval -1 on error. */ -static int setup_dahdi_int(int reload, struct dahdi_chan_conf *base_conf, struct dahdi_chan_conf *conf) +static int setup_dahdi_int(int reload, struct dahdi_chan_conf *default_conf, struct dahdi_chan_conf *base_conf, struct dahdi_chan_conf *conf) { struct ast_config *cfg; struct ast_config *ucfg; @@ -17652,6 +17652,8 @@ static int setup_dahdi_int(int reload, struct dahdi_chan_conf *base_conf, struct if (ucfg) { const char *chans; + /* Reset base_conf, so things dont leak from dahdi_chan.conf */ + deep_copy_dahdi_chan_conf(base_conf, default_conf); process_dahdi(base_conf, "", ast_variable_browse(ucfg, "general"), 1, 0); for (cat = ast_category_browse(ucfg, NULL); cat ; cat = ast_category_browse(ucfg, cat)) { @@ -17738,14 +17740,16 @@ static int setup_dahdi_int(int reload, struct dahdi_chan_conf *base_conf, struct static int setup_dahdi(int reload) { int res; + struct dahdi_chan_conf default_conf = dahdi_chan_conf_default(); struct dahdi_chan_conf base_conf = dahdi_chan_conf_default(); struct dahdi_chan_conf conf = dahdi_chan_conf_default(); - if (base_conf.chan.cc_params && conf.chan.cc_params) { - res = setup_dahdi_int(reload, &base_conf, &conf); + if (default_conf.chan.cc_params && base_conf.chan.cc_params && conf.chan.cc_params) { + res = setup_dahdi_int(reload, &default_conf, &base_conf, &conf); } else { res = -1; } + ast_cc_config_params_destroy(default_conf.chan.cc_params); ast_cc_config_params_destroy(base_conf.chan.cc_params); ast_cc_config_params_destroy(conf.chan.cc_params); |