diff options
| author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-05-10 13:22:15 +0000 |
|---|---|---|
| committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-05-10 13:22:15 +0000 |
| commit | d99b677f3501944b7aaf82375ef62a88e5fa3933 (patch) | |
| tree | 167bf7a9b6b330883dc9bf865672132658710ffd /channels/chan_agent.c | |
| parent | a6b2177d50659d049694ca79f6cbe00f54dd0a93 (diff) | |
remove almost all of the checks of the result from ast_strdupa() or alloca().
As it turns out, all of these checks were useless, because alloca will never
return NULL.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@26451 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'channels/chan_agent.c')
| -rw-r--r-- | channels/chan_agent.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/channels/chan_agent.c b/channels/chan_agent.c index 8da8b5d9c..c62eaf6d3 100644 --- a/channels/chan_agent.c +++ b/channels/chan_agent.c @@ -294,8 +294,7 @@ static struct agent_pvt *add_agent(char *agent, int pending) char *agt = NULL; struct agent_pvt *p; - if (!(parse = ast_strdupa(agent))) - return NULL; + parse = ast_strdupa(agent); /* Extract username (agt), password and name from agent (args). */ AST_NONSTANDARD_APP_ARGS(args, parse, ','); @@ -1751,10 +1750,7 @@ static int __login_exec(struct ast_channel *chan, void *data, int callbackmode) LOCAL_USER_ADD(u); - if (!(parse = ast_strdupa(data))) { - LOCAL_USER_REMOVE(u); - return -1; - } + parse = ast_strdupa(data); AST_STANDARD_APP_ARGS(args, parse); @@ -2486,8 +2482,7 @@ static int function_agent(struct ast_channel *chan, char *cmd, char *data, char return -1; } - if (!(parse = ast_strdupa(data))) - return -1; + parse = ast_strdupa(data); AST_NONSTANDARD_APP_ARGS(args, parse, ':'); if (!args.item) |