diff options
| author | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
|---|---|---|
| committer | murf <murf@f38db490-d61c-443f-a65b-d21fe96a405b> | 2007-11-01 22:26:51 +0000 |
| commit | 47c8ea00b89b1941c88858209af9be34740d7b4a (patch) | |
| tree | 66604362a97aec13e31eae19ea0258e0042b8397 /cdr | |
| parent | 93798f79e2a924d37153ea63869ee78786837519 (diff) | |
This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88166 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'cdr')
| -rw-r--r-- | cdr/cdr_custom.c | 1 | ||||
| -rw-r--r-- | cdr/cdr_manager.c | 1 | ||||
| -rw-r--r-- | cdr/cdr_sqlite3_custom.c | 2 |
3 files changed, 1 insertions, 3 deletions
diff --git a/cdr/cdr_custom.c b/cdr/cdr_custom.c index fa4eb11c4..fe65abd8c 100644 --- a/cdr/cdr_custom.c +++ b/cdr/cdr_custom.c @@ -119,7 +119,6 @@ static int custom_log(struct ast_cdr *cdr) if (ast_strlen_zero(master)) return 0; - memset(buf, 0 , sizeof(buf)); /* Quite possibly the first use of a static struct ast_channel, we need it so the var funcs will work */ memset(&dummy, 0, sizeof(dummy)); dummy.cdr = cdr; diff --git a/cdr/cdr_manager.c b/cdr/cdr_manager.c index 6e3dd87a3..4fa66b560 100644 --- a/cdr/cdr_manager.c +++ b/cdr/cdr_manager.c @@ -143,7 +143,6 @@ static int manager_log(struct ast_cdr *cdr) ast_strftime(strEndTime, sizeof(strEndTime), DATE_FORMAT, &timeresult); /* Custom fields handling */ - memset(buf, 0 , sizeof(buf)); if (customfields != NULL && customfields->used > 0) { memset(&dummy, 0, sizeof(dummy)); dummy.cdr = cdr; diff --git a/cdr/cdr_sqlite3_custom.c b/cdr/cdr_sqlite3_custom.c index c6eb8b5ba..26ec6ff19 100644 --- a/cdr/cdr_sqlite3_custom.c +++ b/cdr/cdr_sqlite3_custom.c @@ -158,7 +158,7 @@ static int sqlite3_log(struct ast_cdr *cdr) { /* Make it obvious that only sql_cmd should be used outside of this block */ char *sql_tmp_cmd; - char sql_insert_cmd[2048] = ""; + char sql_insert_cmd[2048]; sql_tmp_cmd = sqlite3_mprintf("INSERT INTO %q (%q) VALUES (%q)", table, columns, values); dummy.cdr = cdr; pbx_substitute_variables_helper(&dummy, sql_tmp_cmd, sql_insert_cmd, sizeof(sql_insert_cmd) - 1); |