diff options
| author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-07-22 00:08:21 +0000 |
|---|---|---|
| committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2006-07-22 00:08:21 +0000 |
| commit | 593233e983278cf53b30aa19738b6508e778c151 (patch) | |
| tree | 8d02adf996ab55c020efe1ae43108e080e76d970 /autoservice.c | |
| parent | 89e319954318210c7b32ce1b8ef0edbec89ff44b (diff) | |
remove an XXX comment and document that ast_autoservice_start() will return -1
if the channel is already in the autoservice list.
Why is this a valid case to return -1, you ask? Well, there should never be
any code where it is not clear if the channel is in autoservice or not because
trying to read frames from a channel that is in the autoservice list will lead
to bad results because more than one thread will be waiting on frames to arrive
on the channel and then trying to read them.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@38076 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'autoservice.c')
| -rw-r--r-- | autoservice.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/autoservice.c b/autoservice.c index c0adc7f2b..51a1e1ca6 100644 --- a/autoservice.c +++ b/autoservice.c @@ -104,7 +104,6 @@ int ast_autoservice_start(struct ast_channel *chan) if (as->chan == chan) break; } - /* XXX if found, we return -1, why ??? */ /* If not, start autoservice on channel */ if (!as && (as = ast_calloc(1, sizeof(*as)))) { |