Massive cleanups to applications for LOCAL_USER handling and some other things.

In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application.  An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6832 f38db490-d61c-443f-a65b-d21fe96a405b

1 files changed, 10 insertions, 2 deletions

diff --git a/apps/app_zapras.c b/apps/app_zapras.c
index 76a81bd70..6e2ea3aef 100755
--- a/apps/app_zapras.c
+++ b/apps/app_zapras.c
@@ -197,14 +197,22 @@ static void run_ras(struct ast_channel *chan, char *args)
 static int zapras_exec(struct ast_channel *chan, void *data)
 {
 	int res=-1;
-	char args[256];
+	char *args;
 	struct localuser *u;
 	ZT_PARAMS ztp;
 
 	if (!data) 
 		data = "";
+
 	LOCAL_USER_ADD(u);
-	ast_copy_string(args, data, sizeof(args));
+
+	args = ast_strdupa(data);
+	if (!args) {
+		ast_log(LOG_ERROR, "Out of memory\n");
+		LOCAL_USER_REMOVE(u);
+		return -1;
+	}
+	
 	/* Answer the channel if it's not up */
 	if (chan->_state != AST_STATE_UP)
 		ast_answer(chan);