diff options
| author | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-11-14 15:18:59 +0000 |
|---|---|---|
| committer | mmichelson <mmichelson@f38db490-d61c-443f-a65b-d21fe96a405b> | 2008-11-14 15:18:59 +0000 |
| commit | 4ed5575dc7ef24aadbfe102fca4bcbcc835a90e6 (patch) | |
| tree | caf1d45c9d7db767fe34f7e8e1931924f4a83f12 /apps/app_voicemail.c | |
| parent | bfa05db5fac6413d46d5d643c8aa561d3b0dd994 (diff) | |
If the prompt to reenter a voicemail password timed out, it
resulted in the password not being saved, even if the input matched
what you gave when first prompted to enter a new password. This is
because the return value of ast_readstring was checked, but not checked
properly.
This bug was discovered by Jared Smith during an Asterisk training course.
Thanks for reporting it!
git-svn-id: http://svn.digium.com/svn/asterisk/branches/1.4@156816 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'apps/app_voicemail.c')
| -rw-r--r-- | apps/app_voicemail.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c index b42e1e4fa..fdb848cec 100644 --- a/apps/app_voicemail.c +++ b/apps/app_voicemail.c @@ -6847,7 +6847,7 @@ static int vm_options(struct ast_channel *chan, struct ast_vm_user *vmu, struct if (cmd < 0) break; - if ((cmd = ast_readstring(chan,newpassword2 + strlen(newpassword2),sizeof(newpassword2)-1,2000,10000,"#"))) { + if ((cmd = ast_readstring(chan,newpassword2 + strlen(newpassword2),sizeof(newpassword2)-1,2000,10000,"#")) < 0) { break; } } |