diff options
author | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2005-10-19 18:19:02 +0000 |
---|---|---|
committer | russell <russell@f38db490-d61c-443f-a65b-d21fe96a405b> | 2005-10-19 18:19:02 +0000 |
commit | 58818426d60d583c4becc6a99b398cbac1b7b12f (patch) | |
tree | 5fee3540f8d72d45cd1b2e5bf15e5860581dd4f8 /apps/app_transfer.c | |
parent | a4d6ea67a7536e2cb2337527357ce6d3db8639f3 (diff) |
Massive cleanups to applications for LOCAL_USER handling and some other things.
In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application. An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6832 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'apps/app_transfer.c')
-rwxr-xr-x | apps/app_transfer.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/apps/app_transfer.c b/apps/app_transfer.c index 7a1d17b6f..44e1b24d9 100755 --- a/apps/app_transfer.c +++ b/apps/app_transfer.c @@ -38,6 +38,10 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") #include "asterisk/module.h" #include "asterisk/options.h" +STANDARD_LOCAL_USER; + +LOCAL_USER_DECL; + static const char *tdesc = "Transfer"; static const char *app = "Transfer"; @@ -61,10 +65,6 @@ static const char *descrip = "successful and there exists a priority n + 101,\n" "then that priority will be taken next.\n" ; -STANDARD_LOCAL_USER; - -LOCAL_USER_DECL; - static int transfer_exec(struct ast_channel *chan, void *data) { int res; @@ -81,12 +81,15 @@ static int transfer_exec(struct ast_channel *chan, void *data) return 0; } + LOCAL_USER_ADD(u); + if ((slash = strchr(dest, '/')) && (len = (slash - dest))) { tech = dest; dest = slash + 1; /* Allow execution only if the Tech/destination agrees with the type of the channel */ if (strncasecmp(chan->type, tech, len)) { pbx_builtin_setvar_helper(chan, "TRANSFERSTATUS", "FAILURE"); + LOCAL_USER_REMOVE(u); return 0; } } @@ -94,11 +97,10 @@ static int transfer_exec(struct ast_channel *chan, void *data) /* Check if the channel supports transfer before we try it */ if (!chan->tech->transfer) { pbx_builtin_setvar_helper(chan, "TRANSFERSTATUS", "UNSUPPORTED"); + LOCAL_USER_REMOVE(u); return 0; } - LOCAL_USER_ADD(u); - res = ast_transfer(chan, dest); if (res < 0) { |