Massive cleanups to applications for LOCAL_USER handling and some other things.

In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application.  An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6832 f38db490-d61c-443f-a65b-d21fe96a405b

1 files changed, 6 insertions, 2 deletions

diff --git a/apps/app_md5.c b/apps/app_md5.c
index 11f59a05f..e5f062235 100755
--- a/apps/app_md5.c
+++ b/apps/app_md5.c
@@ -72,11 +72,13 @@ static int md5_exec(struct ast_channel *chan, void *data)
 		dep_warning = 1;
 	}	
 
-	if (!data) {
+	if (!data || ast_strlen_zero(data)) {
 		ast_log(LOG_WARNING, "Syntax: md5(<varname>=<string>) - missing argument!\n");
 		return -1;
 	}
+	
 	LOCAL_USER_ADD(u);
+
 	memset(retvar,0, sizeof(retvar));
 	string = ast_strdupa(data);
 	varname = strsep(&string,"=");
@@ -107,11 +109,13 @@ static int md5check_exec(struct ast_channel *chan, void *data)
 		dep_warning = 1;
 	}
 	
-	if (!data) {
+	if (!data || ast_strlen_zero(data)) {
 		ast_log(LOG_WARNING, "Syntax: MD5Check(<md5hash>,<string>) - missing argument!\n");
 		return -1;
 	}
+	
 	LOCAL_USER_ADD(u);
+	
 	memset(newhash,0, sizeof(newhash));
 
 	string = ast_strdupa(data);