Massive cleanups to applications for LOCAL_USER handling and some other things.

In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application.  An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6832 f38db490-d61c-443f-a65b-d21fe96a405b

1 files changed, 8 insertions, 3 deletions

diff --git a/apps/app_math.c b/apps/app_math.c
index 225c929df..8f351b519 100755
--- a/apps/app_math.c
+++ b/apps/app_math.c
@@ -108,14 +108,19 @@ static int math_exec(struct ast_channel *chan, void *data)
 		deprecation_warning = 1;
 	}
 
-	if (!data) {
+	if (!data || ast_strlen_zero(data)) {
 		ast_log(LOG_WARNING, "No parameters passed. !\n");
 		return -1;
 	}
 
 	LOCAL_USER_ADD(u);
-		
-	s = ast_strdupa((void *) data);
+
+	s = ast_strdupa(data);
+	if (!s) {
+		ast_log(LOG_ERROR, "Out of memory\n");
+		LOCAL_USER_REMOVE(u);
+		return -1;
+	}
 
 	mvar = strsep(&s, "|");
 	mvalue1 = strsep(&s, "|");