diff options
author | file <file@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-11-02 18:08:54 +0000 |
---|---|---|
committer | file <file@f38db490-d61c-443f-a65b-d21fe96a405b> | 2009-11-02 18:08:54 +0000 |
commit | ea8276040cb72a480542e3de194933a7caecf0a3 (patch) | |
tree | a838a4a7ad3ea3ebe1bb1680b2dcb4651776623b /apps/app_dial.c | |
parent | 225f4a7ea1c36f5ac0bf9ac7eb29122c3655cba2 (diff) |
Merged revisions 226889 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r226889 | file | 2009-11-02 14:08:11 -0400 (Mon, 02 Nov 2009) | 11 lines
Fix a bug where the recorded privacy introduction file would not get removed if the caller hung up
while the called party had not yet answered.
This was fixed by introducing an argument to the 'n' option which, when enabled, removes the introduction
file under all scenarios. This was done to preserve the behavior that has existed for quite some time.
(closes issue #14674)
Reported by: ulogic
Patches:
bug14674.patch uploaded by jpeeler (license 325)
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@226890 f38db490-d61c-443f-a65b-d21fe96a405b
Diffstat (limited to 'apps/app_dial.c')
-rw-r--r-- | apps/app_dial.c | 30 |
1 files changed, 29 insertions, 1 deletions
diff --git a/apps/app_dial.c b/apps/app_dial.c index 82dbb974e..910143d30 100644 --- a/apps/app_dial.c +++ b/apps/app_dial.c @@ -264,6 +264,13 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") Macro()</para></warning> </option> <option name="n"> + <argument name="delete"> + <para>With <replaceable>delete</replaceable> either not specified or set to <literal>0</literal>, + the recorded introduction will not be deleted if the caller hangs up while the remote party has not + yet answered.</para> + <para>With <replaceable>delete</replaceable> set to <literal>1</literal>, the introduction will + always be deleted.</para> + </argument> <para>This option is a modifier for the call screening/privacy mode. (See the <literal>p</literal> and <literal>P</literal> options.) It specifies that no introductions are to be saved in the <directory>priv-callerintros</directory> @@ -523,6 +530,7 @@ enum { OPT_ARG_PRIVACY, OPT_ARG_DURATION_STOP, OPT_ARG_OPERMODE, + OPT_ARG_SCREEN_NOINTRO, /* note: this entry _MUST_ be the last one in the enum */ OPT_ARG_ARRAY_SIZE, }; @@ -547,7 +555,7 @@ AST_APP_OPTIONS(dial_exec_options, BEGIN_OPTIONS AST_APP_OPTION_ARG('L', OPT_DURATION_LIMIT, OPT_ARG_DURATION_LIMIT), AST_APP_OPTION_ARG('m', OPT_MUSICBACK, OPT_ARG_MUSICBACK), AST_APP_OPTION_ARG('M', OPT_CALLEE_MACRO, OPT_ARG_CALLEE_MACRO), - AST_APP_OPTION('n', OPT_SCREEN_NOINTRO), + AST_APP_OPTION_ARG('n', OPT_SCREEN_NOINTRO, OPT_ARG_SCREEN_NOINTRO), AST_APP_OPTION('N', OPT_SCREEN_NOCALLERID), AST_APP_OPTION('o', OPT_ORIGINAL_CLID), AST_APP_OPTION_ARG('O', OPT_OPERMODE, OPT_ARG_OPERMODE), @@ -1581,6 +1589,7 @@ static int dial_exec_full(struct ast_channel *chan, const char *data, struct ast int result = 0; char *parse; int opermode = 0; + int delprivintro = 0; AST_DECLARE_APP_ARGS(args, AST_APP_ARG(peers); AST_APP_ARG(timeout); @@ -1621,6 +1630,15 @@ static int dial_exec_full(struct ast_channel *chan, const char *data, struct ast goto done; } + if (ast_test_flag64(&opts, OPT_SCREEN_NOINTRO) && !ast_strlen_zero(opt_args[OPT_ARG_SCREEN_NOINTRO])) { + delprivintro = atoi(opt_args[OPT_ARG_SCREEN_NOINTRO]); + + if (delprivintro < 0 || delprivintro > 1) { + ast_log(LOG_WARNING, "Unknown argument %d specified to n option, ignoring\n", delprivintro); + delprivintro = 0; + } + } + if (ast_test_flag64(&opts, OPT_OPERMODE)) { opermode = ast_strlen_zero(opt_args[OPT_ARG_OPERMODE]) ? 1 : atoi(opt_args[OPT_ARG_OPERMODE]); ast_verb(3, "Setting operator services mode to %d.\n", opermode); @@ -2323,6 +2341,16 @@ out: sentringing = 0; ast_indicate(chan, -1); } + + if (delprivintro && ast_fileexists(pa.privintro, NULL, NULL) > 0) { + ast_filedelete(pa.privintro, NULL); + if (ast_fileexists(pa.privintro, NULL, NULL) > 0) { + ast_log(LOG_NOTICE, "privacy: ast_filedelete didn't do its job on %s\n", pa.privintro); + } else { + ast_verb(3, "Successfully deleted %s intro file\n", pa.privintro); + } + } + ast_channel_early_bridge(chan, NULL); hanguptree(outgoing, NULL, 0); /* In this case, there's no answer anywhere */ pbx_builtin_setvar_helper(chan, "DIALSTATUS", pa.status); |